feat(t8s-cluster/artifacthub): use centralised helmRepositories template

[cwrau]

Summary by CodeRabbit

• Refactor
  • Streamlined Helm repository configuration by consolidating repository generation logic and centralizing schema definitions for improved maintainability.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[gemini-code-assist]

Summary of Changes

Hello @cwrau, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a significant refactoring to centralize the management and definition of Helm repositories within the t8s-cluster chart. By leveraging a common template for resource creation and an external schema for validation, the changes aim to improve maintainability, enforce consistency, and streamline future development efforts across related charts.

Highlights

• Centralized Helm Repository Definition: The logic for defining Helm repositories has been refactored to use a shared template, common.helm.repositories, promoting reusability and consistency across charts.
• Externalized Schema for Helm Repositories: The values.schema.json now references an external schema definition for global.helmRepositories from a common chart, ensuring standardized validation and reducing duplication.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[coderabbitai]

Walkthrough

Refactors Helm repository handling by consolidating template and schema definitions. Replaces inline HelmRepository generation loop with a shared template include and moves schema validation to an external reference, centralizing repository configuration management.

Changes

Cohort / File(s)	Summary
Template Refactoring charts/t8s-cluster/templates/management-cluster/repositories/helmRepositories.yaml	Replaces explicit per-repository loop and inline HelmRepository resource generation with a single include call to shared common.helm.repositories template, removing conditional per-entry logic and manual metadata/spec definitions.
Schema Consolidation charts/t8s-cluster/values.schema.json	Moves global.helmRepositories schema definition from inline object (with url, charts, condition properties) to external $ref targeting shared schema in teutonet/teutonet-helm-charts repository.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10–15 minutes

• Key attention areas:
  • Verify that the shared template common.helm.repositories exists and is correctly referenced at the expected path
  • Confirm the external schema reference URL is accessible and contains the expected helmRepositories definition
  • Ensure no functionality or validation constraints are lost in the migration (especially around url patterns and condition handling)
  • Test that HelmRepository resources are still generated correctly for all repository entries

Possibly related PRs

• feat(common/helm): add option to set namespace of HelmRepository #1757: This PR alters the shared common.helm.repositories template that is now being included by the main PR's refactored template.
• chore(t8s-cluster/flux): use centralised HelmRepositories instead of per-instance #1758: Directly related as it also modifies HelmRepository generation logic and naming in the same file.
• feat(t8s-cluster/management-cluster): add cluster-autoscaler deployment #1756: Adds autoscaler entry to global.helmRepositories that depends on the consolidated repository generation approach.

Suggested reviewers

• tasches
• marvinWolff
• teutonet-bot

Poem

🐰 A hop, skip, and leap of refactored cheer,
Shared templates unite what once was dear,
Schema now dances with external grace,
HelmRepos find their rightful place!
Centralized logic, clean and bright,
The cluster thrives in DRY delight! 🎉

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: refactoring helmRepositories generation to use a centralized template instead of inline definitions.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch feat/t8s-cluster/use-centralised-helmrepositories-template

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[gemini-code-assist]

Code Review

This pull request refactors the helmRepositories configuration to use a centralized template and schema, which is a great improvement for maintainability. However, the changes appear to be incomplete. The referenced common Helm template common.helm.repositories and the JSON schema definition helmRepositories are not present in the provided files. These omissions will lead to deployment and validation failures.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ae36393 and 9e447db.

📒 Files selected for processing (2)

• charts/t8s-cluster/templates/management-cluster/repositories/helmRepositories.yaml (1 hunks)
• charts/t8s-cluster/values.schema.json (1 hunks)

🧰 Additional context used

🪛 YAMLlint (1.37.1)

charts/t8s-cluster/templates/management-cluster/repositories/helmRepositories.yaml

[error] 3-3: syntax error: expected '', but found '{'

(syntax)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Agent

🔇 Additional comments (1)

charts/t8s-cluster/templates/management-cluster/repositories/helmRepositories.yaml (1)

2-4: Verify that the included template expects the wrapped context signature.

Line 3 passes context as (dict "context" .), which means the common.helm.repositories template must access the dot context via .context rather than directly via .. Ensure the template is designed to receive this wrapped dictionary signature.

Additionally, YAMLlint reports a syntax error on line 3, which is likely a false positive from the linter not understanding Helm templating syntax. Verify this renders correctly in your cluster.

Please confirm:

1. Does common.helm.repositories template access the context via .context or .?
2. Does the template render correctly when deployed to your cluster?

Alternatively, if the template expects the bare dot context, consider passing it directly:

-  {{- include "common.helm.repositories" (dict "context" .) -}}
+  {{- include "common.helm.repositories" . -}}

[Copilot]

Pull request overview

This PR attempts to refactor the t8s-cluster chart to use centralized helmRepositories template and schema definitions from the common chart. However, the referenced template (common.helm.repositories) and schema definition ($defs/helmRepositories) do not exist in the common chart (version 1.6.0), making this PR incomplete and non-functional.

Key changes:

• Replaces inline schema definition with external reference to common chart schema
• Replaces inline template logic with call to centralized common template

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
charts/t8s-cluster/values.schema.json	Replaces inline helmRepositories schema with external reference to non-existent common schema definition
charts/t8s-cluster/templates/management-cluster/repositories/helmRepositories.yaml	Replaces inline template logic with call to non-existent common.helm.repositories template

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.