feat(t8s-cluster/management-cluster): add cluster-autoscaler deployment by cwrau · Pull Request #1756 · teutonet/teutonet-helm-charts

cwrau · 2025-10-22T12:29:15Z

Summary by CodeRabbit

New Features
- Enabled cluster autoscaler deployment with automatic node pool discovery and cloud provider integration.
Changes
- Simplified cluster provisioning by removing pre-install cleanup operations for cloud-controller-manager, CNI, CSI, etcd defragmentation, and storage classes.

coderabbitai · 2025-10-22T12:29:36Z

Warning

Rate limit exceeded

@cwrau has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 0 minutes and 52 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between e84b075 and c892e90.

📒 Files selected for processing (8)

charts/t8s-cluster/templates/management-cluster/autoscaler.yaml (1 hunks)
charts/t8s-cluster/templates/workload-cluster/pre-install/_uninstall-job.yaml (0 hunks)
charts/t8s-cluster/templates/workload-cluster/pre-install/uninstall-cloud-controller-manager.yaml (0 hunks)
charts/t8s-cluster/templates/workload-cluster/pre-install/uninstall-cni.yaml (0 hunks)
charts/t8s-cluster/templates/workload-cluster/pre-install/uninstall-csi.yaml (0 hunks)
charts/t8s-cluster/templates/workload-cluster/pre-install/uninstall-etcd-defrag.yaml (0 hunks)
charts/t8s-cluster/templates/workload-cluster/pre-install/uninstall-storageclasses.yaml (0 hunks)
charts/t8s-cluster/values.yaml (1 hunks)

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

Walkthrough

Adds cluster autoscaler Flux HelmRelease deployment to management cluster with conditional enablement based on nodePool replica configuration. Removes pre-install uninstall workflow templates including Job, ServiceAccount, and RBAC resources previously used to clean resources during uninstall. Updates Helm repository values to include autoscaler chart reference.

Changes

Cohort / File(s)	Summary
Cluster Autoscaler Deployment `charts/t8s-cluster/templates/management-cluster/autoscaler.yaml`	New Helm template that conditionally renders a Flux HelmRelease for cluster-autoscaler. Deployment is enabled when any nodePool replica is a map. Configures auto-discovery, cloud provider integration via ClusterAPI, and extraArgs for scaling behavior and resource naming.
Pre-Install Uninstall Job Removal `charts/t8s-cluster/templates/workload-cluster/pre-install/_uninstall-job.yaml`	Removes complete uninstall Job template including ServiceAccount, Role, and RoleBinding resources that previously executed kubectl cleanup commands during pre-install phase.
Uninstall Invocation Removals `charts/t8s-cluster/templates/workload-cluster/pre-install/uninstall-cloud-controller-manager.yaml`, `uninstall-cni.yaml`, `uninstall-csi.yaml`, `uninstall-etcd-defrag.yaml`	Removes Helm template invocations that conditionally rendered uninstall jobs for cloud-controller-manager, CNI (Cilium), CSI, and etcd-defrag resources.
Storage Classes Uninstall Removal `charts/t8s-cluster/templates/workload-cluster/pre-install/uninstall-storageclasses.yaml`	Removes pre-install Job that deleted teutostack storage classes using kubectl with restricted security context and kubeconfig volume mounting.
Helm Repository Configuration `charts/t8s-cluster/values.yaml`	Adds autoscaler Helm repository entry with URL `https://kubernetes.github.io/autoscaler` and cluster-autoscaler chart version 9.52.1.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~40 minutes

Involves a significant architectural change: adding conditional cluster autoscaler deployment logic alongside complete removal of pre-install uninstall workflow infrastructure. Mixed patterns across multiple files require verification that resource cleanup logic is properly eliminated without unintended side effects, and that autoscaler enablement conditions align with nodePool configuration changes in related PRs.

Possibly related PRs

feat(t8s-cluster): implement autoscaling #1686: Implements complementary nodePool replica range handling and schema changes that enable the conditional logic driving autoscaler deployment in this PR.
chore(main): [bot] release t8s-cluster:9.4.1 #1755: Addresses replica type checking in management-cluster that directly supports the map-detection logic used to enable the autoscaler HelmRelease.

Suggested labels

t8s-cluster

Suggested reviewers

tasches
marvinWolff
teutonet-bot

Poem

🐰 A rabbit hops through Helm charts with glee,
Auto-scaling now, uninstall jobs flee!
ClusterAPI whispers secrets so keen,
Flux deploys wonders we've never seen.
Storage classes rest, pre-install dreams gone—
Bootstrap magic carries us on! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The pull request title "feat(t8s-cluster/management-cluster): add cluster-autoscaler deployment" is clearly related to the primary change in the changeset, which is the addition of a new Helm template (autoscaler.yaml) that deploys the cluster autoscaler in the management cluster. The title accurately identifies the main feature being introduced. While the changeset also includes removal of several pre-install uninstall templates from the workload-cluster and updates to values.yaml, these appear to be supporting changes or refactoring that accompany the primary autoscaler deployment feature. The title is concise, specific, and sufficiently clear for a teammate reviewing the repository history to understand the core purpose of this change.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Copilot

Pull Request Overview

This PR adds cluster-autoscaler deployment capabilities to the t8s-cluster management cluster, enabling automatic scaling of node pools based on resource utilization. The changes also clean up legacy pre-install uninstall jobs that are no longer needed.

Adds autoscaler Helm repository configuration and chart version specification
Implements conditional autoscaler HelmRelease deployment for clusters with autoscaling-enabled node pools
Removes obsolete pre-install cleanup jobs for various cluster components

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
charts/t8s-cluster/values.yaml	Adds autoscaler Helm repository URL and cluster-autoscaler chart version 9.52.1
charts/t8s-cluster/templates/management-cluster/autoscaler.yaml	Creates HelmRelease resource for cluster-autoscaler with Cluster API integration
charts/t8s-cluster/templates/workload-cluster/pre-install/uninstall-storageclasses.yaml	Removes legacy storage class cleanup job
charts/t8s-cluster/templates/workload-cluster/pre-install/uninstall-etcd-defrag.yaml	Removes legacy etcd-defrag cleanup job
charts/t8s-cluster/templates/workload-cluster/pre-install/uninstall-csi.yaml	Removes legacy CSI cleanup job
charts/t8s-cluster/templates/workload-cluster/pre-install/uninstall-cni.yaml	Removes legacy CNI cleanup job
charts/t8s-cluster/templates/workload-cluster/pre-install/uninstall-cloud-controller-manager.yaml	Removes legacy cloud controller manager cleanup job
charts/t8s-cluster/templates/workload-cluster/pre-install/_uninstall-job.yaml	Removes shared uninstall job template used by deleted cleanup jobs

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

charts/t8s-cluster/templates/management-cluster/autoscaler.yaml

🤖 I have created a release *beep* *boop* --- ## [9.5.0](t8s-cluster-v9.4.1...t8s-cluster-v9.5.0) (2026-01-15) ### Features * **t8s-cluster/artifacthub:** use centralised helmRepositories template ([#1846](#1846)) ([73a41f9](73a41f9)) * **t8s-cluster/cilium:** enable kubeProxy replacement ([#1815](#1815)) ([b3c412d](b3c412d)) * **t8s-cluster/management-cluster:** add cluster-autoscaler deployment ([#1756](#1756)) ([5b6ead9](5b6ead9)) * **t8s-cluster/management-cluster:** enable ImageVolume feature flag ([#1786](#1786)) ([9676ee0](9676ee0)) * **t8s-cluster/management-cluster:** set apiServerLoadBalancer.provider via TeutonetesCloud ([#1898](#1898)) ([6bf8889](6bf8889)) * **t8s-cluster/management-cluster:** switch to hcp ([#1759](#1759)) ([303b0b6](303b0b6)) * **t8s-cluster/management-cluster:** use new KubeletEnsureSecretPulledImages feature gate ([#1858](#1858)) ([40d7bef](40d7bef)) * **t8s-cluster:** migrate to CAPI v1beta2 ([#1685](#1685)) ([dc5f071](dc5f071)) ### Bug Fixes * **t8s-cluster/autoscaler:** these names are inside the workload cluster ([#1877](#1877)) ([f345cea](f345cea)) * **t8s-cluster/management-cluster:** leave out protocol if `nil` ([#1837](#1837)) ([f370dac](f370dac)) * **t8s-cluster:** only allow nodePools with valid k8s names ([#1851](#1851)) ([b9431c5](b9431c5)) ### Miscellaneous Chores * **t8s-cluster/dependencies:** update common docker tag to v1.6.0 ([#1811](#1811)) ([b3b4c94](b3b4c94)) * **t8s-cluster/dependencies:** update common docker tag to v1.7.0 ([#1873](#1873)) ([71e062f](71e062f)) * **t8s-cluster/dependencies:** update helm release cilium to v1.18.6 ([#1894](#1894)) ([e1adc88](e1adc88)) * **t8s-cluster/dependencies:** update helm release cluster-autoscaler to v9.53.0 ([#1856](#1856)) ([dc67fcd](dc67fcd)) * **t8s-cluster/dependencies:** update helm release openstack-cloud-controller-manager to v2.34.1 ([#1553](#1553)) ([e984d19](e984d19)) * **t8s-cluster/dependencies:** update registry.k8s.io/etcd docker tag to v3.5.24 ([#1793](#1793)) ([a5098e3](a5098e3)) * **t8s-cluster/dependencies:** update registry.k8s.io/etcd docker tag to v3.6.6 ([#1813](#1813)) ([e07ffa7](e07ffa7)) * **t8s-cluster/dependencies:** update registry.k8s.io/etcd docker tag to v3.6.7 ([#1895](#1895)) ([cf1d3b4](cf1d3b4)) * **t8s-cluster/flux:** use centralised HelmRepositories instead of per-instance ([#1758](#1758)) ([3deff65](3deff65)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

Copilot AI review requested due to automatic review settings October 22, 2025 12:29

cwrau requested review from marvinWolff, tasches and teutonet-bot as code owners October 22, 2025 12:29

cwrau enabled auto-merge October 22, 2025 12:29

github-actions bot assigned cwrau Oct 22, 2025

teutonet-bot added the t8s-cluster label Oct 22, 2025

Copilot AI reviewed Oct 22, 2025

View reviewed changes

charts/t8s-cluster/templates/management-cluster/autoscaler.yaml Outdated Show resolved Hide resolved

charts/t8s-cluster/templates/management-cluster/autoscaler.yaml Outdated Show resolved Hide resolved

marvinWolff reviewed Oct 22, 2025

View reviewed changes

charts/t8s-cluster/templates/management-cluster/autoscaler.yaml Show resolved Hide resolved

cwrau force-pushed the feat/t8s-cluster/add-cluster-autoscaler-deployment branch from e84b075 to 636fbdd Compare October 22, 2025 12:55

feat(t8s-cluster/management-cluster): add cluster-autoscaler deployment

c892e90

cwrau force-pushed the feat/t8s-cluster/add-cluster-autoscaler-deployment branch from 636fbdd to c892e90 Compare October 22, 2025 12:58

marvinWolff approved these changes Oct 22, 2025

View reviewed changes

cwrau added this pull request to the merge queue Oct 22, 2025

Merged via the queue into main with commit 5b6ead9 Oct 22, 2025
20 checks passed

cwrau deleted the feat/t8s-cluster/add-cluster-autoscaler-deployment branch October 22, 2025 13:33

teutonet-bot mentioned this pull request Oct 22, 2025

chore(main): [bot] release t8s-cluster:9.5.0 #1760

Merged

This was referenced Oct 22, 2025

chore(t8s-cluster/flux): use centralised HelmRepositories instead of per-instance #1758

Merged

feat(t8s-cluster/management-cluster): switch to hcp #1759

Merged

coderabbitai bot mentioned this pull request Dec 1, 2025

feat(t8s-cluster/artifacthub): use centralised helmRepositories template #1846

Merged

coderabbitai bot mentioned this pull request Dec 9, 2025

fix(t8s-cluster/autoscaler): these names are inside the workload cluster #1877

Merged

coderabbitai bot mentioned this pull request Feb 5, 2026

feat(t8s-cluster/management-cluster): ignore local storage for autoscaler #1973

Merged

coderabbitai bot mentioned this pull request Feb 24, 2026

fix(t8s-cluster): use plain values for autoScaling #2002

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(t8s-cluster/management-cluster): add cluster-autoscaler deployment#1756

feat(t8s-cluster/management-cluster): add cluster-autoscaler deployment#1756
cwrau merged 1 commit intomainfrom
feat/t8s-cluster/add-cluster-autoscaler-deployment

cwrau commented Oct 22, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Oct 22, 2025 •

edited

Loading

Rate limit exceeded

Other AI code review bot(s) detected

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

cwrau commented Oct 22, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Oct 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rate limit exceeded

Other AI code review bot(s) detected

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Pre-merge checks and finishing touches

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

cwrau commented Oct 22, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Oct 22, 2025 •

edited

Loading