Add export * as ns from "mod” updates.#1005
Add export * as ns from "mod” updates.#1005jdalton wants to merge 1 commit intotc39:masterfrom jdalton:proposal-export-ns-from
export * as ns from "mod” updates.#1005Conversation
ljharb
added
needs consensus
spec.html
Outdated
| <emu-alg> | ||
| 1. Let exportName be the StringValue of IdentifierName. | ||
| 1. Let _entry_ be the ExportEntry Record {[[ModuleRequest]]: _module_, [[ImportName]]: `"*"`, [[LocalName]]: *null*, [[ExportName]]: _exportName_ }. | ||
| 1. Return a new List containing _entry_ |
spec.html
Outdated
| <emu-grammar>ExportFromClause : `*`</emu-grammar> | ||
| <emu-alg> | ||
| 1. Let _entry_ be the ExportEntry Record {[[ModuleRequest]]: _module_, [[ImportName]]: `"*"`, [[LocalName]]: *null*, [[ExportName]]: *null* }. | ||
| 1. Return a new List containing _entry_ |
|
@jdalton i believe this needs tests and a rebase, and then it can come back to the committee for consensus? |
|
Yes. I think @leobalter is on task for tests. |
|
Hi @jdalton can you review this PR? tc39/proposal-export-ns-from#9 By the way I'm writing these test instead of @leobalter, expect next week :) |
Will do!
Thank you! |
|
Hey @jdalton -- when reviewing the spec changes I found them to be incomplete! More work needs to be done here, I tried to outline the problem clearly in this issue: tc39/proposal-export-ns-from#10 Probably this PR should be closed, and a new one opened after finishing the proposal? |
|
Please leave this one open, and update it as needed. |
|
We lost the reference of the source branch/fork of this PR, so we can’t update this same PR. I told Val the best workaround would be importing this PR content and add other commits in another PR. I can make some to keep the original author info if it helps. |
|
@leobalter No worries, do what's easiest. I don't care about the author cred for the PR. |
|
I'll draft some spec changes to the appropriate methods (outlined here: tc39/proposal-export-ns-from#10) and open a new PR next week! |
|
Before I open the new PR, would anyone like to review the changes in the pretty diff form: https://spectranaut.github.io/proposal-export-ns-from/ |
|
@spectranaut looks great to me (altho it should get many more eyes, and I'm not great on grammar/syntax stuff), i have a few small comments/questions but they can wait for the PR. |
|
@ljharb, @leobalter, @jdalton : I made a new PR: #1174 |
|
Moved to #1174. |
5 participants
This PR adds
export * as ns from "mod"updatesfrom tc39/proposal-export-ns-from to the spec as part of the July 27, 2017 notes.
Tests to tc39/test262 soon to follow. \cc @benjamn