This repository was archived by the owner on Feb 15, 2022. It is now read-only.
ExportedNames incomplete for NameSpaceExport production#9
Closed
spectranaut wants to merge 1 commit intotc39:masterfrom
Closed
ExportedNames incomplete for NameSpaceExport production#9spectranaut wants to merge 1 commit intotc39:masterfrom
spectranaut wants to merge 1 commit intotc39:masterfrom
Conversation
Member
|
Hi @spectranaut! You are totally more familiar with the formal spec text process than myself. I used to know the ins and outs back in the day, but now with so much meta/shorthand/composition spec syntax it's hard for me to follow. The PR looks good to me, but I'll defer to @bterlson for the real review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @jdalton, I'm pretty sure this is a necessary addition to the ExportedNames algorithm, can you review?
Presently, the ExportedNames has a rule for the production
NameSpaceExporthere:But no way to further evaluate the ExportedNames of NameSpaceExport.
I believe, because of the chain of production (and the line,
Return the ExportedNames of ExportFromClauseabove), we can replace these lines with: