Closed
Conversation
Signed-off-by: Stepan Blyshchak <stepanb@nvidia.com>
nazariig
reviewed
Oct 22, 2021
| } | ||
|
|
||
| leaf-list matches { | ||
| type string; |
There was a problem hiding this comment.
@stepanblyschak do we need a length constraint?
Owner
Author
There was a problem hiding this comment.
Not sure why there should be a limit. Redis allows key size 512Mb which is ridiculously big enough for our needs. Thus, practically any length is ok.
nazariig
reviewed
Oct 22, 2021
|
|
||
| leaf-list actions { | ||
| type string; | ||
| default ""; |
There was a problem hiding this comment.
@stepanblyschak why do we need a default value?
Owner
Author
There was a problem hiding this comment.
Made it the same as port list of ACL table: https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-yang-models/yang-models/sonic-acl.yang#L270.
I guest it is for a scenario when you load empty list [] with sonic-cfggen which translates it into an empty string although I haven't checked that is true.
nazariig
reviewed
Oct 22, 2021
| key "ACL_TABLE_TYPE_NAME"; | ||
|
|
||
| leaf ACL_TABLE_TYPE_NAME { | ||
| type string; |
There was a problem hiding this comment.
@stepanblyschak do we need a length constraint?
nazariig
reviewed
Oct 22, 2021
| } | ||
|
|
||
| leaf-list actions { | ||
| type string; |
There was a problem hiding this comment.
@stepanblyschak do we need a length constraint?
nazariig
approved these changes
Oct 22, 2021
Signed-off-by: Stepan Blyshchak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyshchak <stepanb@nvidia.com>
stepanblyschak
force-pushed
the
acl-table-type
branch
3 times, most recently
from
8654480 to
700c5d2
Compare
stepanblyschak
pushed a commit
that referenced
this pull request
May 26, 2022
[sonic-linkmgrd][202012] submodule update 3523738 Jing Zhang Sun Apr 3 20:54:40 2022 -0700 Reset link prober state when default route is back #56 8282e78 Jing Zhang Fri Apr 15 15:59:34 2022 -0700 Keep incrementing sequence number when link prober is suspended and shutdown #55 (#65) 8246eb8 Jing Zhang Thu Apr 14 18:49:36 2022 -0700 Shutdown ICMP heartbeats when default route state is missing and ToR is in auto mode #44 (#59) sign-off: Jing Zhang zhangjing@microsoft.com
stepanblyschak
pushed a commit
that referenced
this pull request
Jun 22, 2022
…w components mgmt. (sonic-net#10377) * Support new platform SN2201 and RJ45 port Signed-off-by: Kebo Liu <kebol@nvidia.com> * remove unused import and redundant function Signed-off-by: Kebo Liu <kebol@nvidia.com> * fix error introduced by rebase Signed-off-by: Kebo Liu <kebol@nvidia.com> * Revert the special handling of RJ45 ports (#56) * Revert the special handling of RJ45 ports sfp.py sfp_event.py chassis.py Signed-off-by: Stephen Sun <stephens@nvidia.com> * Remove deadcode Signed-off-by: Stephen Sun <stephens@nvidia.com> * Support CPLD update for SN2201 A new class is introduced, deriving from ComponentCPLD and overloading _install_firmware Change _install_firmware from private (starting with __) to protected, making it overloadable Signed-off-by: Stephen Sun <stephens@nvidia.com> * Initialize component BIOS/CPLD Signed-off-by: Stephen Sun <stephens@nvidia.com> * Remove swb_amb which doesn't on DVT board any more Signed-off-by: Stephen Sun <stephens@nvidia.com> * Remove the unexisted sensor - switch board ambient - from platform.json Signed-off-by: Stephen Sun <stephens@nvidia.com> * Do not report error on receiving unknown status on RJ45 ports Translate it to disconnect for RJ45 ports Report error for xSFP ports Signed-off-by: Stephen Sun <stephens@nvidia.com> * Add reinit for RJ45 to avoid exception Signed-off-by: Stephen Sun <stephens@nvidia.com> Co-authored-by: Stephen Sun <5379172+stephenxs@users.noreply.github.com> Co-authored-by: Stephen Sun <stephens@nvidia.com>
stepanblyschak
pushed a commit
that referenced
this pull request
Aug 3, 2022
…w components mgmt. (sonic-net#10377) * Support new platform SN2201 and RJ45 port Signed-off-by: Kebo Liu <kebol@nvidia.com> * remove unused import and redundant function Signed-off-by: Kebo Liu <kebol@nvidia.com> * fix error introduced by rebase Signed-off-by: Kebo Liu <kebol@nvidia.com> * Revert the special handling of RJ45 ports (#56) * Revert the special handling of RJ45 ports sfp.py sfp_event.py chassis.py Signed-off-by: Stephen Sun <stephens@nvidia.com> * Remove deadcode Signed-off-by: Stephen Sun <stephens@nvidia.com> * Support CPLD update for SN2201 A new class is introduced, deriving from ComponentCPLD and overloading _install_firmware Change _install_firmware from private (starting with __) to protected, making it overloadable Signed-off-by: Stephen Sun <stephens@nvidia.com> * Initialize component BIOS/CPLD Signed-off-by: Stephen Sun <stephens@nvidia.com> * Remove swb_amb which doesn't on DVT board any more Signed-off-by: Stephen Sun <stephens@nvidia.com> * Remove the unexisted sensor - switch board ambient - from platform.json Signed-off-by: Stephen Sun <stephens@nvidia.com> * Do not report error on receiving unknown status on RJ45 ports Translate it to disconnect for RJ45 ports Report error for xSFP ports Signed-off-by: Stephen Sun <stephens@nvidia.com> * Add reinit for RJ45 to avoid exception Signed-off-by: Stephen Sun <stephens@nvidia.com> Co-authored-by: Stephen Sun <5379172+stephenxs@users.noreply.github.com> Co-authored-by: Stephen Sun <stephens@nvidia.com>
stepanblyschak
pushed a commit
that referenced
this pull request
Mar 26, 2025
…ly (sonic-net#22109) #### Why I did it src/sonic-stp ``` * 92342f9 - (HEAD -> master, origin/master, origin/HEAD) MSTP Feature - librabry API changes (#56) (33 hours ago) [Divya Kumaran Chandralekha] * 44b2b0c - MSTP PRS/PIM state machine APIs (#52) (2 days ago) [Divya Kumaran Chandralekha] * 16e8163 - MSTP PRT/PPM/TCM state machine APIs (#54) (2 days ago) [Divya Kumaran Chandralekha] * 5bf98bb - Mstp feature - debug APIs (#57) (2 days ago) [Divya Kumaran Chandralekha] ``` #### How I did it #### How to verify it #### Description for the changelog
stepanblyschak
pushed a commit
that referenced
this pull request
May 20, 2025
… automatically (sonic-net#826) #### Why I did it src/sonic-platform-common ``` * b37907d - (HEAD -> 202412, origin/202412) [code sync] Merge code from sonic-net/sonic-platform-common:202411 to 202412 (#56) (23 hours ago) [mssonicbld] ``` #### How I did it #### How to verify it #### Description for the changelog
stepanblyschak
pushed a commit
that referenced
this pull request
May 20, 2025
…lly (sonic-net#841) #### Why I did it src/sonic-swss ``` * d344d14 - (HEAD -> 202412, origin/202412) [code sync] Merge code from sonic-net/sonic-swss:202411 to 202412 (#56) (21 hours ago) [mssonicbld] ``` #### How I did it #### How to verify it #### Description for the changelog
stepanblyschak
pushed a commit
that referenced
this pull request
May 20, 2025
…D automatically (sonic-net#1105) #### Why I did it src/sonic-sairedis ``` * 3c33c26 - (HEAD -> 202412, origin/HEAD, origin/202412) Update codeql runs-on ubuntu version to 22.04 (#56) (3 hours ago) [mssonicbld] * 87d6f46 - [trim]: Add Packet Trimming to VS lib (#55) (18 hours ago) [mssonicbld] ``` #### How I did it #### How to verify it #### Description for the changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stepan Blyshchak stepanb@nvidia.com
Why I did it
To allow users (developers and end users) creating custom ACL tables without modifying AclOrch source code.
How I did it
Modifying ACL yang.
How to verify it
UT, manual test.
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)