Skip to content

[nvidia] fix hw-mgmt patches#59

Closed
stepanblyschak wants to merge 2 commits intomasterfrom
hw-mgmt-patch-fix
Closed

[nvidia] fix hw-mgmt patches#59
stepanblyschak wants to merge 2 commits intomasterfrom
hw-mgmt-patch-fix

Conversation

@stepanblyschak
Copy link
Copy Markdown
Owner

@stepanblyschak stepanblyschak commented Dec 14, 2021

Signed-off-by: Stepan Blyschak stepanb@nvidia.com

Why I did it

To fix an issue that hw-mgmt patches were not applied. One patch was already in upstream hw-mgmt package thus applying it again caused an error and no other patches were applied. Also, I did it to improve the Makefile, so that the make will fail in case patches fail to apply.

How I did it

Removed obsolete patch, made applying patches a hard failure in the build.

How to verify it

Run the make and verify patches are applied.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
@liat-grozovik
Copy link
Copy Markdown

@stepanblyschak i am not sure how this works.
you are saying we have a patch in sonic which was removed in hw mgmt package which we integrated (different package in different sonic branch) and even though it is not needed it was applied?

@stepanblyschak
Copy link
Copy Markdown
Owner Author

None of our SONiC patches for hw-mgmt were applied due to one conflicting patch. This one conflicting patch is redundant as the same change was done in hw-mgmt package which we already took to SONiC. That's why it conflicted.

stepanblyschak pushed a commit that referenced this pull request May 26, 2022
[sonic-linkmgrd][202012] submodule update

3523738 Jing Zhang      Sun Apr 3 20:54:40 2022 -0700   Reset link prober state when default route is back #56
8282e78 Jing Zhang      Fri Apr 15 15:59:34 2022 -0700  Keep incrementing sequence number when link prober is suspended and shutdown #55 (#65)
8246eb8 Jing Zhang      Thu Apr 14 18:49:36 2022 -0700  Shutdown ICMP heartbeats when default route state is missing and ToR is in auto mode #44 (#59)

sign-off: Jing Zhang zhangjing@microsoft.com
stepanblyschak pushed a commit that referenced this pull request Jun 30, 2023
…ically (sonic-net#15547)

#### Why I did it
src/sonic-dbsyncd
```
* e4ac906 - (HEAD -> master, origin/master, origin/HEAD) [actions] Support Semgrep by Github Actions (#59) (7 hours ago) [Mai Bui]
```
#### How I did it
#### How to verify it
#### Description for the changelog
stepanblyschak pushed a commit that referenced this pull request May 20, 2025
…lly (sonic-net#874)

#### Why I did it
src/sonic-swss
```
* 5fdb9d6 - (HEAD -> 202412, origin/202412) [code sync] Merge code from sonic-net/sonic-swss:202411 to 202412 (#59) (21 hours ago) [mssonicbld]
```
#### How I did it
#### How to verify it
#### Description for the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants