[Mellanox] Enhance Platform API to support SN2201 - RJ45 ports and new components mgmt. by keboliu · Pull Request #10377 · sonic-net/sonic-buildimage

keboliu · 2022-03-29T04:24:13Z

Signed-off-by: Kebo Liu kebol@nvidia.com

Why I did it

SN2201 has a new type of interface - RJ45 ports which need to be supported in platform API.
The solution is to inherit a class from sfp_base to manage RJ45 ports, this class will only return the port type with "RJ45",
other fields will be left with 'N/A', so XCVRD still can have a "TRANCEIVER_INFO|Ethernetx" populated to DB with type="RJ45" against an RJ45 port, and this new class will reject the lpmode, reset, etc. APIs call.
Add support for a new type of SSD FW upgrade.
Add support for SN2201 BIOS version fetch

How I did it

Add util function to get the "RJ45" port list from hwsku.json
Add a new class RJ45Port which was inherited from sfp class to manage RJ45 ports, and enhance the sfp_event
update SSD FW upgrade scripts: mlnx-ssd-fw-update.sh
New implementation to support SN2201 BIOS ComponentBIOSSN2201
Add unit test for new code change

How to verify it

Run platform test on SN2201 platform

Which release branch to backport (provide reason below if selected)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

lgtm-com · 2022-03-29T04:44:21Z

This pull request introduces 3 alerts when merging 4fb3309343d8de5b0d49e487313f544d0b5cdfd5 into 8e64284 - view on LGTM.com

new alerts:

1 for Unused import
1 for Variable defined multiple times
1 for Wrong number of arguments in a class instantiation

lgtm-com · 2022-04-01T10:24:58Z

This pull request introduces 1 alert when merging a7a0523387c9d500c2d40450c405a8bfc3301f0f into 0f488a8 - view on LGTM.com

new alerts:

1 for Wrong number of arguments in a class instantiation

keboliu · 2022-04-01T12:07:32Z

This pull request introduces 1 alert when merging a7a0523 into 0f488a8 - view on LGTM.com

new alerts:

1 for Wrong number of arguments in a class instantiation

This is a false alarm, LTGM is referring to a sfp_event definition in another vendors' implementation. This is a bug of LGTM.

lgtm-com · 2022-04-02T08:07:43Z

This pull request introduces 1 alert when merging f67156856bb072bb7114673676359b22f9aa3d97 into 8edc534 - view on LGTM.com

new alerts:

1 for Wrong number of arguments in a class instantiation

keboliu · 2022-04-04T09:16:04Z

/azpw run Azure.sonic-buildimage

mssonicbld · 2022-04-04T09:16:05Z

/AzurePipelines run Azure.sonic-buildimage

azure-pipelines · 2022-04-04T09:16:18Z

Azure Pipelines successfully started running 1 pipeline(s).

keboliu · 2022-04-05T02:15:13Z

/azpw run

mssonicbld · 2022-04-05T02:15:15Z

/AzurePipelines run

azure-pipelines · 2022-04-05T02:15:20Z

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

keboliu · 2022-04-05T02:15:37Z

/azpw run Azure.sonic-buildimage

mssonicbld · 2022-04-05T02:15:38Z

/AzurePipelines run Azure.sonic-buildimage

azure-pipelines · 2022-04-05T02:15:50Z

Azure Pipelines successfully started running 1 pipeline(s).

lgtm-com · 2022-04-18T03:23:03Z

This pull request introduces 1 alert when merging fcfa115 into a149457 - view on LGTM.com

new alerts:

1 for Wrong number of arguments in a class instantiation

keboliu · 2022-04-18T11:51:34Z

This pull request introduces 1 alert when merging fcfa115 into a149457 - view on LGTM.com

new alerts:

1 for Wrong number of arguments in a class instantiation

This is a false alarm, LTGM is referring to a sfp_event definition in another vendors' implementation. This is a bug of LGTM.

stephenxs · 2022-05-27T07:52:56Z

/azpw run Azure.sonic-buildimage

keboliu · 2022-05-27T10:10:47Z

/azpw run Azure.sonic-buildimage

mssonicbld · 2022-05-27T10:10:49Z

/AzurePipelines run Azure.sonic-buildimage

azure-pipelines · 2022-05-27T10:11:01Z

Azure Pipelines successfully started running 1 pipeline(s).

stephenxs · 2022-05-28T02:34:11Z

Timer expired on kvmtest-t1-lag

keboliu · 2022-05-28T02:35:55Z

/azpw run Azure.sonic-buildimage

mssonicbld · 2022-05-28T02:35:57Z

/AzurePipelines run Azure.sonic-buildimage

azure-pipelines · 2022-05-28T02:36:08Z

Azure Pipelines successfully started running 1 pipeline(s).

keboliu · 2022-06-01T13:28:11Z

/azpw run Azure.sonic-buildimage

azure-pipelines · 2022-06-01T13:28:30Z

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Kebo Liu <kebol@nvidia.com>

* Revert the special handling of RJ45 ports sfp.py sfp_event.py chassis.py Signed-off-by: Stephen Sun <stephens@nvidia.com> * Remove deadcode Signed-off-by: Stephen Sun <stephens@nvidia.com>

A new class is introduced, deriving from ComponentCPLD and overloading _install_firmware Change _install_firmware from private (starting with __) to protected, making it overloadable Signed-off-by: Stephen Sun <stephens@nvidia.com>

Signed-off-by: Stephen Sun <stephens@nvidia.com>

lgtm-com · 2022-06-08T01:37:46Z

This pull request introduces 1 alert when merging 720de68 into 6b70b44 - view on LGTM.com

new alerts:

1 for Unused import

liushilongbuaa · 2022-06-08T10:19:05Z

/azp run Azure.sonic-buildimage

azure-pipelines · 2022-06-08T10:19:18Z

Azure Pipelines successfully started running 1 pipeline(s).

Translate it to disconnect for RJ45 ports Report error for xSFP ports Signed-off-by: Stephen Sun <stephens@nvidia.com>

lgtm-com · 2022-06-14T10:09:13Z

This pull request introduces 2 alerts when merging b14c965 into 6a4105a - view on LGTM.com

new alerts:

1 for Unused import
1 for Wrong number of arguments in a class instantiation

Signed-off-by: Stephen Sun <stephens@nvidia.com>

lgtm-com · 2022-06-15T02:39:58Z

This pull request introduces 2 alerts when merging 4156651 into 8d299ca - view on LGTM.com

new alerts:

1 for Unused import
1 for Wrong number of arguments in a class instantiation

keboliu · 2022-06-15T06:34:45Z

This pull request introduces 2 alerts when merging 4156651 into 8d299ca - view on LGTM.com

new alerts:

1 for Unused import

1 for Wrong number of arguments in a class instantiation

Both of them are false alarms:

for the first one, the import of SFP and deinitialize_sdk_handle are both used in the following function, somehow LGTM is not able to correctly parse it.
for the second one, LTGM is referring to a sfp_event definition in another vendor's implementation. This is a bug of LGTM.

…w components mgmt. (#10377) * Support new platform SN2201 and RJ45 port Signed-off-by: Kebo Liu <kebol@nvidia.com> * remove unused import and redundant function Signed-off-by: Kebo Liu <kebol@nvidia.com> * fix error introduced by rebase Signed-off-by: Kebo Liu <kebol@nvidia.com> * Revert the special handling of RJ45 ports (#56) * Revert the special handling of RJ45 ports sfp.py sfp_event.py chassis.py Signed-off-by: Stephen Sun <stephens@nvidia.com> * Remove deadcode Signed-off-by: Stephen Sun <stephens@nvidia.com> * Support CPLD update for SN2201 A new class is introduced, deriving from ComponentCPLD and overloading _install_firmware Change _install_firmware from private (starting with __) to protected, making it overloadable Signed-off-by: Stephen Sun <stephens@nvidia.com> * Initialize component BIOS/CPLD Signed-off-by: Stephen Sun <stephens@nvidia.com> * Remove swb_amb which doesn't on DVT board any more Signed-off-by: Stephen Sun <stephens@nvidia.com> * Remove the unexisted sensor - switch board ambient - from platform.json Signed-off-by: Stephen Sun <stephens@nvidia.com> * Do not report error on receiving unknown status on RJ45 ports Translate it to disconnect for RJ45 ports Report error for xSFP ports Signed-off-by: Stephen Sun <stephens@nvidia.com> * Add reinit for RJ45 to avoid exception Signed-off-by: Stephen Sun <stephens@nvidia.com> Co-authored-by: Stephen Sun <5379172+stephenxs@users.noreply.github.com> Co-authored-by: Stephen Sun <stephens@nvidia.com>

…w components mgmt. (sonic-net#10377) * Support new platform SN2201 and RJ45 port Signed-off-by: Kebo Liu <kebol@nvidia.com> * remove unused import and redundant function Signed-off-by: Kebo Liu <kebol@nvidia.com> * fix error introduced by rebase Signed-off-by: Kebo Liu <kebol@nvidia.com> * Revert the special handling of RJ45 ports (sonic-net#56) * Revert the special handling of RJ45 ports sfp.py sfp_event.py chassis.py Signed-off-by: Stephen Sun <stephens@nvidia.com> * Remove deadcode Signed-off-by: Stephen Sun <stephens@nvidia.com> * Support CPLD update for SN2201 A new class is introduced, deriving from ComponentCPLD and overloading _install_firmware Change _install_firmware from private (starting with __) to protected, making it overloadable Signed-off-by: Stephen Sun <stephens@nvidia.com> * Initialize component BIOS/CPLD Signed-off-by: Stephen Sun <stephens@nvidia.com> * Remove swb_amb which doesn't on DVT board any more Signed-off-by: Stephen Sun <stephens@nvidia.com> * Remove the unexisted sensor - switch board ambient - from platform.json Signed-off-by: Stephen Sun <stephens@nvidia.com> * Do not report error on receiving unknown status on RJ45 ports Translate it to disconnect for RJ45 ports Report error for xSFP ports Signed-off-by: Stephen Sun <stephens@nvidia.com> * Add reinit for RJ45 to avoid exception Signed-off-by: Stephen Sun <stephens@nvidia.com> Co-authored-by: Stephen Sun <5379172+stephenxs@users.noreply.github.com> Co-authored-by: Stephen Sun <stephens@nvidia.com>

keboliu requested review from lguohan, prgeor, sujinmkang and vdahiya12 as code owners March 29, 2022 04:24

keboliu requested a review from stephenxs March 29, 2022 04:24

keboliu force-pushed the platform_api_support_RJ45 branch from f671568 to fcfa115 Compare April 18, 2022 02:49

keboliu requested a review from a team as a code owner June 2, 2022 02:29

keboliu and others added 7 commits June 6, 2022 09:54

Support new platform SN2201 and RJ45 port

c1aa76e

Signed-off-by: Kebo Liu <kebol@nvidia.com>

remove unused import and redundant function

cd6acc6

Signed-off-by: Kebo Liu <kebol@nvidia.com>

fix error introduced by rebase

356a120

Signed-off-by: Kebo Liu <kebol@nvidia.com>

Revert the special handling of RJ45 ports (#56)

5c82369

* Revert the special handling of RJ45 ports sfp.py sfp_event.py chassis.py Signed-off-by: Stephen Sun <stephens@nvidia.com> * Remove deadcode Signed-off-by: Stephen Sun <stephens@nvidia.com>

Support CPLD update for SN2201

f454691

A new class is introduced, deriving from ComponentCPLD and overloading _install_firmware Change _install_firmware from private (starting with __) to protected, making it overloadable Signed-off-by: Stephen Sun <stephens@nvidia.com>

Initialize component BIOS/CPLD

6db2401

Signed-off-by: Stephen Sun <stephens@nvidia.com>

Remove swb_amb which doesn't on DVT board any more

ae18fd1

Signed-off-by: Stephen Sun <stephens@nvidia.com>

keboliu force-pushed the platform_api_support_RJ45 branch from 210aeee to ae18fd1 Compare June 6, 2022 01:54

stephenxs and others added 2 commits June 7, 2022 10:59

Remove the unexisted sensor - switch board ambient - from platform.json

81be30e

Signed-off-by: Stephen Sun <stephens@nvidia.com>

Merge branch 'master' into platform_api_support_RJ45

720de68

Do not report error on receiving unknown status on RJ45 ports

b14c965

Translate it to disconnect for RJ45 ports Report error for xSFP ports Signed-off-by: Stephen Sun <stephens@nvidia.com>

Add reinit for RJ45 to avoid exception

4156651

Signed-off-by: Stephen Sun <stephens@nvidia.com>

prgeor approved these changes Jun 21, 2022

View reviewed changes

prgeor merged commit 7ac590b into sonic-net:master Jun 21, 2022

keboliu mentioned this pull request Jul 12, 2022

[PR tracking] PR List to support RJ45 port sonic-net/SONiC#1030

Closed

keboliu added the Request for 202205 Branch label Jul 25, 2022

yxieca added the Included in 202205 Branch label Jul 28, 2022

keboliu deleted the platform_api_support_RJ45 branch June 14, 2023 10:04

Conversation

keboliu commented Mar 29, 2022

Why I did it

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

Uh oh!

lgtm-com bot commented Mar 29, 2022

Uh oh!

lgtm-com bot commented Apr 1, 2022

Uh oh!

keboliu commented Apr 1, 2022

Uh oh!

lgtm-com bot commented Apr 2, 2022

Uh oh!

keboliu commented Apr 4, 2022

Uh oh!

mssonicbld commented Apr 4, 2022

Uh oh!

azure-pipelines bot commented Apr 4, 2022

Uh oh!

keboliu commented Apr 5, 2022

Uh oh!

mssonicbld commented Apr 5, 2022

Uh oh!

azure-pipelines bot commented Apr 5, 2022

Uh oh!

keboliu commented Apr 5, 2022

Uh oh!

mssonicbld commented Apr 5, 2022

Uh oh!

azure-pipelines bot commented Apr 5, 2022

Uh oh!

lgtm-com bot commented Apr 18, 2022

Uh oh!

keboliu commented Apr 18, 2022

Uh oh!

stephenxs commented May 27, 2022

Uh oh!

keboliu commented May 27, 2022

Uh oh!

mssonicbld commented May 27, 2022

Uh oh!

azure-pipelines bot commented May 27, 2022

Uh oh!

stephenxs commented May 28, 2022

Uh oh!

keboliu commented May 28, 2022

Uh oh!

mssonicbld commented May 28, 2022

Uh oh!

azure-pipelines bot commented May 28, 2022

Uh oh!

keboliu commented Jun 1, 2022

Uh oh!

azure-pipelines bot commented Jun 1, 2022

Uh oh!

lgtm-com bot commented Jun 8, 2022

Uh oh!

liushilongbuaa commented Jun 8, 2022

Uh oh!

azure-pipelines bot commented Jun 8, 2022

Uh oh!

lgtm-com bot commented Jun 14, 2022

Uh oh!

lgtm-com bot commented Jun 15, 2022

Uh oh!

keboliu commented Jun 15, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants