Skip to content

Add pfc_stat_history support - #4102

Merged
xincunli-sonic merged 3 commits into
sonic-net:masterfrom
xincunli-sonic:xincun/fix-pfc-stats
Oct 25, 2025
Merged

Add pfc_stat_history support#4102
xincunli-sonic merged 3 commits into
sonic-net:masterfrom
xincunli-sonic:xincun/fix-pfc-stats

Conversation

@xincunli-sonic

Copy link
Copy Markdown
Contributor

What I did

Add modification of pfc_stat_history support for PFC_WD table.

In this change (sonic-net/sonic-buildimage#21848), the pfc_stat_history field was introduced. However, the update did not include a corresponding modification to gcu_field_operation_validators.conf.json, which defines the allowed fields and operations for the PFC_WD table.

How I did it

Add pfc_stat_history to gcu_field_operation_validators.conf.json.

How to verify it

Starlab test.

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

@mssonicbld

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

r12f
r12f previously approved these changes Oct 24, 2025

@mramezani95 mramezani95 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

patch_element = {
"path": "/PFC_WD/Ethernet8/pfc_stat_history",
"op": "replace",
"value": "100"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pfc_stat_history options are enable/disable, could you check?

@mssonicbld

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@xincunli-sonic
xincunli-sonic merged commit 8d2bc08 into sonic-net:master Oct 25, 2025
7 checks passed
@r12f

r12f commented Oct 26, 2025

Copy link
Copy Markdown

since this change (sonic-net/sonic-buildimage#21848) is not in 202412, removing 202412 tag for this PR.

gordon-nexthop pushed a commit to nexthop-ai/sonic-utilities that referenced this pull request Nov 25, 2025
* Add pfc_stat_history support

* fix pfc_stat_history value
YairRaviv pushed a commit to YairRaviv/sonic-utilities that referenced this pull request Jan 12, 2026
* Add pfc_stat_history support

* fix pfc_stat_history value
Yogapriya-cisco pushed a commit to vrajeshe/sonic-utilities that referenced this pull request Jul 10, 2026
* Add pfc_stat_history support

* fix pfc_stat_history value

Signed-off-by: Yogapriya Mohankumar <ymohanku@cisco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants