Skip to content

Add pfc_stat_history support #4102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xincunli-sonic merged 3 commits into from
Oct 25, 2025
Merged

Add pfc_stat_history support #4102

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cf583b7
Add pfc_stat_history support
xincunli-sonic Oct 24, 2025
ca0896a
fix pfc_stat_history value
xincunli-sonic Oct 24, 2025
0d0eb16
Merge branch 'master' into xincun/fix-pfc-stats
xincunli-sonic Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions generic_config_updater/gcu_field_operation_validators.conf.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@
"detection_time",
"action",
"global/poll_interval",
"pfc_stat_history",
""
],
"operations": ["remove", "add", "replace"],
Expand Down
19 changes: 19 additions & 0 deletions tests/generic_config_updater/field_operation_validator_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,6 +323,25 @@ def test_rdma_config_update_validator_spc_asic_other_field(self):
assert generic_config_updater.field_operation_validators.\
rdma_config_update_validator(scope, patch_element) is False

@patch("sonic_py_common.device_info.get_sonic_version_info",
mock.Mock(return_value={"build_version": "SONiC.20220530"}))
@patch("generic_config_updater.field_operation_validators.get_asic_name",
mock.Mock(return_value="spc1"))
@patch("os.path.exists", mock.Mock(return_value=True))
@patch("builtins.open", mock_open(read_data='''{"tables": {"PFC_WD": {"validator_data": {
"rdma_config_update_validator": {"PFCWD enable/disable": {"fields": [
"restoration_time", "detection_time", "action", "global/poll_interval", "pfc_stat_history"
], "operations": ["remove", "replace", "add"], "platforms": {"spc1": "20181100"}}}}}}}'''))
def test_rdma_config_update_validator_spc_asic_pfc_stat_history(self):
patch_element = {
"path": "/PFC_WD/Ethernet8/pfc_stat_history",
"op": "replace",
"value": "100"

@kperumalbfn kperumalbfn Oct 24, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pfc_stat_history options are enable/disable, could you check?

}
for scope in ["localhost", "asic0"]:
assert generic_config_updater.field_operation_validators.\
rdma_config_update_validator(scope, patch_element) is True

@patch("sonic_py_common.device_info.get_sonic_version_info",
mock.Mock(return_value={"build_version": "20250530.12"}))
@patch("generic_config_updater.field_operation_validators.get_asic_name",
Expand Down
Loading