Yang model additions for PFC Stat History#21848
Conversation
peterbailey-arista
force-pushed
the
master
branch
from
7c18dd4 to
2d722e4
Compare
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Why doesn't it catch error for missing leafref in ifname: Ethernet4?
There was a problem hiding this comment.
While I was simply following the example of the other tests, I believe it is because Test_yang_models::runExceptionTest only verifies that each eStr defined in the test case is found in the exceptions from parsing the input.
So from my understanding of the code, it's likely that there would be a missing leafref and possibly any number of other exceptions but the test case passes so long as all exceptions defined in eStr were found at least once.
In my case I am only verifying that "pfc_stat_history must be either enable or disable" is shown and not any other exceptions.
|
/azp run Azure.sonic-buildimage |
|
Commenter does not have sufficient privileges for PR 21848 in repo sonic-net/sonic-buildimage |
|
/azpw run Azure.sonic-buildimage |
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@ganglyu or @wen587 are you able to review this PR or suggest reviewers I can ping for this and for the other related PRs for this feature? They are listed at sonic-net/SONiC#1904 (comment) Let me know, thanks! |
|
@peterbailey-arista As per my understanding, this is verifying port level configuration. How about global config validation ? |
@vmittal-msft The feature configuration is all at the port level, you enable history on ports individually in the same way the PFCWD is started on ports individually. Hopefully I've understood your question but there is no global configuration to do - global configurations are handled through the PFCWD. For example, polling time is simply the PFCWD's polling time |
peterbailey-arista
force-pushed
the
master
branch
from
2d722e4 to
8121def
Compare
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
peterbailey-arista
force-pushed
the
master
branch
from
8121def to
2b723f9
Compare
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@vmittal-msft Are we able to follow up on merging this? Thanks! |
|
Hi @vmittal-msft , I can see the feature sonic-net/SONiC#1904 is moved to 202511 release. |
Why I did it PFC Historical Statistics feature sonic-net/SONiC#1904 Work item tracking sonic-net#21847 How to verify it Run the test cases in tests/ and ensure they pass. Deploy the changes to a SONiC device and verify the configuration and monitoring functionality using CLI commands.
8 participants
New pfc_stat_history leaf attribute for toggling history estimation per-interface in CONFIG_DB
Why I did it
PFC Historical Statistics feature sonic-net/SONiC#1904
Work item tracking
#21847
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Addition of PFC_STAT_HISTORY table and Flex Counter group.
Link to config_db schema for YANG module changes