Add namespace support for show interface neighbor expected#3781
Merged
yejianquan merged 2 commits intosonic-net:masterfrom Mar 3, 2025
Conversation
Collaborator
|
/azp run |
auspham
changed the title
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Austin Pham <[email protected]>
auspham
force-pushed
the
austinpham/28837145-update-show-interface-neighbors-multiasic
branch
from
afa3c02 to
bff9242
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
11 tasks
Contributor
|
Will |
Contributor
Author
yes ip netns exec asicx will work as well. We will need to adjust the tests a bit and cannot use inherited |
sdszhang
reviewed
Feb 28, 2025
FengPan-Frank
previously approved these changes
Feb 28, 2025
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
sdszhang
previously approved these changes
Feb 28, 2025
…instead Signed-off-by: Austin Pham <[email protected]>
auspham
force-pushed
the
austinpham/28837145-update-show-interface-neighbors-multiasic
branch
from
9accb0c to
814f764
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
sdszhang
approved these changes
Mar 3, 2025
Contributor
Author
|
hi @FengPan-Frank could you have a review again. please. Thanks |
FengPan-Frank
approved these changes
Mar 3, 2025
Collaborator
|
Cherry-pick PR to 202411: #3790 |
mssonicbld
added
Included in 202411 Branch
and removed
Created PR to 202411 Branch
labels
yejianquan
pushed a commit
to sonic-net/sonic-mgmt
that referenced
this pull request
Mar 6, 2025
Description of PR Summary: Add support for multi-asic compatible for this tests. This PR requires sonic-net/sonic-utilities#3781 to be merged as it's support -n <namespace> Fixes # (issue) 28837145 Approach What is the motivation for this PR? Described above How did you do it? Utility improvement: sonic-net/sonic-utilities#3781 Use namespace to get the information so that it's compatible with multi-asic. Enabled internal port when querying for port_alias_fact which was disabled before for compatibility How did you verify/test it? T2 testbed verified Signed-off-by: Austin Pham <[email protected]>
nnelluri-cisco
pushed a commit
to nnelluri-cisco/sonic-mgmt
that referenced
this pull request
Mar 15, 2025
Description of PR Summary: Add support for multi-asic compatible for this tests. This PR requires sonic-net/sonic-utilities#3781 to be merged as it's support -n <namespace> Fixes # (issue) 28837145 Approach What is the motivation for this PR? Described above How did you do it? Utility improvement: sonic-net/sonic-utilities#3781 Use namespace to get the information so that it's compatible with multi-asic. Enabled internal port when querying for port_alias_fact which was disabled before for compatibility How did you verify/test it? T2 testbed verified Signed-off-by: Austin Pham <[email protected]>
OriTrabelsi
pushed a commit
to OriTrabelsi/sonic-mgmt
that referenced
this pull request
Apr 1, 2025
Description of PR Summary: Add support for multi-asic compatible for this tests. This PR requires sonic-net/sonic-utilities#3781 to be merged as it's support -n <namespace> Fixes # (issue) 28837145 Approach What is the motivation for this PR? Described above How did you do it? Utility improvement: sonic-net/sonic-utilities#3781 Use namespace to get the information so that it's compatible with multi-asic. Enabled internal port when querying for port_alias_fact which was disabled before for compatibility How did you verify/test it? T2 testbed verified Signed-off-by: Austin Pham <[email protected]>
nmoray
pushed a commit
to nmoray/sonic-utilities
that referenced
this pull request
Jun 25, 2025
…#3781) What I did Adding namespace support for show interface neighbor expected. So that we can use show interface neighbor expected -n asic0 How I did it How to verify it Verified on T2 testbed Previous command output (if the output of a command-line utility has changed) admin@somehost:/var/log$ show interfaces neighbor expected -n asic1 Usage: show interfaces neighbor expected [OPTIONS] [INTERFACENAME] Try "show interfaces neighbor expected -h" for help. Error: no such option: -n New command output (if the output of a command-line utility has changed) admin@somehost:/var/log$ show interfaces neighbor expected -n asic1 LocalPort Neighbor NeighborPort NeighborLoopback NeighborMgmt NeighborType ----------- ---------- -------------- ------------------ -------------- -------------- Ethernet96 ARISTAXXTX Ethernet1 None XXX.XX.XXX.XX someHub Ethernet104 ARISTAXXTX Ethernet1 None XXX.XX.XXX.XX otherHub ... Signed-off-by: Austin Pham <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Adding namespace support for
show interface neighbor expected. So that we can useHow I did it
How to verify it
Verified on T2 testbed
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)