Skip to content

Add namespace support for show interface neighbor expected #3781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yejianquan merged 2 commits into from
Mar 3, 2025
Merged

Add namespace support for show interface neighbor expected #3781

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bff9242
feat: add namespace support for show interface neighbor expected
auspham Feb 25, 2025
814f764
chore: address PR comment by using multi_asic_click_option_namespace …
auspham Feb 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/Command-Reference.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5435,7 +5435,7 @@ This command is used to display the list of expected neighbors for all interface

- Usage:
```
show interfaces neighbor expected [<interface_name>]
show interfaces neighbor expected [<interface_name>] -n [<namespace>]
```

- Example:
Expand Down
10 changes: 7 additions & 3 deletions show/interfaces/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,16 +281,20 @@ def neighbor():
# 'expected' subcommand ("show interface neighbor expected")
@neighbor.command()
@click.argument('interfacename', required=False)
@multi_asic_util.multi_asic_click_option_namespace
@clicommon.pass_db
def expected(db, interfacename):
def expected(db, interfacename, namespace):
"""Show expected neighbor information by interfaces"""

neighbor_dict = db.cfgdb.get_table("DEVICE_NEIGHBOR")
if not namespace:
namespace = multi_asic_util.constants.DEFAULT_NAMESPACE

neighbor_dict = db.cfgdb_clients[namespace].get_table("DEVICE_NEIGHBOR")
if neighbor_dict is None:
click.echo("DEVICE_NEIGHBOR information is not present.")
return

neighbor_metadata_dict = db.cfgdb.get_table("DEVICE_NEIGHBOR_METADATA")
neighbor_metadata_dict = db.cfgdb_clients[namespace].get_table("DEVICE_NEIGHBOR_METADATA")
if neighbor_metadata_dict is None:
click.echo("DEVICE_NEIGHBOR_METADATA information is not present.")
return
Expand Down
Loading