Skip to content

add multidut support for enable_iface_naming_mode#17045

Merged
yejianquan merged 1 commit intosonic-net:masterfrom
auspham:austinpham/28837145-enable-iface_naming_mode_gap
Mar 6, 2025
Merged

add multidut support for enable_iface_naming_mode#17045
yejianquan merged 1 commit intosonic-net:masterfrom
auspham:austinpham/28837145-enable-iface_naming_mode_gap

Conversation

@auspham
Copy link
Contributor

@auspham auspham commented Feb 20, 2025

Description of PR

Summary:

Add support for multi-asic compatible for this tests. This PR requires sonic-net/sonic-utilities#3781 to be merged as it's support -n <namespace>

Fixes # (issue) 28837145

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405
  • 202411

Approach

What is the motivation for this PR?

Described above

How did you do it?

Utility improvement: sonic-net/sonic-utilities#3781

Use namespace to get the information so that it's compatible with multi-asic.

Enabled internal port when querying for port_alias_fact which was disabled before for compatibility

How did you verify/test it?

T2 testbed verified

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@auspham auspham force-pushed the austinpham/28837145-enable-iface_naming_mode_gap branch from 815d244 to 9279306 Compare February 20, 2025 04:07
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@auspham auspham force-pushed the austinpham/28837145-enable-iface_naming_mode_gap branch from 9279306 to 9b008b7 Compare February 20, 2025 07:34
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@auspham auspham force-pushed the austinpham/28837145-enable-iface_naming_mode_gap branch from 9b008b7 to b28644d Compare February 20, 2025 10:45
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@auspham auspham force-pushed the austinpham/28837145-enable-iface_naming_mode_gap branch from b28644d to e27111c Compare February 21, 2025 00:36
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@auspham auspham force-pushed the austinpham/28837145-enable-iface_naming_mode_gap branch from e27111c to b638a87 Compare February 25, 2025 10:11
@mssonicbld
Copy link
Collaborator

/azp run

@auspham auspham force-pushed the austinpham/28837145-enable-iface_naming_mode_gap branch from b638a87 to 28b4ef1 Compare February 25, 2025 10:26
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@auspham auspham force-pushed the austinpham/28837145-enable-iface_naming_mode_gap branch from 28b4ef1 to 7c58ec8 Compare February 27, 2025 00:11
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@auspham auspham force-pushed the austinpham/28837145-enable-iface_naming_mode_gap branch from 7c58ec8 to f9c62de Compare February 27, 2025 05:19
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@auspham auspham force-pushed the austinpham/28837145-enable-iface_naming_mode_gap branch from f9c62de to 4bef1aa Compare February 27, 2025 11:44
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@auspham auspham force-pushed the austinpham/28837145-enable-iface_naming_mode_gap branch from 4bef1aa to d525327 Compare February 27, 2025 23:17
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@auspham auspham marked this pull request as ready for review February 27, 2025 23:38
@auspham auspham changed the title 28837145 enable iface naming mode gap add multidut support for enable_iface_naming_mode Feb 28, 2025
chore: update test for t2

Signed-off-by: Austin Pham <[email protected]>
@auspham auspham force-pushed the austinpham/28837145-enable-iface_naming_mode_gap branch from d525327 to 6a90160 Compare March 3, 2025 23:13
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Collaborator

@yejianquan yejianquan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yejianquan yejianquan merged commit b1af809 into sonic-net:master Mar 6, 2025
18 checks passed
nnelluri-cisco pushed a commit to nnelluri-cisco/sonic-mgmt that referenced this pull request Mar 15, 2025
Description of PR
Summary:

Add support for multi-asic compatible for this tests. This PR requires sonic-net/sonic-utilities#3781 to be merged as it's support -n <namespace>

Fixes # (issue) 28837145

Approach
What is the motivation for this PR?
Described above

How did you do it?
Utility improvement: sonic-net/sonic-utilities#3781

Use namespace to get the information so that it's compatible with multi-asic.

Enabled internal port when querying for port_alias_fact which was disabled before for compatibility

How did you verify/test it?
T2 testbed verified

Signed-off-by: Austin Pham <[email protected]>
OriTrabelsi pushed a commit to OriTrabelsi/sonic-mgmt that referenced this pull request Apr 1, 2025
Description of PR
Summary:

Add support for multi-asic compatible for this tests. This PR requires sonic-net/sonic-utilities#3781 to be merged as it's support -n <namespace>

Fixes # (issue) 28837145

Approach
What is the motivation for this PR?
Described above

How did you do it?
Utility improvement: sonic-net/sonic-utilities#3781

Use namespace to get the information so that it's compatible with multi-asic.

Enabled internal port when querying for port_alias_fact which was disabled before for compatibility

How did you verify/test it?
T2 testbed verified

Signed-off-by: Austin Pham <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants