[config]Support multi-asic Golden Config override with fix#2825
Merged
qiluo-msft merged 3 commits intosonic-net:masterfrom May 11, 2023
Merged
[config]Support multi-asic Golden Config override with fix#2825qiluo-msft merged 3 commits intosonic-net:masterfrom
qiluo-msft merged 3 commits intosonic-net:masterfrom
Conversation
#### What I did Support multi-asic Golden Config Override #### How I did it Add ConfigMgmt support for ASIC validation. Modify override config cli to support multi-asic. #### How to verify it Unit test: tests/config_override_test.py::TestConfigOverrideMultiasic::test_macsec_override PASSED [ 8%] tests/config_override_test.py::TestConfigOverrideMultiasic::test_device_metadata_table_rm PASSED [ 8%]
wen587
changed the title
wen587
commented
May 4, 2023
wen587
commented
May 4, 2023
wen587
commented
May 4, 2023
qiluo-msft
reviewed
May 4, 2023
qiluo-msft
approved these changes
May 9, 2023
Contributor
|
Since it is request to 202205, could you test it on 202205 image, and add the version info into PR description. |
Contributor
|
need ADO |
gechiang
added
the
included in chassis for 202205 branch
wen587
added a commit
to wen587/sonic-utilities
that referenced
this pull request
Jun 5, 2023
…onic-net#2825) ADO: 17746282 Support multi-asic Golden Config Override with fix based on sonic-net#2738 Add ConfigMgmt support for ASIC validation. Modify override config cli to support multi-asic. Unit test: ``` tests/config_override_test.py::TestConfigOverrideMultiasic::test_macsec_override PASSED [ 8%] tests/config_override_test.py::TestConfigOverrideMultiasic::test_device_metadata_table_rm PASSED [ 8%] ```
yxieca
pushed a commit
that referenced
this pull request
Jun 6, 2023
…2825) (#2862) ADO: 17746282 Support multi-asic Golden Config Override with fix based on #2738 Add ConfigMgmt support for ASIC validation. Modify override config cli to support multi-asic. Unit test: ``` tests/config_override_test.py::TestConfigOverrideMultiasic::test_macsec_override PASSED [ 8%] tests/config_override_test.py::TestConfigOverrideMultiasic::test_device_metadata_table_rm PASSED [ 8%] ```
6 tasks
6 tasks
pdhruv-marvell
pushed a commit
to pdhruv-marvell/sonic-utilities
that referenced
this pull request
Aug 23, 2023
…#2825) ADO: 17746282 #### What I did Support multi-asic Golden Config Override with fix based on sonic-net#2738 #### How I did it Add ConfigMgmt support for ASIC validation. Modify override config cli to support multi-asic. #### How to verify it Unit test: ``` tests/config_override_test.py::TestConfigOverrideMultiasic::test_macsec_override PASSED [ 8%] tests/config_override_test.py::TestConfigOverrideMultiasic::test_device_metadata_table_rm PASSED [ 8%] ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ADO: 17746282
What I did
Support multi-asic Golden Config Override with fix based on #2738
How I did it
Add ConfigMgmt support for ASIC validation. Modify override config cli to support multi-asic.
How to verify it
Unit test:
tests/config_override_test.py::TestConfigOverrideMultiasic::test_macsec_override PASSED [ 8%]
tests/config_override_test.py::TestConfigOverrideMultiasic::test_device_metadata_table_rm PASSED [ 8%]
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)