[config]Support multi-asic Golden Config override by wen587 · Pull Request #2738 · sonic-net/sonic-utilities

wen587 · 2023-03-15T08:00:27Z

What I did

Support multi-asic Golden Config Override

How I did it

Add ConfigMgmt support for ASIC validation. Modify override config cli to support multi-asic.

How to verify it

Unit test:
tests/config_override_test.py::TestConfigOverrideMultiasic::test_macsec_override PASSED [ 8%]
tests/config_override_test.py::TestConfigOverrideMultiasic::test_device_metadata_table_rm PASSED [ 8%]

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

tests/config_override_test.py

judyjoseph · 2023-03-31T00:54:31Z

Otherwise looks ok.
We need to validate this and add some test results too in Comments above

qiluo-msft · 2023-04-11T22:27:31Z

config/main.py

+            generate_sysinfo(ns_config_input, ns)
+        else:
+            ns_config_input = config_input
+            generate_sysinfo(ns_config_input)


generate_sysinfo

Is it better to fill missing mac/platform during override_config_db() ?

If the original ConfigDB already has mac/platform, we should keep them even we override other fields. #Pending

Do you mean the generated sysinfo should have less priority than existing one?
Though I think they should be the same.

Will submit another PR for sysinfo generation about override.

qiluo-msft · 2023-04-11T22:45:41Z

config/main.py

+        else:
+            mac = device_info.get_system_mac()
+    else:
+        mac = device_info.get_system_mac()


I notice code duplication of https://github.com/sonic-net/sonic-buildimage/blob/d74055e12ca0ac4f44342e74ea097f03720663f7/src/sonic-config-engine/sonic-cfggen#L382-L388.
Possible to reuse code? #Pending

Could you remove code dup in next PR?

judyjoseph

Checked on a multi-asic device running 2205. Find the config ( eg: macsec_profile) getting added in host/asic namespaces

This reverts commit d9a2ef3.

#### What I did Support multi-asic Golden Config Override #### How I did it Add ConfigMgmt support for ASIC validation. Modify override config cli to support multi-asic. #### How to verify it Unit test: tests/config_override_test.py::TestConfigOverrideMultiasic::test_macsec_override PASSED [ 8%] tests/config_override_test.py::TestConfigOverrideMultiasic::test_device_metadata_table_rm PASSED [ 8%]

Update sonic-utilities submodule pointer to include the following: * 600377f7 [DPB]Fixing typo in config breakout output ([sonic-net#2802](sonic-net/sonic-utilities#2802)) * 8ae2424a [config]Support multi-asic Golden Config override ([sonic-net#2738](sonic-net/sonic-utilities#2738)) * 79003ab2 [chassis]: remote cli commands infra for sonic chassis ([sonic-net#2701](sonic-net/sonic-utilities#2701)) * cbc55eeb [voq][chassis][generate_dump] [BCM] Dump only the relevant BCM commands for fabric cards ([sonic-net#2606](sonic-net/sonic-utilities#2606)) * 39c94b7e [GCU] Prohibit removal of PFC_WD POLL_INTERVAL field ([sonic-net#2545](sonic-net/sonic-utilities#2545)) Signed-off-by: dprital <[email protected]>

Update sonic-utilities submodule pointer to include the following: * 88ffb16 [config]config reload should generate sysinfo if missing ([sonic-net#2778](sonic-net/sonic-utilities#2778)) * 7443b9e [sonic-package-manager] support extension with multiple YANG modules ([sonic-net#2752](sonic-net/sonic-utilities#2752)) * 522c3a9 [sonic-package-manager] add support for multiple CLI plugin files ([sonic-net#2753](sonic-net/sonic-utilities#2753)) * b38fcfd [show][muxcable] fix RC ([sonic-net#2812](sonic-net/sonic-utilities#2812)) * 7e24463 [chassis]: remote cli commands infra for sonic chassis ([sonic-net#2701](sonic-net/sonic-utilities#2701)) * bee593e [DPB]Fixing typo in config breakout output ([sonic-net#2802](sonic-net/sonic-utilities#2802)) * ada603c [config]Support multi-asic Golden Config override ([sonic-net#2738](sonic-net/sonic-utilities#2738)) * 88a7daa [show][barefoot] replace shell=True ([sonic-net#2699](sonic-net/sonic-utilities#2699)) * 5e99edb [sonic_package_manager] replace shell=True ([sonic-net#2726](sonic-net/sonic-utilities#2726)) * b547bb4 [acl-loader] Only add default deny rule when table is L3 or L3V6 ([sonic-net#2796](sonic-net/sonic-utilities#2796)) Signed-off-by: dprital <[email protected]>

wen587 · 2023-05-03T06:24:35Z

Remove Chassis tag because there is bug in this PR and block subodule. Will create an updated PR after the revert.

…2738)" This reverts commit 8ae2424.

…2820) This reverts commit 8ae2424.

…2738)" This reverts commit ada603c.

…2823) This reverts commit ada603c.

#### What I did Support multi-asic Golden Config Override #### How I did it Add ConfigMgmt support for ASIC validation. Modify override config cli to support multi-asic. #### How to verify it Unit test: tests/config_override_test.py::TestConfigOverrideMultiasic::test_macsec_override PASSED [ 8%] tests/config_override_test.py::TestConfigOverrideMultiasic::test_device_metadata_table_rm PASSED [ 8%]

ADO: 17746282 #### What I did Support multi-asic Golden Config Override with fix based on #2738 #### How I did it Add ConfigMgmt support for ASIC validation. Modify override config cli to support multi-asic. #### How to verify it Unit test: ``` tests/config_override_test.py::TestConfigOverrideMultiasic::test_macsec_override PASSED [ 8%] tests/config_override_test.py::TestConfigOverrideMultiasic::test_device_metadata_table_rm PASSED [ 8%] ```

…onic-net#2825) ADO: 17746282 Support multi-asic Golden Config Override with fix based on sonic-net#2738 Add ConfigMgmt support for ASIC validation. Modify override config cli to support multi-asic. Unit test: ``` tests/config_override_test.py::TestConfigOverrideMultiasic::test_macsec_override PASSED [ 8%] tests/config_override_test.py::TestConfigOverrideMultiasic::test_device_metadata_table_rm PASSED [ 8%] ```

…2825) (#2862) ADO: 17746282 Support multi-asic Golden Config Override with fix based on #2738 Add ConfigMgmt support for ASIC validation. Modify override config cli to support multi-asic. Unit test: ``` tests/config_override_test.py::TestConfigOverrideMultiasic::test_macsec_override PASSED [ 8%] tests/config_override_test.py::TestConfigOverrideMultiasic::test_device_metadata_table_rm PASSED [ 8%] ```

…#2825) ADO: 17746282 #### What I did Support multi-asic Golden Config Override with fix based on sonic-net#2738 #### How I did it Add ConfigMgmt support for ASIC validation. Modify override config cli to support multi-asic. #### How to verify it Unit test: ``` tests/config_override_test.py::TestConfigOverrideMultiasic::test_macsec_override PASSED [ 8%] tests/config_override_test.py::TestConfigOverrideMultiasic::test_device_metadata_table_rm PASSED [ 8%] ```

wen587 added 3 commits March 15, 2023 08:00

[config]Support multi-asic Golden Config override

0009fa0

add multi ov test

0bedc63

change to configdb instead of ns

334433b

wen587 requested review from judyjoseph and qiluo-msft March 22, 2023 07:28

wen587 marked this pull request as ready for review March 22, 2023 07:29

judyjoseph reviewed Mar 31, 2023

View reviewed changes

tests/config_override_test.py Outdated Show resolved Hide resolved

change to json file for input

81c9d7e

wen587 requested a review from judyjoseph April 10, 2023 05:18

wen587 mentioned this pull request Apr 11, 2023

[config]config reload should generate sysinfo if missing #2778

Merged

wen587 added 2 commits April 11, 2023 06:10

remove unused space and asic2

479181c

fix missing sysinfo in config override

d9a2ef3

qiluo-msft reviewed Apr 11, 2023

View reviewed changes

judyjoseph previously approved these changes Apr 13, 2023

View reviewed changes

Revert "fix missing sysinfo in config override"

2b21d11

This reverts commit d9a2ef3.

wen587 dismissed judyjoseph’s stale review via 2b21d11 April 15, 2023 10:02

wen587 added Request for 202205 Branch Request for 202211 Branch labels Apr 15, 2023

wen587 requested review from judyjoseph and qiluo-msft April 15, 2023 12:37

judyjoseph approved these changes Apr 18, 2023

View reviewed changes

qiluo-msft approved these changes Apr 20, 2023

View reviewed changes

qiluo-msft merged commit ada603c into sonic-net:master Apr 20, 2023

qiluo-msft mentioned this pull request Apr 20, 2023

[202205][config]Support multi-asic Golden Config override #2805

Draft

judyjoseph mentioned this pull request Apr 20, 2023

Update override_config_table for multi-asic platforms #2620

Closed

qiluo-msft added Chassis and removed Request for 202205 Branch labels Apr 25, 2023

StormLiangMS added the Included in 202211 Branch label Apr 26, 2023

judyjoseph added the Chassis for 202205 Branch label Apr 28, 2023

dprital mentioned this pull request May 1, 2023

[202211][submodule] Advance sonic-utilities pointer sonic-net/sonic-buildimage#14904

Closed

10 tasks

dprital mentioned this pull request May 1, 2023

[submodule] Advance sonic-utilities pointer sonic-net/sonic-buildimage#14906

Closed

10 tasks

wen587 removed Chassis Chassis for 202205 Branch labels May 3, 2023

dprital added a commit to dprital/sonic-utilities that referenced this pull request May 3, 2023

Revert "[config]Support multi-asic Golden Config override (sonic-net#…

638602e

…2738)" This reverts commit 8ae2424.

dprital mentioned this pull request May 3, 2023

Revert "[config]Support multi-asic Golden Config override (#2738)" #2820

Merged

liat-grozovik pushed a commit that referenced this pull request May 3, 2023

Revert "[config]Support multi-asic Golden Config override (#2738)" (#…

72c3b84

…2820) This reverts commit 8ae2424.

wen587 pushed a commit to wen587/sonic-utilities that referenced this pull request May 4, 2023

Revert "[config]Support multi-asic Golden Config override (sonic-net#…

3772820

…2738)" This reverts commit ada603c.

wen587 added a commit to wen587/sonic-utilities that referenced this pull request May 4, 2023

Revert "[config]Support multi-asic Golden Config override (sonic-net#…

c7e6136

…2738)" This reverts commit ada603c.

wen587 added a commit that referenced this pull request May 4, 2023

Revert "[config]Support multi-asic Golden Config override (#2738)" (#…

ce81a34

…2823) This reverts commit ada603c.

wen587 mentioned this pull request May 4, 2023

[config]Support multi-asic Golden Config override with fix #2825

Merged

wen587 mentioned this pull request Jun 5, 2023

[202205][config]Support multi-asic Golden Config override with fix (#2825) #2862

Merged

wen587 mentioned this pull request Apr 28, 2024

HLD for Golden config CLI support in multi-asic sonic-net/SONiC#1684

Merged

wen587 mentioned this pull request Jan 24, 2025

DB Design for multi-ASIC scenarios sonic-net/SONiC#1902

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[config]Support multi-asic Golden Config override#2738

[config]Support multi-asic Golden Config override#2738
qiluo-msft merged 7 commits intosonic-net:masterfrom
wen587:macsec_ov

wen587 commented Mar 15, 2023 •

edited

Loading

Uh oh!

Uh oh!

judyjoseph commented Mar 31, 2023

Uh oh!

qiluo-msft Apr 11, 2023 •

edited

Loading

Uh oh!

wen587 Apr 12, 2023

Uh oh!

wen587 Apr 15, 2023

Uh oh!

qiluo-msft Apr 11, 2023 •

edited

Loading

Uh oh!

qiluo-msft Apr 20, 2023

Uh oh!

judyjoseph left a comment

Uh oh!

wen587 commented May 3, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

wen587 commented Mar 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What I did

How I did it

How to verify it

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

Uh oh!

Uh oh!

judyjoseph commented Mar 31, 2023

Uh oh!

qiluo-msft Apr 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wen587 Apr 12, 2023

Choose a reason for hiding this comment

Uh oh!

wen587 Apr 15, 2023

Choose a reason for hiding this comment

Uh oh!

qiluo-msft Apr 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

qiluo-msft Apr 20, 2023

Choose a reason for hiding this comment

Uh oh!

judyjoseph left a comment

Choose a reason for hiding this comment

Uh oh!

wen587 commented May 3, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

wen587 commented Mar 15, 2023 •

edited

Loading

qiluo-msft Apr 11, 2023 •

edited

Loading

qiluo-msft Apr 11, 2023 •

edited

Loading