[action] [PR:9017] [chassis] [multi-asic] skip override_config_table test for multi-asic platforms#9070
Merged
mssonicbld merged 1 commit intosonic-net:202205from Jul 21, 2023
Conversation
6 tasks
Collaborator
Author
|
Original PR: #9017 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
test
override_config_table/test_override_config_table.pycreates empty/partial/full configuration and tries to overwrite config_db.json partially or totally, on duthost, for multi-asic platforms.There is coming change from ndm that golden config db is going to change, so that host config and asic configs are put in the same file, distinguished by keys
localhostandasic0asic1... and there comes PR sonic-net/sonic-utilities#2825 to accommodate new ndm change.with this new change, especially with sonic-net/sonic-utilities#2825, this
override_config_table/test_override_config_table.pyno longer works for multi-asic scenarios, because test is providing incorrect format ofgolden_config_db.json. e.g.localhostandasicxis missing in the partial config. Thus we need to skip this test.Summary:
Fixes # (issue)
#8974
Type of change
Back port request
Approach
What is the motivation for this PR?
How did you do it?
How did you verify/test it?
After:
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation