Skip to content

[sonic-package-manager] support extension with multiple YANG modules#2752

Merged
qiluo-msft merged 5 commits intosonic-net:masterfrom
stepanblyschak:multi-yang-support
Apr 30, 2023
Merged

[sonic-package-manager] support extension with multiple YANG modules#2752
qiluo-msft merged 5 commits intosonic-net:masterfrom
stepanblyschak:multi-yang-support

Conversation

@stepanblyschak
Copy link
Contributor

What I did

I added support for application extensions to have multiple YANG modules recorded in the labels.

How I did it

Extended support for yang modules. Preserved backward compatibility with existing extensions.

How to verify it

UT.

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
@qiluo-msft
Copy link
Contributor

Do you have a link to the HLD? I could not understand the motivation "support for application extensions to have multiple YANG modules recorded in the labels".

@liat-grozovik liat-grozovik requested a review from qiluo-msft April 9, 2023 09:00
@stepanblyschak
Copy link
Contributor Author

@qiluo-msft The motivation is to allow 1 application extension provide multiple YANG modules for multiple unrelated CONFIG_DB tables. Such applications is internal work, no public HLD available.

@stepanblyschak
Copy link
Contributor Author

@qiluo-msft If you are saying to update App.Ext HLD then I prepared PR with documents update - sonic-net/SONiC#1321

qiluo-msft
qiluo-msft previously approved these changes Apr 14, 2023
@stepanblyschak
Copy link
Contributor Author

@qiluo-msft @volodymyrsamotiy @liat-grozovik Request for 202211 (I have no permissions to add labels)

@qiluo-msft
Copy link
Contributor

Could you resolve conflict?

@stepanblyschak
Copy link
Contributor Author

@qiluo-msft Done

@liat-grozovik
Copy link
Collaborator

@volodymyrsamotiy @qiluo-msft kindly reminder to review the code

@qiluo-msft qiluo-msft merged commit 7443b9e into sonic-net:master Apr 30, 2023
dprital added a commit to dprital/sonic-buildimage that referenced this pull request May 1, 2023
Update sonic-utilities submodule pointer to include the following:
* 88ffb16 [config]config reload should generate sysinfo if missing ([sonic-net#2778](sonic-net/sonic-utilities#2778))
* 7443b9e [sonic-package-manager] support extension with multiple YANG modules ([sonic-net#2752](sonic-net/sonic-utilities#2752))
* 522c3a9 [sonic-package-manager] add support for multiple CLI plugin files ([sonic-net#2753](sonic-net/sonic-utilities#2753))
* b38fcfd [show][muxcable] fix  RC ([sonic-net#2812](sonic-net/sonic-utilities#2812))
* 7e24463 [chassis]: remote cli commands infra for sonic chassis ([sonic-net#2701](sonic-net/sonic-utilities#2701))
* bee593e [DPB]Fixing typo in config breakout output ([sonic-net#2802](sonic-net/sonic-utilities#2802))
* ada603c [config]Support multi-asic  Golden Config override ([sonic-net#2738](sonic-net/sonic-utilities#2738))
* 88a7daa [show][barefoot] replace shell=True ([sonic-net#2699](sonic-net/sonic-utilities#2699))
* 5e99edb [sonic_package_manager] replace shell=True ([sonic-net#2726](sonic-net/sonic-utilities#2726))
* b547bb4 [acl-loader] Only add default deny rule when table is L3 or L3V6 ([sonic-net#2796](sonic-net/sonic-utilities#2796))

Signed-off-by: dprital <drorp@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants