Feature table cli command update#1271
Merged
abdosi merged 6 commits intosonic-net:masterfrom Nov 26, 2020
Merged
Conversation
Signed-off-by: Abhishek Dosi <[email protected]>
state and auto-restart fields Signed-off-by: Abhishek Dosi <[email protected]>
jleveque
suggested changes
Nov 25, 2020
Contributor
jleveque
left a comment
jleveque
left a comment
There was a problem hiding this comment.
LGTM. Can you also please update the Command Line Reference guide as part of this PR? I realized that the guide did not get updated once we changed the command from show/config container feature autorestart to show/config feature autorestart, and show/config feature state were never added. See: https://github.com/Azure/sonic-utilities/blob/master/doc/Command-Reference.md#container-auto-restart.
Thus can you please do the following:
- Rename (and relocate alphabetically) the sections for
show/config container feature autorestarttoshow/config feature autorestartand update the example output to display the "always_enabled" states - Add documentation for
show/config container feature statecommands
Signed-off-by: Abhishek Dosi <[email protected]>
Contributor
Author
Thanks @jleveque for pointing this out. I have updated the document accordingly. |
jleveque
suggested changes
Nov 25, 2020
Signed-off-by: Abhishek Dosi <[email protected]>
Signed-off-by: Abhishek Dosi <[email protected]>
jleveque
approved these changes
Nov 25, 2020
abdosi
added a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Nov 25, 2020
…d auto-restart fields. (#6000) Added new flag value 'always_enabled' for the state and auto-restart field of feature table init_cfg.json is updated to initialize state field of database/swss/syncd/teamd feature and auto-restart field of database feature as always_enabled Once the state/auto-restart value is initialized as "always_enabled" it is immutable and cannot be change via feature config commands. (config feature..) PR#sonic-net/sonic-utilities#1271 hostcfgd will not take any action if state field value is 'always_enabled' Since we have always_enabled field for auto-restart updated supervisor-proc-exit-listener not to have special check for database and always rely on value from Feature table.
abdosi
added a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Nov 25, 2020
…d auto-restart fields. (#6000) Added new flag value 'always_enabled' for the state and auto-restart field of feature table init_cfg.json is updated to initialize state field of database/swss/syncd/teamd feature and auto-restart field of database feature as always_enabled Once the state/auto-restart value is initialized as "always_enabled" it is immutable and cannot be change via feature config commands. (config feature..) PR#sonic-net/sonic-utilities#1271 hostcfgd will not take any action if state field value is 'always_enabled' Since we have always_enabled field for auto-restart updated supervisor-proc-exit-listener not to have special check for database and always rely on value from Feature table.
Contributor
Author
|
@daall Seems some issue with DVS test case for Policer. |
Contributor
ack |
Contributor
Author
|
retest this please |
abdosi
added a commit
that referenced
this pull request
Nov 26, 2020
added new value "always_enabled" for the state and auto-restart field of Feature Table Once the field value is "always_enabled" it can be changes from config feature .. command Updated Command Reference Manual
3 tasks
santhosh-kt
pushed a commit
to santhosh-kt/sonic-buildimage
that referenced
this pull request
Feb 25, 2021
…d auto-restart fields. (sonic-net#6000) Added new flag value 'always_enabled' for the state and auto-restart field of feature table init_cfg.json is updated to initialize state field of database/swss/syncd/teamd feature and auto-restart field of database feature as always_enabled Once the state/auto-restart value is initialized as "always_enabled" it is immutable and cannot be change via feature config commands. (config feature..) PR#sonic-net/sonic-utilities#1271 hostcfgd will not take any action if state field value is 'always_enabled' Since we have always_enabled field for auto-restart updated supervisor-proc-exit-listener not to have special check for database and always rely on value from Feature table.
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 28, 2022
[routeorch] Handle the empty "nexthop" field for backward compatibility (sonic-net#1263) [vnet] Set MTU for the VNET bridge RIF in BITMAP implementation (sonic-net#1271) [vnet] Verify if BITMAP route exists before creating new one to avoid dublication (sonic-net#1272)
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 28, 2022
49cd91d (HEAD -> 201911, origin/201911) Feature table cli command update (sonic-net#1271) 167d67a [201911] CRM show/config commands changes for multi-asic (sonic-net#1127) (sonic-net#1236) Signed-off-by: Abhishek Dosi <[email protected]>
ganglyu
pushed a commit
to sonic-net/sonic-host-services
that referenced
this pull request
Jul 12, 2022
…d auto-restart fields. (#6000) Added new flag value 'always_enabled' for the state and auto-restart field of feature table init_cfg.json is updated to initialize state field of database/swss/syncd/teamd feature and auto-restart field of database feature as always_enabled Once the state/auto-restart value is initialized as "always_enabled" it is immutable and cannot be change via feature config commands. (config feature..) PR#sonic-net/sonic-utilities#1271 hostcfgd will not take any action if state field value is 'always_enabled' Since we have always_enabled field for auto-restart updated supervisor-proc-exit-listener not to have special check for database and always rely on value from Feature table.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did:
added new value "always_enabled" for the state and auto-restart field of Feature Table
Once the field value is "always_enabled" it can-not be changed from config feature .. command
Updated Command Reference Manual
How I Verify:
Added the unit test case to change state/auto-restart field value of feature that has always_enabled and it should not update the field value.