[hostcfgd] check cached state instead of the next state#6067
[hostcfgd] check cached state instead of the next state#6067yxieca merged 2 commits intosonic-net:masterfrom
Conversation
When checking if a feature is 'always_enabled', check the cached state to prevent new change to be accepted. Signed-off-by: Ying Xie <ying.xie@microsoft.com>
|
@yxieca I think we do not need this change this once we update sonic-util submodule which will bring change from this PR: sonic-net/sonic-utilities#1271 PR for submodule update: #6070 |
@abdosi I think we still need this change. I fixed 2 logic issues in this change and added a protection (reverting wrong change). I hope we never need to exercise the protection. But the 2 logic error fixes are necessary. @yxieca a) We update cache state first in update_all_feature_states. This make sure we get “always_enabled” Idea to use next ‘state’ (user provided value) to protect was based on assumption sonic-util has correct check. |
lguohan
left a comment
lguohan
left a comment
There was a problem hiding this comment.
extra protection, looks ok.
- Why I did it 'always_enabled' feature can still be disabled/enabled. - How I did it When checking if a feature is 'always_enabled', check the cached state to prevent new change to be accepted. Fix an issue where cache value is updated before all the check is done. Restore 'always_enabled' value in config db if someone wants to change. Signed-off-by: Ying Xie ying.xie@microsoft.com - How to verify it Without the fix, 'always_enabled' feature can be enabled or disabled without cli protection. With the protection, the change will be rejected properly.
4 participants
- Why I did it
'always_enabled' feature can still be disabled/enabled.
- How I did it
When checking if a feature is 'always_enabled', check the cached state to prevent new change to be accepted.
Fix an issue where cache value is updated before all the check is done.
Restore 'always_enabled' value in config db if someone wants to change.
Signed-off-by: Ying Xie ying.xie@microsoft.com
- How to verify it
Without the change:
root@str2-dx010-acs-6:/home/admin# show feature status
Feature State AutoRestart
...
teamd always_enabled enabled
...
root@str2-dx010-acs-6:/home/admin# config feature state teamd disabled
root@str2-dx010-acs-6:/home/admin# show feature status
Feature State AutoRestart
...
teamd disabled enabled
...
With the fix:
root@str2-dx010-acs-6:/home/admin# config feature state teamd disabled
root@str2-dx010-acs-6:/home/admin# show feature status
Feature State AutoRestart
...
teamd always_enabled enabled
...