Enhanced Feature table to support 'always_enabled' value for state and auto-restart fields.#6000
Merged
abdosi merged 2 commits intosonic-net:masterfrom Nov 25, 2020
Merged
Conversation
Contributor
Author
|
vsimage test "test_po_cleanup.py" failure is expected since we need to update the test case based on this change. Updated the test case here: sonic-net/sonic-mgmt#2577 |
rlhui
previously approved these changes
Nov 24, 2020
auto-restart field of Feature table. Signed-off-by: Abhishek Dosi <[email protected]>
abdosi
force-pushed
the
feature_update
branch
from
d4f0aa6 to
096cb4f
Compare
jleveque
suggested changes
Nov 25, 2020
Contributor
jleveque
left a comment
jleveque
left a comment
There was a problem hiding this comment.
As comments.
Also please update PR title and description to align with new solution.
abdosi
changed the title
abdosi
added a commit
to sonic-net/sonic-mgmt
that referenced
this pull request
Nov 25, 2020
Use systemctl stop teamd instead of config feature. Changes trigger because of sonic-net/sonic-buildimage#6000
Signed-off-by: Abhishek Dosi <[email protected]>
jleveque
approved these changes
Nov 25, 2020
abdosi
added a commit
that referenced
this pull request
Nov 25, 2020
…d auto-restart fields. (#6000) Added new flag value 'always_enabled' for the state and auto-restart field of feature table init_cfg.json is updated to initialize state field of database/swss/syncd/teamd feature and auto-restart field of database feature as always_enabled Once the state/auto-restart value is initialized as "always_enabled" it is immutable and cannot be change via feature config commands. (config feature..) PR#sonic-net/sonic-utilities#1271 hostcfgd will not take any action if state field value is 'always_enabled' Since we have always_enabled field for auto-restart updated supervisor-proc-exit-listener not to have special check for database and always rely on value from Feature table.
santhosh-kt
pushed a commit
to santhosh-kt/sonic-buildimage
that referenced
this pull request
Feb 25, 2021
…d auto-restart fields. (sonic-net#6000) Added new flag value 'always_enabled' for the state and auto-restart field of feature table init_cfg.json is updated to initialize state field of database/swss/syncd/teamd feature and auto-restart field of database feature as always_enabled Once the state/auto-restart value is initialized as "always_enabled" it is immutable and cannot be change via feature config commands. (config feature..) PR#sonic-net/sonic-utilities#1271 hostcfgd will not take any action if state field value is 'always_enabled' Since we have always_enabled field for auto-restart updated supervisor-proc-exit-listener not to have special check for database and always rely on value from Feature table.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did:
Fixes Issue##5999
How I did:
Added new flag value 'always_enabled' for the state and auto-restart field of feature table
init_cfg.json is updated to initialize state field of database/swss/syncd/teamd feature and auto-restart field of database feature
as always_enabled
Once the state/auto-restart value is initialized as "always_enabled" it is immutable and cannot be change via feature config commands. (config feature..) PR#Feature table cli command update sonic-utilities#1271
hostcfgd will not take any action if state field value is 'always_enabled'
Since we have always_enabled field for auto-restart updated supervisor-proc-exit-listener
not to have special check for database and always rely on value from Feature table.
How I Verify:
Nov 25 01:02:44.925773 str-xxx-2 INFO hostcfgd: Feature 'teamd' service is always enabled