[config] Avoid error in config load_mgmt_conf when mgmt is already co…#126
Merged
taoyl-ms merged 3 commits intosonic-net:masterfrom Oct 6, 2017
Merged
[config] Avoid error in config load_mgmt_conf when mgmt is already co…#126taoyl-ms merged 3 commits intosonic-net:masterfrom
taoyl-ms merged 3 commits intosonic-net:masterfrom
Conversation
lguohan
approved these changes
Oct 6, 2017
jleveque
suggested changes
Oct 6, 2017
config/main.py
Outdated
| run_command(command, display_cmd=True, ignore_error=True) | ||
| command = "[ -f /var/run/dhclient.eth0.pid ] && kill `cat /var/run/dhclient.eth0.pid` && rm -f /var/run/dhclient.eth0.pid" | ||
| run_command(command, display_cmd=True) | ||
| run_command(command, display_cmd=True. ignore_error=True) |
Contributor
There was a problem hiding this comment.
Looks like a typo, period instead of comma after first "True": display_cmd=True.
jleveque
approved these changes
Oct 6, 2017
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 28, 2022
…onic-net#4193) * [Mellanox]Integrate hw-mgmt 7.0000.3012 * [sonic-linux-kernel]Advance the submodule head Advance the sonic-linux-kernel [sFlow]: Patch to fix skb_over_panic in psample driver (sonic-net#120) Added support in the kernel for fullcone 3-tuple unique nat. (#100) Adding support to compile ARM architecture (#102) [ixgbe] Support bcm54616s external phy in ixgbe (sonic-net#122) Fix i2c ISMT DMA buffer alignment issue (sonic-net#123) [mellanox]: Add SN4700 patches. (sonic-net#126)
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 28, 2022
following PR's : Implement cbgpPeer2State in CiscoBgp4MIB (sonic-net#119) Fix index nodes in LLDP tables whose access right is not-accessible. (sonic-net#112) Fix quagga/FRR parser on IPv6 BGP sessions (sonic-net#122) [lint] Fix some syntax errors or warnings (sonic-net#127) Update README.md: Add lgtm badges (sonic-net#128) [Multi-asic]: Support multi-asic platform (sonic-net#126) Simplify test code (sonic-net#132) [Multi-asic]: Namespace support for LLDP and Sensor tables (sonic-net#131) Fix undefined variable and warning message (sonic-net#134) Fix SNMP AgentX socket connection timeout when using Namespace.get_all() (sonic-net#140) [Namespace] Fix interfaces counters in InterfacesMIB RFC 2863 (sonic-net#141) Fix LGTM reported alert of PR#141 (sonic-net#142)
mihirpat1
pushed a commit
to mihirpat1/sonic-utilities
that referenced
this pull request
Sep 15, 2023
…m address space within platform api (sonic-net#126) * [sonic_sfp] adding abstract methods for platform api's Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
cyw233
pushed a commit
to cyw233/sonic-utilities
that referenced
this pull request
Mar 2, 2026
<!-- Please make sure you've read and understood our contributing guidelines: https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md failure_prs.log skip_prs.log Make sure all your commits include a signature generated with `git commit -s` ** If this is a bug fix, make sure your description includes "closes #xxxx", "fixes #xxxx" or "resolves #xxxx" so that GitHub automatically closes the related issue when the PR is merged. If you are adding/modifying/removing any command or utility script, please also make sure to add/modify/remove any unit tests from the tests directory as appropriate. If you are modifying or removing an existing 'show', 'config' or 'sonic-clear' subcommand, or you are adding a new subcommand, please make sure you also update the Command Line Reference Guide (doc/Command-Reference.md) to reflect your changes. Please provide the following information: --> #### What I did Restore hardware related configuration: `asic_id` from old config or local file (if not exist) since the golden config does not have them. #### How I did it Add a function to backfill the field `asic_id` to config db by old config or read local files (if not exist) afterload golden config. #### How to verify it Using lab device to download golden config which does not have these fields, and apply through load_minigraph with overridde golden config option, then check configdb dump if asic_id get populated correctly. #### Previous command output (if the output of a command-line utility has changed) #### New command output (if the output of a command-line utility has changed)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…nfigured