[multi-asic][warm-reboot] Support warm-reboot on Multi-ASIC systems#100
Closed
stepanblyschak wants to merge 21 commits intomasterfrom
Closed
[multi-asic][warm-reboot] Support warm-reboot on Multi-ASIC systems#100stepanblyschak wants to merge 21 commits intomasterfrom
stepanblyschak wants to merge 21 commits intomasterfrom
Conversation
stepanblyschak
force-pushed
the
masic-warm-reboot
branch
from
6457fdb to
2102471
Compare
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
stepanblyschak
force-pushed
the
masic-warm-reboot
branch
from
2102471 to
fa594b1
Compare
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
stepanblyschak
force-pushed
the
masic-warm-reboot
branch
from
13d1763 to
ba85864
Compare
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
|
|
||
| debug "Stopping $service_name ..." | ||
|
|
||
| # TODO: These exceptions for nat, sflow, lldp |
There was a problem hiding this comment.
Do you plan to remove this TODO?
Owner
Author
There was a problem hiding this comment.
@oleksandrivantsiv TODO existed before, don't plan to handle it here
| timeout --foreground 30 python3 ${LAG_KEEPALIVE_SCRIPT} --fork-into-background --namespace "$NETNS" | ||
|
|
||
| # give the lag_keepalive script a chance to send some LACPDUs | ||
| sleep 5 |
There was a problem hiding this comment.
How can we know that 5 secs is enough?
Owner
Author
There was a problem hiding this comment.
@oleksandrivantsiv This sleep existed before, you are right, it might be not enough, don't plan to change it here
|
Beside some minor comments lgtm |
oleksandrivantsiv
approved these changes
Jan 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Implement warm-reboot script support for Multi-ASIC systems.
How I did it
Modified warm-reboot script.
How to verify it
Verified on Multi-ASIC KVM with 4 ASICs:
On boot SAI started in warm boot mode:
Tested on single-ASIC real HW:
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)