Merged
Conversation
Implement PFC WD stats query Signed-off-by: marian-pritsak <[email protected]>
jleveque
suggested changes
Nov 1, 2017
setup.py
Outdated
| maintainer='Joe LeVeque', | ||
| maintainer_email='[email protected]', | ||
| packages=['config', 'sfputil', 'show', 'sonic_eeprom', 'sonic_installer', 'sonic_psu', 'sonic_sfp', 'acl_loader', 'sonic-utilities-tests', 'clear', 'debug', 'undebug'], | ||
| packages=['config', 'sfputil', 'show', 'sonic_eeprom', 'sonic_installer', 'sonic_psu', 'sonic_sfp', 'acl_loader', 'sonic-utilities-tests', 'clear', 'debug', 'undebug', 'pfcwd' ], |
Contributor
There was a problem hiding this comment.
This line is getting quite long. Could you please break this definition over multiple lines and also rearrange members alphabetically? E.g.,
packages=['acl_loader',
'clear',
'config',
'debug',
'show',
...
'undebug',
],
| 'sonic-clear = clear.main:cli', | ||
| 'debug = debug.main:cli', | ||
| 'undebug = undebug.main:cli' | ||
| 'undebug = undebug.main:cli', |
Contributor
There was a problem hiding this comment.
While you're at it, could you please rearrange the console-scripts in alphabetical order, also? Thanks.
Signed-off-by: marian-pritsak <[email protected]>
Signed-off-by: marian-pritsak <[email protected]>
jleveque
suggested changes
Nov 2, 2017
setup.py
Outdated
| 'sonic_sfp', | ||
| 'sonic-utilities-tests', | ||
| 'undebug', | ||
| ], |
Contributor
There was a problem hiding this comment.
Please reduce indent to 4 spaces for the closing bracket.
Collaborator
Author
There was a problem hiding this comment.
Missed this one. Done.
Collaborator
Author
|
@jleveque please review |
jleveque
approved these changes
Nov 3, 2017
Contributor
|
@lguohan: Please review, also. |
lguohan
approved these changes
Nov 6, 2017
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 28, 2022
following PR's : Implement cbgpPeer2State in CiscoBgp4MIB (sonic-net#119) Fix index nodes in LLDP tables whose access right is not-accessible. (sonic-net#112) Fix quagga/FRR parser on IPv6 BGP sessions (sonic-net#122) [lint] Fix some syntax errors or warnings (sonic-net#127) Update README.md: Add lgtm badges (sonic-net#128) [Multi-asic]: Support multi-asic platform (sonic-net#126) Simplify test code (sonic-net#132) [Multi-asic]: Namespace support for LLDP and Sensor tables (sonic-net#131) Fix undefined variable and warning message (sonic-net#134) Fix SNMP AgentX socket connection timeout when using Namespace.get_all() (sonic-net#140) [Namespace] Fix interfaces counters in InterfacesMIB RFC 2863 (sonic-net#141) Fix LGTM reported alert of PR#141 (sonic-net#142)
mihirpat1
pushed a commit
to mihirpat1/sonic-utilities
that referenced
this pull request
Sep 15, 2023
Member constant is inherited; do not need to reference into base class.
Junchao-Mellanox
pushed a commit
to Junchao-Mellanox/sonic-utilities
that referenced
this pull request
Mar 20, 2025
sonic-net#142) ```<br>* 042c5555 - (HEAD -> 202412) Merge branch '202411' of https://github.com/sonic-net/sonic-utilities into 202412 (2025-03-05) [Sonic Automation] * c01a4f5 - (origin/202411) Add namespace support for show interface neighbor expected (sonic-net#3790) (2025-03-03) [mssonicbld] * 17a7b18 - Fix `vnet_route_check` for active and inactive routes, add `--all` option (sonic-net#3780) (2025-02-25) [mssonicbld] * 5cc1012 - [202411][FC] remove FC delay field (sonic-net#3768) (2025-02-21) [Stepan Blyshchak] * 8ceba38 - [QOS] Skip showing unnecessary warning message (sonic-net#3762) (2025-02-11) [mssonicbld] * 04b60e2 - Fix call for spanning-tree commands in dump script (sonic-net#3752) (2025-02-07) [mssonicbld] * bbe29ae - [show][interface] Add changes for show interface errors command (sonic-net#3749) (2025-02-04) [mssonicbld]<br>```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement PFC WD stats query
Signed-off-by: marian-pritsak [email protected]