[201911]show interface counters for multi ASIC devices#1104
Merged
arlakshm merged 2 commits intosonic-net:201911from Sep 10, 2020
Merged
[201911]show interface counters for multi ASIC devices#1104arlakshm merged 2 commits intosonic-net:201911from
arlakshm merged 2 commits intosonic-net:201911from
Conversation
Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <[email protected]>
|
This pull request introduces 1 alert and fixes 1 when merging fa44127 into 38f474e - view on LGTM.com new alerts:
fixed alerts:
|
jleveque
suggested changes
Sep 9, 2020
Contributor
jleveque
left a comment
jleveque
left a comment
There was a problem hiding this comment.
Minor comment. Also, LGTM is complaining that the swsssdk module is unused. You didn't add it in this PR, but maybe you could remove it?
Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <[email protected]>
Contributor
Author
removed the unused import |
jleveque
approved these changes
Sep 9, 2020
Contributor
jleveque
left a comment
jleveque
left a comment
There was a problem hiding this comment.
Looks good to me. Please wait for other reviewers.
|
This pull request fixes 1 alert when merging 1ba78ee into 38f474e - view on LGTM.com fixed alerts:
|
smaheshm
reviewed
Sep 9, 2020
| self.db.connect(self.db.COUNTERS_DB) | ||
| self.db.connect(self.db.APPL_DB) | ||
| def __init__(self, namespace, display_option): | ||
| self.db = None |
Contributor
Author
There was a problem hiding this comment.
config_db is not used in here.
smaheshm
reviewed
Sep 9, 2020
| mutli_asic_intf_counters_after_clear = """\ | ||
| IFACE STATE RX_OK RX_BPS RX_UTIL RX_ERR RX_DRP RX_OVR TX_OK TX_BPS TX_UTIL TX_ERR TX_DRP TX_OVR | ||
| -------------- ------- ------- -------- --------- -------- -------- -------- ------- -------- --------- -------- -------- -------- | ||
| Ethernet0 U 0 0.00 B/s 0.00% 0 0 N/A 0 0.00 B/s 0.00% N/A N/A N/A |
Contributor
There was a problem hiding this comment.
some non N/A would be good, not a big deal
smaheshm
approved these changes
Sep 9, 2020
Contributor
smaheshm
left a comment
smaheshm
left a comment
There was a problem hiding this comment.
optional minor changes.
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 28, 2022
update the environment variable in the teardown (sonic-net#1101) Fix for show interface portchannel now working on 201911 (sonic-net#1105) [201911]show interface counters for multi ASIC devices (sonic-net#1104) Signed-off-by: Abhishek Dosi <[email protected]>
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 28, 2022
update the environment variable in the teardown (sonic-net#1101) Fix for show interface portchannel now working on 201911 (sonic-net#1105) Revert "Pfcstat (sonic-net#1097)" Revert " [201911]show interface counters for multi ASIC devices (sonic-net#1104)" Signed-off-by: Abhishek Dosi <[email protected]>
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 28, 2022
Revert "Revert " [201911]show interface counters for multi ASIC devices (sonic-net#1104)"" Revert "Revert "Pfcstat (sonic-net#1097)"" [show] Fix 'show int neighbor expected' (sonic-net#1106) Update argument for docker exec it->i (sonic-net#1118) Update to make config load/reload backward compatible. (sonic-net#1115) Handling deletion of Port Channel before deletion of its members (sonic-net#1062) Skip default route present in ASIC-DB but not in APP-DB. (sonic-net#1107) [CLI][PFCWD][Multi-ASIC] Added multi ASIC support to 'pfcwd' CLI (sonic-net#1102) [201911] Multi asic platform config interface portchannel, show transceiver (sonic-net#1087) [drop counters] Fix configuration for counters with lowercase names (sonic-net#1103) Signed-off-by: Abhishek Dosi <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan [email protected]
- What I did
port #1013 to 201911
Add support for multi ASIC CLI options for show interface portchannels
2 new options have added
[-n, --namespace] to allow user to display the information for given namespaces
If this option is not present the information from all the namespaces will be displayed
[-d, --display] to allow user to display information related both internal and external interfaces
If this option is not present only external interfaces/neighbors will be display
One single ASIC platform, this options are not valid, so the behavior remains unchanged
- How I did it
This new options are ignored for single ASIC platforms
- How to verify it
Help menu
show interface counters for all ports in multi ASIC device
**show interface counters for specific ASIC **
Counters for internal and external interfaces
- Previous command output (if the output of a command-line utility has changed)
- New command output (if the output of a command-line utility has changed)