Merged
Conversation
|
This pull request introduces 5 alerts and fixes 2 when merging 58be765 into a293399 - view on LGTM.com new alerts:
fixed alerts:
|
Contributor
Author
|
@abdosi This is pending on cherry picking sonic-net/sonic-buildimage#5221 into 201911 buildimage. |
|
This pull request fixes 2 alerts when merging b89e857 into a293399 - view on LGTM.com fixed alerts:
|
|
This pull request fixes 2 alerts when merging bdabd43 into a293399 - view on LGTM.com fixed alerts:
|
|
This pull request fixes 2 alerts when merging 5f7e54d into a293399 - view on LGTM.com fixed alerts:
|
abdosi
approved these changes
Sep 5, 2020
Contributor
|
@smaheshm There is compilation error of pfc stat unit test failing. Please check |
Contributor
Author
|
raised #1101 |
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 28, 2022
update the environment variable in the teardown (sonic-net#1101) Fix for show interface portchannel now working on 201911 (sonic-net#1105) Revert "Pfcstat (sonic-net#1097)" Revert " [201911]show interface counters for multi ASIC devices (sonic-net#1104)" Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 28, 2022
Revert "Revert " [201911]show interface counters for multi ASIC devices (sonic-net#1104)"" Revert "Revert "Pfcstat (sonic-net#1097)"" [show] Fix 'show int neighbor expected' (sonic-net#1106) Update argument for docker exec it->i (sonic-net#1118) Update to make config load/reload backward compatible. (sonic-net#1115) Handling deletion of Port Channel before deletion of its members (sonic-net#1062) Skip default route present in ASIC-DB but not in APP-DB. (sonic-net#1107) [CLI][PFCWD][Multi-ASIC] Added multi ASIC support to 'pfcwd' CLI (sonic-net#1102) [201911] Multi asic platform config interface portchannel, show transceiver (sonic-net#1087) [drop counters] Fix configuration for counters with lowercase names (sonic-net#1103) Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[ merge from #1057 ]
Added 'multi ASIC' support to the 'show pfc counters' CLI. Modified 'pfcstat' command to include multi ASIC args.
By default 'show pfc counters' or 'pfcstat' display the counters for the front end ports. To display on all ports "-s all" option must be specified. On single ASIC platforms by default all port counters are shown, there's no effect of '-s' (show) option.
How I did it
Modified show/main.py and 'pfcstat' to include multi ASIC options and args respectively.
Used multi ASIC common APIs and decorator to collect information from specified namespaces or all namespaces (by default).
How to verify it
Verified the commands on multi ASIC platform.