[Pytest][Multi ASIC] Update the environment variable in the teardown#1101
Merged
abdosi merged 1 commit intosonic-net:201911from Sep 8, 2020
Merged
[Pytest][Multi ASIC] Update the environment variable in the teardown#1101abdosi merged 1 commit intosonic-net:201911from
abdosi merged 1 commit intosonic-net:201911from
Conversation
Contributor
Author
|
retest this please |
Merged
Contributor
Author
|
retest this please |
neethajohn
approved these changes
Sep 8, 2020
Contributor
|
we can cherry-pick from master . What is corresponding master PR ? |
abdosi
requested changes
Sep 8, 2020
Contributor
abdosi
left a comment
abdosi
left a comment
There was a problem hiding this comment.
do we need 201911 specific PR for this ?
Contributor
|
@arlakshm for viz |
abdosi
approved these changes
Sep 8, 2020
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 28, 2022
update the environment variable in the teardown (sonic-net#1101) Fix for show interface portchannel now working on 201911 (sonic-net#1105) [201911]show interface counters for multi ASIC devices (sonic-net#1104) Signed-off-by: Abhishek Dosi <[email protected]>
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 28, 2022
update the environment variable in the teardown (sonic-net#1101) Fix for show interface portchannel now working on 201911 (sonic-net#1105) Revert "Pfcstat (sonic-net#1097)" Revert " [201911]show interface counters for multi ASIC devices (sonic-net#1104)" Signed-off-by: Abhishek Dosi <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Fix a bug in Multi ASIC interface test.
'multi ASIC' env variable was causing a subsequent test to fail.
- How I did it
Updated the env variable in teardown function.
- How to verify it
verified by running the pytest
- Previous command output (if the output of a command-line utility has changed)
- New command output (if the output of a command-line utility has changed)