Closed
Conversation
Contributor
|
What is the root cause of ready delay for VLAN interface? |
Contributor
Author
|
Not sure. I only isolated to these 2 changes. Didn't have time to look deeper yet. |
Contributor
|
If this PR #748 is merged, can we avoid reverting? |
Contributor
| sai_object_id_t m_egress_acl_table_group_id = 0; | ||
| vlan_members_t m_vlan_members; | ||
| sai_port_oper_status_t m_oper_status = SAI_PORT_OPER_STATUS_UNKNOWN; | ||
| sai_port_oper_status_t m_oper_status; |
Contributor
There was a problem hiding this comment.
This brings back undefined behavior, e.g:
For LAG, VLAN m_oper_status field is never set, so there is a chance that NeighOrch will invalidate neighbor on LAG or VLAN in next hop group in case m_oper_status equals SAI_PORT_OPER_STATUS_DOWN.
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Mar 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Reverting PR #718 and PR #727.
Why I did it
These 2 changes caused VLAN interface becoming ready for about 20 seconds later. This delay caused fast-reboot to fail, and triggered a failure in warm-reboot test.
How I verified it
After reverting the change, fast-reboot test is passing. And warm-reboot test don't see data plane disruption anymore.