[neighorch] return back original condition for port oper status#727
Merged
qiluo-msft merged 1 commit intosonic-net:masterfrom Dec 23, 2018
Merged
[neighorch] return back original condition for port oper status#727qiluo-msft merged 1 commit intosonic-net:masterfrom
qiluo-msft merged 1 commit intosonic-net:masterfrom
Conversation
Signed-off-by: Stepan Blyschak <[email protected]>
prsunny
approved these changes
Dec 12, 2018
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Mar 1, 2023
sonic-net#727) Fix the syncd crash during Dynamic Port Breakout (DPB). The syncd is processing in-transit port events after port has been removed. Add check to avoid it.
Janetxxx
pushed a commit
to Janetxxx/sonic-swss
that referenced
this pull request
Nov 10, 2025
…c-net#727) Signed-off-by: Stepan Blyschak <[email protected]>
jianyuewu
pushed a commit
to jianyuewu/sonic-swss
that referenced
this pull request
Dec 24, 2025
* Use correct sonic-slave image.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stepan Blyschak [email protected]
What I did
Return back original condition for port operational status when adding a next hop.
Why I did it
port::m_oper_status is by default SAI_PORT_OPER_STATUS_UNKNOWN.
If port is LAG or VLAN m_oper_status is not overridden with value in state DB, so
(p.m_oper_status != SAI_PORT_OPER_STATUS_UP) is true and next hop flag IFDOWN is set.
This is workaround, need to listen to state db to update oper status in port struct
How I verified it
Built and verified that next hops are added to ecmp group
Details if related