[portsorch] Portsorch simple improvements#718
Merged
qiluo-msft merged 4 commits intosonic-net:masterfrom Dec 3, 2018
Merged
Conversation
added 4 commits
December 3, 2018 13:35
Signed-off-by: Stepan Blyschak <[email protected]>
- Change 'p' varaible name to 'port' - Pass 'Port' struct object to set/update methods instead of SAI OID to avoid unncessary 'for' loops that search port object in m_portList - minor simple changes Signed-off-by: Stepan Blyschak <[email protected]>
Signed-off-by: Stepan Blyschak <[email protected]>
Signed-off-by: Stepan Blyschak <[email protected]>
stepanblyschak
changed the title
stcheng
approved these changes
Dec 3, 2018
Contributor
stcheng
left a comment
stcheng
left a comment
There was a problem hiding this comment.
thanks for the improvements!
qiluo-msft
approved these changes
Dec 3, 2018
yxieca
added a commit
to yxieca/sonic-swss
that referenced
this pull request
Jan 10, 2019
This reverts commit 3d60b3e.
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
…sonic-net#718) * Revert "show BPS, PPS, UTIL rates w/o previous clear (sonic-net#508)" This reverts commit 148d455. * [portstat] use actual port speed for util calculation after revert Signed-off-by: Mykola Faryma <[email protected]>
Janetxxx
pushed a commit
to Janetxxx/sonic-swss
that referenced
this pull request
Nov 10, 2025
* [portsorch] throw runtime_error object instead of const char* * [portsorch] simple improvements for portsorch - Change 'p' varaible name to 'port' - Pass 'Port' struct object to set/update methods instead of SAI OID to avoid unncessary 'for' loops that search port object in m_portList - minor simple changes * [portsorch]] address comments * [portsorch] make setHostIntfsOperStatus/updateDbPortOperStatus const
jianyuewu
pushed a commit
to jianyuewu/sonic-swss
that referenced
this pull request
Dec 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
unncessary 'for' loops that search port object in m_portList
Why I did it
This PR was derivied from #704.
I will create another PR with fix for Mellanox fastfast boot feature
How I verified it
Installed swss deb package on switch & verify it is working good
Details if related