Skip to content

MUX nbrs to use no-host-route & use nh update#3722

Open
manamand2020 wants to merge 25 commits intosonic-net:masterfrom
manamand2020:dualtor_prefixrt_neigh
Open

MUX nbrs to use no-host-route & use nh update#3722
manamand2020 wants to merge 25 commits intosonic-net:masterfrom
manamand2020:dualtor_prefixrt_neigh

Conversation

@manamand2020
Copy link
Contributor

@manamand2020 manamand2020 commented Jun 23, 2025

What I did
MUX neighbors will not use host route and full prefix route is explicitly created.
During mux state switchover only update the nexthop in these full prefix route of the neighbors.

Why I did it
This avoids multiple SAI calls done during MUX state switchover and reduces the switchover time.

How I verified it
Verified on hardware and VS Tests.

Details if related

@manamand2020 manamand2020 requested a review from prsunny as a code owner June 23, 2025 10:04
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@prsunny prsunny requested review from Ndancejic and zjswhhh June 27, 2025 16:32
@manamand2020 manamand2020 force-pushed the dualtor_prefixrt_neigh branch from d81c7d4 to bf2bfdb Compare July 9, 2025 14:58
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@manamand2020 manamand2020 force-pushed the dualtor_prefixrt_neigh branch from bf2bfdb to 72f9227 Compare July 9, 2025 15:00
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@manamand2020 manamand2020 marked this pull request as ready for review July 9, 2025 15:08
@manamand2020 manamand2020 force-pushed the dualtor_prefixrt_neigh branch from 72f9227 to d826c5c Compare July 9, 2025 21:12
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@manamand2020 manamand2020 force-pushed the dualtor_prefixrt_neigh branch from d826c5c to 1a74366 Compare July 10, 2025 22:03
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@manamand2020 manamand2020 force-pushed the dualtor_prefixrt_neigh branch from 1a74366 to 7352e2f Compare July 10, 2025 22:06
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

Signed-off-by: Manas Kumar Mandal <[email protected]>
@manamand2020 manamand2020 force-pushed the dualtor_prefixrt_neigh branch from c8ef06d to 8031243 Compare November 4, 2025 20:04
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Ndancejic
Copy link
Contributor

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

gordon-nexthop pushed a commit to nexthop-ai/sonic-utilities that referenced this pull request Nov 25, 2025
What I did
dualtor_neighbor_check.py script needs this change based on changes in the following PR:
sonic-net/sonic-swss#3722

neighbors are no more deleted during switchover to standby
@prsunny
Copy link
Collaborator

prsunny commented Nov 25, 2025

This PR cannot be merged as-is, the following are the gaps:

  1. Missing link to HLD and Testplan
  2. Too many changes that can impact backward compatibility
  3. Support removed for bulk nexthops and neighbors which can be used for other usecases
  4. Lack of capability check

YairRaviv pushed a commit to YairRaviv/sonic-utilities that referenced this pull request Jan 12, 2026
…rs (sonic-net#4007)

What I did
Mux neighbors now use prefix-based routes based on changes from the following PR:
sonic-net/sonic-swss#3722
Presence of route prefix for neighbors does not mean tunnel-route use anymore. Show command now uses nexthop type to distinguish between tunnel and normal neighbor route.

How to verify it
Verified output on hardware.

Signed-off-by: Manas Kumar Mandal <[email protected]>
YairRaviv pushed a commit to YairRaviv/sonic-utilities that referenced this pull request Jan 12, 2026
What I did
dualtor_neighbor_check.py script needs this change based on changes in the following PR:
sonic-net/sonic-swss#3722

neighbors are no more deleted during switchover to standby
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants