dualtor_neighbor_check.py changed#3931
Merged
qiluo-msft merged 6 commits intosonic-net:masterfrom Oct 30, 2025
Merged
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
manamand2020
force-pushed
the
dualtor_neigh_check
branch
from
acaa441 to
5e72c89
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
zjswhhh
reviewed
Jun 25, 2025
zjswhhh
reviewed
Jun 25, 2025
Contributor
zjswhhh
left a comment
zjswhhh
left a comment
There was a problem hiding this comment.
Also, please evaluate on the backward compatibility. This needs to check in with the no_host_route change.
Signed-off-by: Manas Kumar Mandal <manamand@cisco.com>
manamand2020
force-pushed
the
dualtor_neigh_check
branch
from
5e72c89 to
197fc05
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Manas Kumar Mandal <manamand@cisco.com>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
@manamand2020 - can you please address the precommit failures. |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Manas Kumar Mandal <manamand@cisco.com>
manamand2020
force-pushed
the
dualtor_neigh_check
branch
from
f49506a to
d4414d8
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
manamand2020
force-pushed
the
dualtor_neigh_check
branch
from
62a3c6b to
df62614
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
manamand2020
force-pushed
the
dualtor_neigh_check
branch
from
4b3d350 to
96b0157
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
@Ndancejic I fixed it. |
zjswhhh
previously approved these changes
Jul 28, 2025
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
manamand2020
force-pushed
the
dualtor_neigh_check
branch
from
86c3c8c to
9ccc5ae
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Manas Kumar Mandal <manamand@cisco.com>
manamand2020
force-pushed
the
dualtor_neigh_check
branch
from
9ccc5ae to
3843ddb
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yxieca
pushed a commit
to Azure/sonic-utilities.msft
that referenced
this pull request
Jul 30, 2025
What I did Port the fix from sonic-net/sonic-utilities#3931 How to verify it Verified original PR on hardware. Signed-off-by: Manas Kumar Mandal <manamand@cisco.com>
zjswhhh
approved these changes
Aug 6, 2025
Contributor
|
Hi @qiluo-msft - please help merge. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the dualtor neighbor check functionality by adding nexthop type verification to better identify neighbor routing inconsistencies. The change distinguishes between NEIGHBOR and TUNNEL nexthop types when validating neighbor entries against mux states.
- Adds nexthop table reading from ASIC_DB to capture nexthop type information
- Updates the consistency check logic to verify that active mux states use NEIGHBOR nexthops and standby states use TUNNEL nexthops
- Adds two new test cases to verify SOC IP neighbor handling and multiple neighbor scenarios
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| scripts/dualtor_neighbor_check.py | Implements nexthop table reading in Lua script, adds nexthop type tracking and validation logic in consistency checks |
| tests/dualtor_neighbor_check_test.py | Updates all existing tests with nexthop_table parameter and expected outputs, adds new tests for SOC IP neighbors |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gordon-nexthop
pushed a commit
to nexthop-ai/sonic-utilities
that referenced
this pull request
Nov 25, 2025
What I did dualtor_neighbor_check.py script needs this change based on changes in the following PR: sonic-net/sonic-swss#3722 neighbors are no more deleted during switchover to standby
Contributor
|
@manamand2020 , @zjswhhh , is this backward compatible?. Is there an HLD? Need to see how the output was before and what is the output with this change |
qiluo-msft
pushed a commit
that referenced
this pull request
Nov 27, 2025
YairRaviv
pushed a commit
to YairRaviv/sonic-utilities
that referenced
this pull request
Jan 12, 2026
What I did dualtor_neighbor_check.py script needs this change based on changes in the following PR: sonic-net/sonic-swss#3722 neighbors are no more deleted during switchover to standby
YairRaviv
pushed a commit
to YairRaviv/sonic-utilities
that referenced
this pull request
Jan 12, 2026
…t#4136) Reverts sonic-net#3931 Reverting for backward compatibility issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
dualtor_neighbor_check.py script needs this change based on changes in the following PR:
sonic-net/sonic-swss#3722
neighbors are no more deleted during switchover to standby
How I did it
How to verify it
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)