Adapt 'show muxcable tunnel-route' for prefix route based mux neighbors#4007
Merged
yxieca merged 2 commits intosonic-net:masterfrom Aug 8, 2025
Merged
Adapt 'show muxcable tunnel-route' for prefix route based mux neighbors#4007yxieca merged 2 commits intosonic-net:masterfrom
yxieca merged 2 commits intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
manamand2020
force-pushed
the
muxcable_tunnel_route
branch
from
88e2d60 to
cb809d2
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Manas Kumar Mandal <[email protected]>
manamand2020
force-pushed
the
muxcable_tunnel_route
branch
from
cb809d2 to
947b6d6
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
zjswhhh
reviewed
Aug 4, 2025
Contributor
zjswhhh
left a comment
zjswhhh
left a comment
There was a problem hiding this comment.
lgtm mostly!
Can you also add UT to cover the case that when ROUTE exists, but next hop is non tunnel.
lolyu
reviewed
Aug 5, 2025
Contributor
lolyu
left a comment
lolyu
left a comment
There was a problem hiding this comment.
LGTM, so no change to the command line output format right?
Signed-off-by: Manas Kumar Mandal <[email protected]>
Contributor
Author
Added entry in mock_tables which gets covered by existing test cases. |
Contributor
Author
Yes, no change to command line output. |
zjswhhh
approved these changes
Aug 5, 2025
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
lolyu
approved these changes
Aug 7, 2025
YairRaviv
pushed a commit
to YairRaviv/sonic-utilities
that referenced
this pull request
Jan 12, 2026
…rs (sonic-net#4007) What I did Mux neighbors now use prefix-based routes based on changes from the following PR: sonic-net/sonic-swss#3722 Presence of route prefix for neighbors does not mean tunnel-route use anymore. Show command now uses nexthop type to distinguish between tunnel and normal neighbor route. How to verify it Verified output on hardware. Signed-off-by: Manas Kumar Mandal <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Mux neighbors now use prefix-based routes based on changes from the following PR:
sonic-net/sonic-swss#3722
Presence of route prefix for neighbors does not mean tunnel-route use anymore. Show command now uses nexthop type to distinguish between tunnel and normal neighbor route.
How I did it
How to verify it
Verified output on hardware.
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)