Add PFC historical statistics estimation to the PFCWD Orch#3533
Merged
prsunny merged 2 commits intosonic-net:masterfrom Aug 21, 2025
Merged
Add PFC historical statistics estimation to the PFCWD Orch#3533prsunny merged 2 commits intosonic-net:masterfrom
prsunny merged 2 commits intosonic-net:masterfrom
Conversation
peterbailey-arista
requested review from
kperumalbfn and
prsunny
as code owners
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
peterbailey-arista
force-pushed
the
pfc-stat-history-orch
branch
from
1ddec53 to
2ab6e9e
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
peterbailey-arista
force-pushed
the
pfc-stat-history-orch
branch
from
2ab6e9e to
faf6d09
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
peterbailey-arista
changed the title
Contributor
Author
|
/azpw run Azure.sonic-swss |
Collaborator
|
/AzurePipelines run Azure.sonic-swss |
|
Azure Pipelines successfully started running 1 pipeline(s). |
peterbailey-arista
force-pushed
the
pfc-stat-history-orch
branch
from
faf6d09 to
a5cbdd9
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azpw run Azure.sonic-buildimage |
Collaborator
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
Contributor
Author
|
/azpw run Azure.sonic-buildimage |
Collaborator
|
/AzurePipelines run Azure.sonic-buildimage |
|
No pipelines are associated with this pull request. |
Contributor
Author
|
/azpw run Azure.sonic-swss |
Collaborator
|
/AzurePipelines run Azure.sonic-swss |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
Contributor
Author
|
A reminder that this change goes alongside while the change is not dependent on these PRs, full functioning of the feature will require them as well 🙂 HLD has merged: sonic-net/SONiC#1903 |
Contributor
Author
|
@kperumalbfn @vmittal-msft @dgsudharsan Poking again for a review when possible. This is the final open PR for the PFC stat history feature. Thanks! |
vmittal-msft
approved these changes
Aug 14, 2025
Contributor
|
LGTM. Please rebase. Please share if this has been tested on ToR or chassis systems ? |
peterbailey-arista
force-pushed
the
pfc-stat-history-orch
branch
from
8b8fc63 to
8c681f7
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
Thanks Vineet, rebased. |
Contributor
Author
|
/azpw run Azure.sonic-swss |
Collaborator
|
/AzurePipelines run Azure.sonic-swss |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
@vmittal-msft I can't get the pipeline checks to start, can you help? The change was rebased and I tried the usual azpw command without success. Thanks! |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
The pfc_detect_broadcom.lua platform script can estimate PFC stat history when enabled. The PFCWD orchagent is updated to handle configuring history to enabled or disabled.
Coverage for pfc_stat_history toggle configuration.
peterbailey-arista
force-pushed
the
pfc-stat-history-orch
branch
from
8c681f7 to
808ce37
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
@vmittal-msft Rebased with passing pipeline runs! 😄 |
a114j0y
pushed a commit
to a114j0y/sonic-swss
that referenced
this pull request
Aug 28, 2025
…#3533) pfcwdorch has been updated to allow pfc historical statistic estimation. The orch allows the feature to be enabled or disabled and the pfc_detect_broadcom.lua script will perform the estimation and update counters_db for ports that tracking is enabled on. This implementation was made in accordance with comments from the community HLD review https://zoom.us/rec/share/jWkZRs51QULsDQvrSlm-5qC4OZ3gkG6RVdB2k_vqwgLcnezsaG1XtX5Aqk6xBYCZ.YMhHymrP4jbpkLbm HLD: sonic-net/SONiC#1903 What I did Edited the pfcwdorch and the pfc_detect_broadcom.lua to allow enable/disable-able PFC statistical history tracking. Why I did it Part of the PFC Historical Statistics Feature: sonic-net/SONiC#1904
a114j0y
added a commit
to a114j0y/sonic-swss
that referenced
this pull request
Aug 28, 2025
* upstream/master: [ssw][ha] set `SAI_HA_SCOPE_ATTR_ADMIN_STATE` (sonic-net#3841) Fix DPU restart message drop by Zmq lazy bind. (sonic-net#3837) [ssw][ha] consume new ha_scope fields (sonic-net#3825) Add PFC historical statistics estimation to the PFCWD Orch (sonic-net#3533)
a114j0y
added a commit
to a114j0y/sonic-swss
that referenced
this pull request
Aug 28, 2025
* upstream/master: [ssw][ha] set `SAI_HA_SCOPE_ATTR_ADMIN_STATE` (sonic-net#3841) Fix DPU restart message drop by Zmq lazy bind. (sonic-net#3837) [ssw][ha] consume new ha_scope fields (sonic-net#3825) Add PFC historical statistics estimation to the PFCWD Orch (sonic-net#3533)
a114j0y
pushed a commit
to a114j0y/sonic-swss
that referenced
this pull request
Aug 29, 2025
…#3533) pfcwdorch has been updated to allow pfc historical statistic estimation. The orch allows the feature to be enabled or disabled and the pfc_detect_broadcom.lua script will perform the estimation and update counters_db for ports that tracking is enabled on. This implementation was made in accordance with comments from the community HLD review https://zoom.us/rec/share/jWkZRs51QULsDQvrSlm-5qC4OZ3gkG6RVdB2k_vqwgLcnezsaG1XtX5Aqk6xBYCZ.YMhHymrP4jbpkLbm HLD: sonic-net/SONiC#1903 What I did Edited the pfcwdorch and the pfc_detect_broadcom.lua to allow enable/disable-able PFC statistical history tracking. Why I did it Part of the PFC Historical Statistics Feature: sonic-net/SONiC#1904
Janetxxx
pushed a commit
to Janetxxx/sonic-swss
that referenced
this pull request
Nov 10, 2025
…#3533) pfcwdorch has been updated to allow pfc historical statistic estimation. The orch allows the feature to be enabled or disabled and the pfc_detect_broadcom.lua script will perform the estimation and update counters_db for ports that tracking is enabled on. This implementation was made in accordance with comments from the community HLD review https://zoom.us/rec/share/jWkZRs51QULsDQvrSlm-5qC4OZ3gkG6RVdB2k_vqwgLcnezsaG1XtX5Aqk6xBYCZ.YMhHymrP4jbpkLbm HLD: sonic-net/SONiC#1903 What I did Edited the pfcwdorch and the pfc_detect_broadcom.lua to allow enable/disable-able PFC statistical history tracking. Why I did it Part of the PFC Historical Statistics Feature: sonic-net/SONiC#1904
balanokia
pushed a commit
to balanokia/sonic-swss
that referenced
this pull request
Nov 17, 2025
…#3533) pfcwdorch has been updated to allow pfc historical statistic estimation. The orch allows the feature to be enabled or disabled and the pfc_detect_broadcom.lua script will perform the estimation and update counters_db for ports that tracking is enabled on. This implementation was made in accordance with comments from the community HLD review https://zoom.us/rec/share/jWkZRs51QULsDQvrSlm-5qC4OZ3gkG6RVdB2k_vqwgLcnezsaG1XtX5Aqk6xBYCZ.YMhHymrP4jbpkLbm HLD: sonic-net/SONiC#1903 What I did Edited the pfcwdorch and the pfc_detect_broadcom.lua to allow enable/disable-able PFC statistical history tracking. Why I did it Part of the PFC Historical Statistics Feature: sonic-net/SONiC#1904
theasianpianist
pushed a commit
to theasianpianist/sonic-swss
that referenced
this pull request
Feb 4, 2026
…#3533) pfcwdorch has been updated to allow pfc historical statistic estimation. The orch allows the feature to be enabled or disabled and the pfc_detect_broadcom.lua script will perform the estimation and update counters_db for ports that tracking is enabled on. This implementation was made in accordance with comments from the community HLD review https://zoom.us/rec/share/jWkZRs51QULsDQvrSlm-5qC4OZ3gkG6RVdB2k_vqwgLcnezsaG1XtX5Aqk6xBYCZ.YMhHymrP4jbpkLbm HLD: sonic-net/SONiC#1903 What I did Edited the pfcwdorch and the pfc_detect_broadcom.lua to allow enable/disable-able PFC statistical history tracking. Why I did it Part of the PFC Historical Statistics Feature: sonic-net/SONiC#1904 Signed-off-by: Lawrence Lee <[email protected]>
baorliu
pushed a commit
to baorliu/sonic-swss
that referenced
this pull request
Feb 23, 2026
…#3533) pfcwdorch has been updated to allow pfc historical statistic estimation. The orch allows the feature to be enabled or disabled and the pfc_detect_broadcom.lua script will perform the estimation and update counters_db for ports that tracking is enabled on. This implementation was made in accordance with comments from the community HLD review https://zoom.us/rec/share/jWkZRs51QULsDQvrSlm-5qC4OZ3gkG6RVdB2k_vqwgLcnezsaG1XtX5Aqk6xBYCZ.YMhHymrP4jbpkLbm HLD: sonic-net/SONiC#1903 What I did Edited the pfcwdorch and the pfc_detect_broadcom.lua to allow enable/disable-able PFC statistical history tracking. Why I did it Part of the PFC Historical Statistics Feature: sonic-net/SONiC#1904 Signed-off-by: Baorong Liu <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pfcwdorch has been updated to allow pfc historical statistic estimation. The orch allows the feature to be enabled or disabled and the pfc_detect_broadcom.lua script will perform the estimation and update counters_db for ports that tracking is enabled on.
This implementation was made in accordance with comments from the community HLD review
https://zoom.us/rec/share/jWkZRs51QULsDQvrSlm-5qC4OZ3gkG6RVdB2k_vqwgLcnezsaG1XtX5Aqk6xBYCZ.YMhHymrP4jbpkLbm
HLD: sonic-net/SONiC#1903
What I did
Edited the pfcwdorch and the pfc_detect_broadcom.lua to allow enable/disable-able PFC statistical history tracking.
Why I did it
Part of the PFC Historical Statistics Feature: sonic-net/SONiC#1904
How I verified it
Details if related