[ssw][ha] set SAI_HA_SCOPE_ATTR_ADMIN_STATE #3841
Merged
prsunny merged 11 commits intosonic-net:masterfrom Aug 27, 2025
Merged
Conversation
…mmon re…" (sonic-net#3832) This reverts commit 9efc4c4. Revert "[swss] Install yang related debto align with latest libswsscommon requirement"
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| sai_object_id_t ha_scope_id = m_ha_scope_entries[key].ha_scope_id; | ||
|
|
||
| sai_attribute_t ha_scope_attr; | ||
| ha_scope_attr.id = SAI_HA_SCOPE_ATTR_ADMIN_STATE; |
There was a problem hiding this comment.
we need negate operation. disabled = true --> admin_state = false. Same comment in addHaScopeEntry
orchagent/dash/dashhaorch.cpp
Outdated
| } | ||
|
|
||
| m_ha_scope_entries[key].metadata.set_disabled(disabled); | ||
| SWSS_LOG_NOTICE("Set HA Scope admin state for %s to %d", key.c_str(), disabled); |
There was a problem hiding this comment.
disabled should be negated as well sonic the log is about admin state.
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yue-fred-gao
approved these changes
Aug 25, 2025
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
Hi @prsunny - please help review and merge. |
prsunny
approved these changes
Aug 27, 2025
Collaborator
prsunny
left a comment
prsunny
left a comment
There was a problem hiding this comment.
@oleksandrivantsiv , @vivekrnv for viz
Collaborator
|
@zjswhhh , could you please fix the description to follow the template? Need more details for the commit/merge message |
a114j0y
pushed a commit
to a114j0y/sonic-swss
that referenced
this pull request
Aug 28, 2025
What I did Take disabled field from HA_SCOPE_TABLE and set ha scope sai attribute SAI_HA_SCOPE_ATTR_ADMIN_STATE accordingly. https://github.com/opencomputeproject/SAI/blob/b925fc0f0fc8c620eea7d9dead7fc99e33b7b44e/experimental/saiexperimentaldashha.h#L310 Why I did it If admin state is not set to true, the state machine won't be activated in ASIC for DPU scope HA.
a114j0y
added a commit
to a114j0y/sonic-swss
that referenced
this pull request
Aug 28, 2025
* upstream/master: [ssw][ha] set `SAI_HA_SCOPE_ATTR_ADMIN_STATE` (sonic-net#3841) Fix DPU restart message drop by Zmq lazy bind. (sonic-net#3837) [ssw][ha] consume new ha_scope fields (sonic-net#3825) Add PFC historical statistics estimation to the PFCWD Orch (sonic-net#3533)
a114j0y
added a commit
to a114j0y/sonic-swss
that referenced
this pull request
Aug 28, 2025
* upstream/master: [ssw][ha] set `SAI_HA_SCOPE_ATTR_ADMIN_STATE` (sonic-net#3841) Fix DPU restart message drop by Zmq lazy bind. (sonic-net#3837) [ssw][ha] consume new ha_scope fields (sonic-net#3825) Add PFC historical statistics estimation to the PFCWD Orch (sonic-net#3533)
a114j0y
pushed a commit
to a114j0y/sonic-swss
that referenced
this pull request
Aug 29, 2025
What I did Take disabled field from HA_SCOPE_TABLE and set ha scope sai attribute SAI_HA_SCOPE_ATTR_ADMIN_STATE accordingly. https://github.com/opencomputeproject/SAI/blob/b925fc0f0fc8c620eea7d9dead7fc99e33b7b44e/experimental/saiexperimentaldashha.h#L310 Why I did it If admin state is not set to true, the state machine won't be activated in ASIC for DPU scope HA.
Collaborator
|
Cherry-pick PR to msft-202506: Azure/sonic-swss.msft#151 |
mssonicbld
added
Included in msft-202506 Branch
and removed
Created PR to msft-202506 Branch
labels
Janetxxx
pushed a commit
to Janetxxx/sonic-swss
that referenced
this pull request
Nov 10, 2025
What I did Take disabled field from HA_SCOPE_TABLE and set ha scope sai attribute SAI_HA_SCOPE_ATTR_ADMIN_STATE accordingly. https://github.com/opencomputeproject/SAI/blob/b925fc0f0fc8c620eea7d9dead7fc99e33b7b44e/experimental/saiexperimentaldashha.h#L310 Why I did it If admin state is not set to true, the state machine won't be activated in ASIC for DPU scope HA.
balanokia
pushed a commit
to balanokia/sonic-swss
that referenced
this pull request
Nov 17, 2025
What I did Take disabled field from HA_SCOPE_TABLE and set ha scope sai attribute SAI_HA_SCOPE_ATTR_ADMIN_STATE accordingly. https://github.com/opencomputeproject/SAI/blob/b925fc0f0fc8c620eea7d9dead7fc99e33b7b44e/experimental/saiexperimentaldashha.h#L310 Why I did it If admin state is not set to true, the state machine won't be activated in ASIC for DPU scope HA.
theasianpianist
pushed a commit
to theasianpianist/sonic-swss
that referenced
this pull request
Feb 4, 2026
What I did Take disabled field from HA_SCOPE_TABLE and set ha scope sai attribute SAI_HA_SCOPE_ATTR_ADMIN_STATE accordingly. https://github.com/opencomputeproject/SAI/blob/b925fc0f0fc8c620eea7d9dead7fc99e33b7b44e/experimental/saiexperimentaldashha.h#L310 Why I did it If admin state is not set to true, the state machine won't be activated in ASIC for DPU scope HA. Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
baorliu
pushed a commit
to baorliu/sonic-swss
that referenced
this pull request
Feb 23, 2026
What I did Take disabled field from HA_SCOPE_TABLE and set ha scope sai attribute SAI_HA_SCOPE_ATTR_ADMIN_STATE accordingly. https://github.com/opencomputeproject/SAI/blob/b925fc0f0fc8c620eea7d9dead7fc99e33b7b44e/experimental/saiexperimentaldashha.h#L310 Why I did it If admin state is not set to true, the state machine won't be activated in ASIC for DPU scope HA. Signed-off-by: Baorong Liu <96146196+baorliu@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Take disabled field from HA_SCOPE_TABLE and set ha scope sai attribute
SAI_HA_SCOPE_ATTR_ADMIN_STATEaccordingly.https://github.com/opencomputeproject/SAI/blob/b925fc0f0fc8c620eea7d9dead7fc99e33b7b44e/experimental/saiexperimentaldashha.h#L310
sign-off: Jing Zhang zhangjing@microsoft.com
Why I did it
If admin state is not set to true, the state machine won't be activated in ASIC for DPU scope HA.
How I verified it
Details if related