[test_mux] add sleep in test_NH by Ndancejic · Pull Request #2648 · sonic-net/sonic-swss

Ndancejic · 2023-01-31T18:00:30Z

What I did: added sleep after adding/removing neighbors in test_NH

Why I did it: resolve PR failures due to timing issues between adding/deleting neighbors and them being present in the asic_db

Signed-off-by: Nikola Dancejic ndancejic@microsoft.com

What I did: added sleep after adding/removing neighbors in test_NH Why I did it: resolve PR failures due to timing issues between adding/deleting neighbors and them being present in the asic_db Signed-off-by: Nikola Dancejic <ndancejic@microsoft.com>

nazariig · 2023-01-31T21:28:27Z

tests/test_mux.py


        self.add_neighbor(dvs, neigh_ip, mac)
        self.add_neighbor(dvs, neigh_ipv6, mac)
+        time.sleep(1)


@Ndancejic can we use a more robust synchronization approach here? Let's say waiting for added/removed entries in APP/ASIC DB?

updated it so we wait for db entries instead of sleeping

@Ndancejic thanks! Looks like the polling interval is too small, so PR keeps failing. Can you please have a look?

Signed-off-by: Nikola Dancejic <ndancejic@microsoft.com>

prsunny · 2023-02-02T04:11:51Z

@Ndancejic , could you please check the failure and merge this? Its blocking few other PRs.

@kevinskwang for viz.

Signed-off-by: Nikola Dancejic <ndancejic@microsoft.com>

nazariig · 2023-02-06T08:49:54Z

@prsunny this is a CI blocker. Can you please help to merge?

Update sonic-swss submodule pointer to include the following: * 7d223d3 Remove TODO comment which is no longer relevant ([sonic-net#2645](sonic-net/sonic-swss#2645)) * 02c2267 [test_mux] add sleep in test_NH ([sonic-net#2648](sonic-net/sonic-swss#2648)) * 8de52bf [EVPN]Handling race condition when remote VNI arrives before tunnel map entry ([sonic-net#2642](sonic-net/sonic-swss#2642)) * e99e2e4 [voq][chassis] Remove created ports from the default vlan. ([sonic-net#2607](sonic-net/sonic-swss#2607)) Signed-off-by: dprital <drorp@nvidia.com>

Update sonic-swss submodule pointer to include the following: * 7d223d3 Remove TODO comment which is no longer relevant ([#2645](sonic-net/sonic-swss#2645)) * 02c2267 [test_mux] add sleep in test_NH ([#2648](sonic-net/sonic-swss#2648)) * 8de52bf [EVPN]Handling race condition when remote VNI arrives before tunnel map entry ([#2642](sonic-net/sonic-swss#2642)) * e99e2e4 [voq][chassis] Remove created ports from the default vlan. ([#2607](sonic-net/sonic-swss#2607)) Signed-off-by: dprital <drorp@nvidia.com>

*Merge remote-tracking branch 'upstream/master' into dash (#2663) * Modify coppmgr mergeConfig to support preserving copp tables through reboot. (#2548) * Avoid aborting orchagent when setting TUNNEL attributes (#2591) * Handle Mac address 'none' (#2593) * Increase diff coverage to 80% (#2599) * Add missing parameter to on_switch_shutdown_request method. (#2567) * Add ZMQ based ProducerStateTable and CustomerStateTable. * Revert "[voq][chassis]Add show fabric counters port/queue commands (#2522)" (#2611) * Added new attributes for Vnet and Vxlan ecmp configurations. (#2584) * added support for monitoring, primary and adv_prefix and overlay_dmac. * [routesync] Fix for stale dynamic neighbor (#2553) * [MuxOrch] Enabling neighbor when adding in active state (#2601) * Changed the BFD default detect multiplier to 10x (#2614) * Remove TODO comments that are no longer relevant (#2622) * Fix issue #13341 ARP entry can be out of sync between kernel and APPL_DB if multiple updates are received from RTNL (#2619) * [refactor]Refactoring sai handle status (#2621) * Vxlan tunnel endpoint custom monitoring APPL DB table. (#2589) * added support for monitoring, primary and adv_prefix. changed filter_mac to overlay_dmac * Data Structures and code to write APP_DB VNET_MONITOR table entries for custom monitoring of Vxlan tunnel endpoints. * [bfdorch] add local discriminator to state DB (#2629) * [acl] Add new ACL key BTH_OPCODE and AETH_SYNDROME (#2617) * [voq][chassis] Remove created ports from the default vlan. (#2607) * [EVPN]Handling race condition when remote VNI arrives before tunnel map entry (#2642) *Added check in remote VNI add to ensure vxlan tunnel map is created before adding the remote end point. * [test_mux] add sleep in test_NH (#2648) * [autoneg]Fixing adv interface types to be set when AN is disabled (#2638) * [hash]: Add UT infra. (#2660) *Added UT infra for Generic Hash feature *Aligned PBH tests with Generic Hash UT infra * [sai_failure_dump]Invoking dump during SAI failure (#2644) * [ResponsePublisher] add pipeline support (#2511) * [dash] Fix compilation issue caused by missing include.

* [test_mux] add sleep in test_NH What I did: added sleep after adding/removing neighbors in test_NH Why I did it: resolve PR failures due to timing issues between adding/deleting neighbors and them being present in the asic_db Signed-off-by: Nikola Dancejic <ndancejic@microsoft.com>

StormLiangMS · 2023-03-07T02:21:26Z

@Ndancejic cherry pick to 202211 conflict, could you raise PR to fix?

Ndancejic · 2023-03-07T18:25:02Z

@Ndancejic cherry pick to 202211 conflict, could you raise PR to fix?

#2694

) *Merge remote-tracking branch 'upstream/master' into dash (sonic-net#2663) * Modify coppmgr mergeConfig to support preserving copp tables through reboot. (sonic-net#2548) * Avoid aborting orchagent when setting TUNNEL attributes (sonic-net#2591) * Handle Mac address 'none' (sonic-net#2593) * Increase diff coverage to 80% (sonic-net#2599) * Add missing parameter to on_switch_shutdown_request method. (sonic-net#2567) * Add ZMQ based ProducerStateTable and CustomerStateTable. * Revert "[voq][chassis]Add show fabric counters port/queue commands (sonic-net#2522)" (sonic-net#2611) * Added new attributes for Vnet and Vxlan ecmp configurations. (sonic-net#2584) * added support for monitoring, primary and adv_prefix and overlay_dmac. * [routesync] Fix for stale dynamic neighbor (sonic-net#2553) * [MuxOrch] Enabling neighbor when adding in active state (sonic-net#2601) * Changed the BFD default detect multiplier to 10x (sonic-net#2614) * Remove TODO comments that are no longer relevant (sonic-net#2622) * Fix issue #13341 ARP entry can be out of sync between kernel and APPL_DB if multiple updates are received from RTNL (sonic-net#2619) * [refactor]Refactoring sai handle status (sonic-net#2621) * Vxlan tunnel endpoint custom monitoring APPL DB table. (sonic-net#2589) * added support for monitoring, primary and adv_prefix. changed filter_mac to overlay_dmac * Data Structures and code to write APP_DB VNET_MONITOR table entries for custom monitoring of Vxlan tunnel endpoints. * [bfdorch] add local discriminator to state DB (sonic-net#2629) * [acl] Add new ACL key BTH_OPCODE and AETH_SYNDROME (sonic-net#2617) * [voq][chassis] Remove created ports from the default vlan. (sonic-net#2607) * [EVPN]Handling race condition when remote VNI arrives before tunnel map entry (sonic-net#2642) *Added check in remote VNI add to ensure vxlan tunnel map is created before adding the remote end point. * [test_mux] add sleep in test_NH (sonic-net#2648) * [autoneg]Fixing adv interface types to be set when AN is disabled (sonic-net#2638) * [hash]: Add UT infra. (sonic-net#2660) *Added UT infra for Generic Hash feature *Aligned PBH tests with Generic Hash UT infra * [sai_failure_dump]Invoking dump during SAI failure (sonic-net#2644) * [ResponsePublisher] add pipeline support (sonic-net#2511) * [dash] Fix compilation issue caused by missing include.

* [test_mux] add sleep in test_NH What I did: added sleep after adding/removing neighbors in test_NH Why I did it: resolve PR failures due to timing issues between adding/deleting neighbors and them being present in the asic_db Signed-off-by: Nikola Dancejic <ndancejic@microsoft.com>

[test_mux] add sleep in test_NH

bfd2130

What I did: added sleep after adding/removing neighbors in test_NH Why I did it: resolve PR failures due to timing issues between adding/deleting neighbors and them being present in the asic_db Signed-off-by: Nikola Dancejic <ndancejic@microsoft.com>

Ndancejic requested a review from prsunny as a code owner January 31, 2023 18:00

prsunny previously approved these changes Jan 31, 2023

View reviewed changes

nazariig reviewed Jan 31, 2023

View reviewed changes

waiting for asic entries

190754a

Signed-off-by: Nikola Dancejic <ndancejic@microsoft.com>

Ndancejic dismissed prsunny’s stale review via 190754a January 31, 2023 23:47

prsunny previously approved these changes Feb 1, 2023

View reviewed changes

fixing errors

81d1f40

Signed-off-by: Nikola Dancejic <ndancejic@microsoft.com>

Ndancejic dismissed prsunny’s stale review via 81d1f40 February 2, 2023 21:36

fixing more errors

9230dfd

Signed-off-by: Nikola Dancejic <ndancejic@microsoft.com>

skbarista mentioned this pull request Feb 3, 2023

swss: Fix Invalid port oid messages generated because of voq counters. #2632

Closed

nazariig approved these changes Feb 4, 2023

View reviewed changes

prsunny approved these changes Feb 6, 2023

View reviewed changes

prsunny merged commit 02c2267 into sonic-net:master Feb 6, 2023

dprital mentioned this pull request Feb 7, 2023

[submodule] Advance sonic-swss pointer sonic-net/sonic-buildimage#13705

Merged

8 tasks

prsunny added Request for 202205 Branch Request for 202211 Branch labels Mar 6, 2023

vmittal-msft mentioned this pull request Mar 6, 2023

[Ci] Support to build sonic-swss-common #2685

Merged

yxieca added the Included in 202205 Branch label Mar 6, 2023

StormLiangMS added the Cherry Pick Conflict_202211 label Mar 7, 2023

Ndancejic mentioned this pull request Mar 7, 2023

Enabling neighbor when adding in active state and adding the test_NH mux test to 202211 #2694

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[test_mux] add sleep in test_NH#2648

[test_mux] add sleep in test_NH#2648
prsunny merged 4 commits intosonic-net:masterfrom
Ndancejic:sleep

Ndancejic commented Jan 31, 2023

Uh oh!

nazariig Jan 31, 2023

Uh oh!

Ndancejic Jan 31, 2023

Uh oh!

nazariig Feb 1, 2023

Uh oh!

prsunny commented Feb 2, 2023

Uh oh!

nazariig commented Feb 6, 2023

Uh oh!

StormLiangMS commented Mar 7, 2023

Uh oh!

Ndancejic commented Mar 7, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

Ndancejic commented Jan 31, 2023

Uh oh!

nazariig Jan 31, 2023

Choose a reason for hiding this comment

Uh oh!

Ndancejic Jan 31, 2023

Choose a reason for hiding this comment

Uh oh!

nazariig Feb 1, 2023

Choose a reason for hiding this comment

Uh oh!

prsunny commented Feb 2, 2023

Uh oh!

nazariig commented Feb 6, 2023

Uh oh!

StormLiangMS commented Mar 7, 2023

Uh oh!

Ndancejic commented Mar 7, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants