Skip to content

[Ci] Support to build sonic-swss-common#2685

Merged
prsunny merged 9 commits intosonic-net:202205from
xumia:fix-build-202205
Mar 7, 2023
Merged

[Ci] Support to build sonic-swss-common#2685
prsunny merged 9 commits intosonic-net:202205from
xumia:fix-build-202205

Conversation

@xumia
Copy link
Collaborator

@xumia xumia commented Mar 2, 2023

What I did
[Ci] Support to build sonic-swss-common

Why I did it
It is to improve the chance to build successful rate on sonic-swss.
It removes the dependency of the build artifacts of sonic-swss-common in sonic-swss, always uses the latest code of the sonic-swss-common to build it.

How I verified it

Details if related

@xumia xumia added the ci label Mar 2, 2023
@xumia xumia requested a review from prsunny as a code owner March 2, 2023 09:27
@vmittal-msft
Copy link
Contributor

@theasianpianist we need this urgently for #2618 to go in. #2618 is needed for pilot testing on chassis.

@theasianpianist
Copy link
Contributor

Why do we want to start building swss-common instead of downloading artifacts?

@vmittal-msft
Copy link
Contributor

Let me copy you on the email thread. sonic-swss compilation is failing due to sonic-swss-common package doesn't seem to be latest enough for this to compile. So why do we have such dependency ? and not directly compile to avoid such issues.

@xumia xumia marked this pull request as ready for review March 2, 2023 23:27
@vmittal-msft
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@xumia
Copy link
Collaborator Author

xumia commented Mar 6, 2023

Why do we want to start building swss-common instead of downloading artifacts?

The build sonic-swss-common is failed in test stage, it blocks the sonic-swss to use the lastest code, and the sonic-swss cannot be built successfully.

@xumia
Copy link
Collaborator Author

xumia commented Mar 6, 2023

Why do we want to start building swss-common instead of downloading artifacts?

The build sonic-swss-common is failed in test stage, it blocks the sonic-swss to use the lastest code, and the sonic-swss cannot be built successfully. It reduces the dependency to wait for the result of another pipeline.

I consider the two aspects as below, any other thoughts? @theasianpianist

  1. Is the cost to build the sonic-swss-common low. (5min)
  2. Do we want to use the latest sonic-swss-common in sonic-swss?

@vmittal-msft vmittal-msft requested a review from yxieca March 6, 2023 17:03
@vmittal-msft
Copy link
Contributor

As per @prsunny, this need to be included for 202205.
#2648

@prsunny
Copy link
Collaborator

prsunny commented Mar 6, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@prsunny
Copy link
Collaborator

prsunny commented Mar 7, 2023

@theasianpianist , merging to unblock PR builds. Lets address any concerns as future commits.

@prsunny prsunny merged commit 89ae53e into sonic-net:202205 Mar 7, 2023
@prsunny prsunny linked an issue Mar 7, 2023 that may be closed by this pull request
xumia added a commit to xumia/sonic-swss that referenced this pull request Jun 28, 2023
* [Ci] Support to build sonic-swss-common
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compile error in sonic-swss/orchagent/orchdaemon.cpp for 202205 branch

4 participants