[voq][chassis] Remove created ports from the default vlan. by arista-nwolfe · Pull Request #2607 · sonic-net/sonic-swss

arista-nwolfe · 2023-01-10T15:48:11Z

Added a test case in test_virtual_chassis.py

Signed-off-by: Nathan Wolfe [email protected]

What I did
-Remove newly created ports from the default vlan on VOQ systems.
-Add a test to confirm we're executing removeDefaultVlanMembers when a new port is added on a VOQ system.

Why I did it
-When a port is created via create_port SAI call the port may be added to the default vlan, this is undesired.

How I verified it
-On a 7800R3AK-36DM2 linecard with multiple 400G ports I verified that the TX_TAG_ENABLE field in ETPPC_EDITING_PER_PORT_TABLE was not set for and ports. This confirms that no port is a member of any vlan

Note: I believe we want this change backported to 202205

Added a test case in test_virtual_chassis.py Signed-off-by: Nathan Wolfe <[email protected]>

linux-foundation-easycla · 2023-01-10T15:48:15Z

The committers listed above are authorized under a signed CLA.

✅ login: arista-nwolfe (3c94ae4)

kenneth-arista · 2023-01-11T18:00:36Z

@arlakshm @rlhui

arlakshm · 2023-01-11T18:45:27Z

/Azp run Azure.sonic-swss

azure-pipelines · 2023-01-11T18:45:38Z

Azure Pipelines successfully started running 1 pipeline(s).

arlakshm · 2023-01-17T23:09:41Z

/Azp run Azure.sonic-swss

azure-pipelines · 2023-01-17T23:09:50Z

Azure Pipelines successfully started running 1 pipeline(s).

arista-nwolfe · 2023-01-19T18:23:51Z

/Azp run Azure.sonic-swss

arista-nwolfe · 2023-01-19T21:30:33Z

/azpw run Azure.sonic-swss

mssonicbld · 2023-01-19T21:30:35Z

/AzurePipelines run Azure.sonic-swss

azure-pipelines · 2023-01-19T21:30:45Z

Azure Pipelines successfully started running 1 pipeline(s).

arlakshm · 2023-01-23T20:07:47Z

/Azp run Azure.sonic-swss

azure-pipelines · 2023-01-23T20:07:57Z

Azure Pipelines successfully started running 1 pipeline(s).

arista-nwolfe · 2023-01-23T23:08:44Z

Latest sonic-swss failures were on unit tests I didn't change:
test_drop_counters.py:688: AssertionError
test_drop_counters.py:109: AssertionError

@arlakshm should we rekick sonic-swss again?

arlakshm · 2023-01-23T23:50:58Z

/Azp run Azure.sonic-swss

azure-pipelines · 2023-01-23T23:51:08Z

Azure Pipelines successfully started running 1 pipeline(s).

arista-nwolfe · 2023-01-24T16:32:00Z

Failures again were unrelated to my changes:

test_mux.py::TestMuxTunnel::test_NH FAILED [ 18%]
test_mux.py::TestMuxTunnel::test_neighbor_miss[standby->ping_serv->active->resolve_entry->delete_entry-IPv4] FAILED [ 24%]
test_mux.py::TestMuxTunnel::test_neighbor_miss[standby->ping_serv->active->resolve_entry->delete_entry-IPv6] FAILED [ 24%]
test_mux.py::TestMuxTunnel::test_neighbor_miss[standby->ping_serv->resolve_entry->active->delete_entry-IPv4] FAILED [ 25%]
test_mux.py::TestMuxTunnel::test_neighbor_miss[standby->ping_serv->resolve_entry->active->delete_entry-IPv6] FAILED [ 26%]
test_mux.py::TestMuxTunnel::test_neighbor_miss[standby->ping_serv->delete_entry-IPv4] FAILED [ 26%]
test_mux.py::TestMuxTunnel::test_neighbor_miss[standby->ping_serv->delete_entry-IPv6] FAILED [ 27%]
test_mux.py::TestMuxTunnel::test_neighbor_miss[standby->ping_neigh->resolve_entry->active->delete_entry-IPv4] FAILED [ 28%]
test_mux.py::TestMuxTunnel::test_neighbor_miss[standby->ping_neigh->resolve_entry->active->delete_entry-IPv6] FAILED [ 28%]
test_mux.py::TestMuxTunnel::test_neighbor_miss[active->ping_neigh->resolve_entry->standby->delete_entry-IPv4] FAILED [ 29%]
test_mux.py::TestMuxTunnel::test_neighbor_miss[active->ping_neigh->resolve_entry->standby->delete_entry-IPv6] FAILED [ 30%]
test_mux.py::TestMuxTunnel::test_neighbor_miss[ping_neigh->delete_entry-IPv4] FAILED [ 30%]
test_mux.py::TestMuxTunnel::test_neighbor_miss[ping_neigh->delete_entry-IPv6] FAILED [ 31%]
test_mux.py::TestMuxTunnel::test_soc_ip FAILED [ 32%]

Rescheduling sonic-swss

arista-nwolfe · 2023-01-24T16:32:13Z

/azpw run Azure.sonic-swss

mssonicbld · 2023-01-24T16:32:15Z

/AzurePipelines run Azure.sonic-swss

azure-pipelines · 2023-01-24T16:32:26Z

Azure Pipelines successfully started running 1 pipeline(s).

prsunny · 2023-01-24T16:37:24Z

@Ndancejic , can you please take a look at this failures when possible.

Ndancejic · 2023-01-24T21:59:09Z

the mux failures are a timing issue, the check fails because the sai doesn't have time to complete the update before the test checks the nh id. Because of this, the cleanup of that test doesn't happen and leaves some unexpected neighbors left over which causes the subsequent failures. I can see that the sairedis records show the correct Nexthop id.

2023-01-24.01:54:10.975241|s|SAI_OBJECT_TYPE_ROUTE_ENTRY:{"dest":"2023::/64","switch_id":"oid:0x21000000000000","vr":"oid:0x3000000000022"}|SAI_ROUTE_ENTRY_ATTR_NEXT_HOP_ID=oid:0x40000000006a3

I can add a sleep to prevent this from happening in the future

arlakshm · 2023-01-24T22:10:55Z

/Azp run Azure.sonic-swss

arista-nwolfe · 2023-02-10T18:39:23Z

Created #2664 for 202211 branch

Signed-off-by: Nazarii Hnydyn <[email protected]>

*Merge remote-tracking branch 'upstream/master' into dash (#2663) * Modify coppmgr mergeConfig to support preserving copp tables through reboot. (#2548) * Avoid aborting orchagent when setting TUNNEL attributes (#2591) * Handle Mac address 'none' (#2593) * Increase diff coverage to 80% (#2599) * Add missing parameter to on_switch_shutdown_request method. (#2567) * Add ZMQ based ProducerStateTable and CustomerStateTable. * Revert "[voq][chassis]Add show fabric counters port/queue commands (#2522)" (#2611) * Added new attributes for Vnet and Vxlan ecmp configurations. (#2584) * added support for monitoring, primary and adv_prefix and overlay_dmac. * [routesync] Fix for stale dynamic neighbor (#2553) * [MuxOrch] Enabling neighbor when adding in active state (#2601) * Changed the BFD default detect multiplier to 10x (#2614) * Remove TODO comments that are no longer relevant (#2622) * Fix issue #13341 ARP entry can be out of sync between kernel and APPL_DB if multiple updates are received from RTNL (#2619) * [refactor]Refactoring sai handle status (#2621) * Vxlan tunnel endpoint custom monitoring APPL DB table. (#2589) * added support for monitoring, primary and adv_prefix. changed filter_mac to overlay_dmac * Data Structures and code to write APP_DB VNET_MONITOR table entries for custom monitoring of Vxlan tunnel endpoints. * [bfdorch] add local discriminator to state DB (#2629) * [acl] Add new ACL key BTH_OPCODE and AETH_SYNDROME (#2617) * [voq][chassis] Remove created ports from the default vlan. (#2607) * [EVPN]Handling race condition when remote VNI arrives before tunnel map entry (#2642) *Added check in remote VNI add to ensure vxlan tunnel map is created before adding the remote end point. * [test_mux] add sleep in test_NH (#2648) * [autoneg]Fixing adv interface types to be set when AN is disabled (#2638) * [hash]: Add UT infra. (#2660) *Added UT infra for Generic Hash feature *Aligned PBH tests with Generic Hash UT infra * [sai_failure_dump]Invoking dump during SAI failure (#2644) * [ResponsePublisher] add pipeline support (#2511) * [dash] Fix compilation issue caused by missing include.

Signed-off-by: Nazarii Hnydyn <[email protected]>

) *Merge remote-tracking branch 'upstream/master' into dash (sonic-net#2663) * Modify coppmgr mergeConfig to support preserving copp tables through reboot. (sonic-net#2548) * Avoid aborting orchagent when setting TUNNEL attributes (sonic-net#2591) * Handle Mac address 'none' (sonic-net#2593) * Increase diff coverage to 80% (sonic-net#2599) * Add missing parameter to on_switch_shutdown_request method. (sonic-net#2567) * Add ZMQ based ProducerStateTable and CustomerStateTable. * Revert "[voq][chassis]Add show fabric counters port/queue commands (sonic-net#2522)" (sonic-net#2611) * Added new attributes for Vnet and Vxlan ecmp configurations. (sonic-net#2584) * added support for monitoring, primary and adv_prefix and overlay_dmac. * [routesync] Fix for stale dynamic neighbor (sonic-net#2553) * [MuxOrch] Enabling neighbor when adding in active state (sonic-net#2601) * Changed the BFD default detect multiplier to 10x (sonic-net#2614) * Remove TODO comments that are no longer relevant (sonic-net#2622) * Fix issue #13341 ARP entry can be out of sync between kernel and APPL_DB if multiple updates are received from RTNL (sonic-net#2619) * [refactor]Refactoring sai handle status (sonic-net#2621) * Vxlan tunnel endpoint custom monitoring APPL DB table. (sonic-net#2589) * added support for monitoring, primary and adv_prefix. changed filter_mac to overlay_dmac * Data Structures and code to write APP_DB VNET_MONITOR table entries for custom monitoring of Vxlan tunnel endpoints. * [bfdorch] add local discriminator to state DB (sonic-net#2629) * [acl] Add new ACL key BTH_OPCODE and AETH_SYNDROME (sonic-net#2617) * [voq][chassis] Remove created ports from the default vlan. (sonic-net#2607) * [EVPN]Handling race condition when remote VNI arrives before tunnel map entry (sonic-net#2642) *Added check in remote VNI add to ensure vxlan tunnel map is created before adding the remote end point. * [test_mux] add sleep in test_NH (sonic-net#2648) * [autoneg]Fixing adv interface types to be set when AN is disabled (sonic-net#2638) * [hash]: Add UT infra. (sonic-net#2660) *Added UT infra for Generic Hash feature *Aligned PBH tests with Generic Hash UT infra * [sai_failure_dump]Invoking dump during SAI failure (sonic-net#2644) * [ResponsePublisher] add pipeline support (sonic-net#2511) * [dash] Fix compilation issue caused by missing include.

…#2607) Signed-off-by: Nathan Wolfe [email protected] What I did -Remove newly created ports from the default vlan on VOQ systems. -Add a test to confirm we're executing removeDefaultVlanMembers when a new port is added on a VOQ system. Why I did it -When a port is created via create_port SAI call the port may be added to the default vlan, this is undesired. How I verified it -On a 7800R3AK-36DM2 linecard with multiple 400G ports I verified that the TX_TAG_ENABLE field in ETPPC_EDITING_PER_PORT_TABLE was not set for and ports. This confirms that no port is a member of any vlan

[voq][chassis] Remove created ports from the default vlan.

3c94ae4

Added a test case in test_virtual_chassis.py Signed-off-by: Nathan Wolfe <[email protected]>

arista-nwolfe requested review from abdosi, judyjoseph and prsunny as code owners January 10, 2023 15:48

Added wait for ports to be removed/added

3e49b57

rlhui assigned arlakshm Jan 19, 2023

rlhui added chassis Request for 202205 Branch labels Jan 19, 2023

nazariig added a commit to nazariig/sonic-swss that referenced this pull request Feb 15, 2023

[ppi]: Backport sonic-net#2607.

6ea134b

Signed-off-by: Nazarii Hnydyn <[email protected]>

StormLiangMS added the Approved for 202211 Branch label Mar 7, 2023

nazariig added a commit to nazariig/sonic-swss that referenced this pull request Mar 10, 2023

[ppi]: Backport sonic-net#2607.

6eb558b

Signed-off-by: Nazarii Hnydyn <[email protected]>

nazariig added a commit to nazariig/sonic-swss that referenced this pull request Mar 10, 2023

[ppi]: Backport sonic-net#2607.

ae8a1bd

Signed-off-by: Nazarii Hnydyn <[email protected]>

nazariig added a commit to nazariig/sonic-swss that referenced this pull request Apr 7, 2023

[ppi]: Backport sonic-net#2607.

594532c

Signed-off-by: Nazarii Hnydyn <[email protected]>

nazariig added a commit to nazariig/sonic-swss that referenced this pull request Apr 13, 2023

[ppi]: Backport sonic-net#2607.

2a541cb

Signed-off-by: Nazarii Hnydyn <[email protected]>

nazariig added a commit to nazariig/sonic-swss that referenced this pull request Apr 24, 2023

[ppi]: Backport sonic-net#2607.

5c69144

Signed-off-by: Nazarii Hnydyn <[email protected]>

nazariig added a commit to nazariig/sonic-swss that referenced this pull request Apr 26, 2023

[ppi]: Backport sonic-net#2607.

c4aff9d

Signed-off-by: Nazarii Hnydyn <[email protected]>

nazariig added a commit to nazariig/sonic-swss that referenced this pull request May 4, 2023

[ppi]: Backport sonic-net#2607.

06b8894

Signed-off-by: Nazarii Hnydyn <[email protected]>

nazariig added a commit to nazariig/sonic-swss that referenced this pull request May 6, 2023

[ppi]: Backport sonic-net#2607.

170f2f8

Signed-off-by: Nazarii Hnydyn <[email protected]>

nazariig added a commit to nazariig/sonic-swss that referenced this pull request May 9, 2023

[ppi]: Backport sonic-net#2607.

f6e2273

Signed-off-by: Nazarii Hnydyn <[email protected]>

nazariig added a commit to nazariig/sonic-swss that referenced this pull request May 12, 2023

[ppi]: Backport sonic-net#2607.

526f152

Signed-off-by: Nazarii Hnydyn <[email protected]>

nazariig added a commit to nazariig/sonic-swss that referenced this pull request May 12, 2023

[ppi]: Backport sonic-net#2607.

61182e2

Signed-off-by: Nazarii Hnydyn <[email protected]>

nazariig added a commit to nazariig/sonic-swss that referenced this pull request May 15, 2023

[ppi]: Backport sonic-net#2607.

3a2a6ee

Signed-off-by: Nazarii Hnydyn <[email protected]>

nazariig added a commit to nazariig/sonic-swss that referenced this pull request May 25, 2023

[ppi]: Backport sonic-net#2607.

3778c25

Signed-off-by: Nazarii Hnydyn <[email protected]>

nazariig added a commit to nazariig/sonic-swss that referenced this pull request May 29, 2023

[ppi]: Backport sonic-net#2607.

3f350f4

Signed-off-by: Nazarii Hnydyn <[email protected]>

nazariig added a commit to nazariig/sonic-swss that referenced this pull request May 30, 2023

[ppi]: Backport sonic-net#2607.

bfc7dd7

Signed-off-by: Nazarii Hnydyn <[email protected]>

nazariig added a commit to nazariig/sonic-swss that referenced this pull request Jun 1, 2023

[ppi]: Backport sonic-net#2607.

4812e9d

Signed-off-by: Nazarii Hnydyn <[email protected]>

nazariig added a commit to nazariig/sonic-swss that referenced this pull request Jun 14, 2023

[ppi]: Backport sonic-net#2607.

8dd403a

Signed-off-by: Nazarii Hnydyn <[email protected]>

nazariig added a commit to nazariig/sonic-swss that referenced this pull request Jun 14, 2023

[ppi]: Backport sonic-net#2607.

7af5d9e

Signed-off-by: Nazarii Hnydyn <[email protected]>

nazariig added a commit to nazariig/sonic-swss that referenced this pull request Jun 30, 2023

[ppi]: Backport sonic-net#2607.

20976f5

Signed-off-by: Nazarii Hnydyn <[email protected]>

nazariig added a commit to nazariig/sonic-swss that referenced this pull request Jul 5, 2023

[ppi]: Backport sonic-net#2607.

a254bd1

Signed-off-by: Nazarii Hnydyn <[email protected]>

nazariig added a commit to nazariig/sonic-swss that referenced this pull request Jul 11, 2023

[ppi]: Backport sonic-net#2607.

2648c59

Signed-off-by: Nazarii Hnydyn <[email protected]>

nazariig added a commit to nazariig/sonic-swss that referenced this pull request Jul 20, 2023

[ppi]: Backport sonic-net#2607.

ea5077a

Signed-off-by: Nazarii Hnydyn <[email protected]>

Conversation

arista-nwolfe commented Jan 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

linux-foundation-easycla bot commented Jan 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kenneth-arista commented Jan 11, 2023

Uh oh!

arlakshm commented Jan 11, 2023

Uh oh!

azure-pipelines bot commented Jan 11, 2023

Uh oh!

arlakshm commented Jan 17, 2023

Uh oh!

azure-pipelines bot commented Jan 17, 2023

Uh oh!

arista-nwolfe commented Jan 19, 2023

Uh oh!

arista-nwolfe commented Jan 19, 2023

Uh oh!

mssonicbld commented Jan 19, 2023

Uh oh!

azure-pipelines bot commented Jan 19, 2023

Uh oh!

arlakshm commented Jan 23, 2023

Uh oh!

azure-pipelines bot commented Jan 23, 2023

Uh oh!

arista-nwolfe commented Jan 23, 2023

Uh oh!

arlakshm commented Jan 23, 2023

Uh oh!

azure-pipelines bot commented Jan 23, 2023

Uh oh!

arista-nwolfe commented Jan 24, 2023

Uh oh!

arista-nwolfe commented Jan 24, 2023

Uh oh!

mssonicbld commented Jan 24, 2023

Uh oh!

azure-pipelines bot commented Jan 24, 2023

Uh oh!

prsunny commented Jan 24, 2023

Uh oh!

Ndancejic commented Jan 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

arlakshm commented Jan 24, 2023

Uh oh!

arista-nwolfe commented Feb 10, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

arista-nwolfe commented Jan 10, 2023 •

edited

Loading

linux-foundation-easycla bot commented Jan 10, 2023 •

edited

Loading

Ndancejic commented Jan 24, 2023 •

edited

Loading