[pytest]: Re-use DVS container when possible#1816
[pytest]: Re-use DVS container when possible#1816theasianpianist merged 24 commits intosonic-net:masterfrom
Conversation
- If the fake_platform does not change between test modules, re-use the same DVS container Signed-off-by: Lawrence Lee <[email protected]>
|
This pull request introduces 1 alert when merging 9706eaa into 64e33b3 - view on LGTM.com new alerts:
|
|
/Azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/Azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@prsunny From test result, if vs docker restart, the gcda info will loss, can change to keep docker active? |
Signed-off-by: Lawrence Lee <[email protected]>
|
This pull request introduces 1 alert when merging e3b6e70 into c805021 - view on LGTM.com new alerts:
|
|
/Azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Lawrence Lee <[email protected]>
|
This pull request introduces 1 alert when merging 6d2ecd5 into ec104c1 - view on LGTM.com new alerts:
|
|
@theasianpianist https://dev.azure.com/mssonic/build/_build/results?buildId=26673&view=results test only pass 60%, help check。 |
|
/Azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Lawrence Lee <[email protected]>
|
This pull request introduces 1 alert when merging 8074c39 into df96059 - view on LGTM.com new alerts:
|
|
@theasianpianist help fix lgtm, thanks! and test time reach to 3h, please check https://dev.azure.com/mssonic/build/_build/results?buildId=27958&view=logs&s=859b8d9a-8fd6-5a5c-6f5e-f84f1990894e, other thing are all fine! |
|
This pull request introduces 1 alert when merging 88078ed into df96059 - view on LGTM.com new alerts:
|
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@theasianpianist , can you please take a look at the failure? |
|
@theasianpianist https://dev.azure.com/mssonic/build/_build/results?buildId=34436&view=results result seems fine, please help fix LGTM, thanks! |
Signed-off-by: Lawrence Lee <[email protected]>
|
This pull request introduces 1 alert when merging f8706df into 254bc12 - view on LGTM.com new alerts:
|
Signed-off-by: Lawrence Lee <[email protected]>
|
This pull request introduces 1 alert when merging 386b15d into 8cf355d - view on LGTM.com new alerts:
|
Signed-off-by: Lawrence Lee <[email protected]>
|
This pull request introduces 2 alerts when merging 033d699 into d01524d - view on LGTM.com new alerts:
|
Signed-off-by: Lawrence Lee <[email protected]>
|
@pettershao-ragilenetworks finally able to achieve 100% test pass rate, can you check if the latest changes work with gcov? Unfortunately the LGTM alert for the unused local variable is a false positive and for some reason the suppression comment I added is not taking effect. |
|
This pull request introduces 1 alert when merging 97489fc into d01524d - view on LGTM.com new alerts:
|
|
/Azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/Azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/Azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/Azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/Azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
- If the fake_platform does not change between test modules, re-use the same DVS container (but still restart it between modules and do some cleanup/re-init to ensure a consistent start state for each test module) - Add a CLI option --force-recreate-dvs to revert to the previous behavior of creating a new DVS per test module Signed-off-by: Lawrence Lee <[email protected]>
This reverts commit a031542.
[Submodule advance sonic-swss] Include below commits to master image: Cache routes for single nexthop for faster retrieval sonic-net/sonic-swss#1922 Reduce route count for route perf test (sonic-net/sonic-swss#1928) [pytest]: Re-use DVS container when possible (sonic-net/sonic-swss#1816) [PORTSYNCD] when no ports on config db on init, continue and set Port… (sonic-net/sonic-swss#1861) [gearbox] Add gearbox unit test (sonic-net/sonic-swss#1920) Reverted skipped test_buffer_dynamic test cases (sonic-net/sonic-swss#1937) Revert "[buffer orch] Bugfix: Don't query counter SAI_BUFFER_POOL_STA… (sonic-net/sonic-swss#1945)
- If the fake_platform does not change between test modules, re-use the same DVS container (but still restart it between modules and do some cleanup/re-init to ensure a consistent start state for each test module) - Add a CLI option --force-recreate-dvs to revert to the previous behavior of creating a new DVS per test module Signed-off-by: Lawrence Lee <[email protected]>
3 participants
Signed-off-by: Lawrence Lee [email protected]
What I did
--force-recreate-dvsto revert to the previous behavior of creating a new DVS per test moduleWhy I did it
How I verified it
docker psthat the DVS container being used is not newly created.Details if related