Skip to content

[gearbox] Add gearbox unit test#1920

Merged
jimmyzhai merged 2 commits intosonic-net:masterfrom
jimmyzhai:test_gearbox
Sep 30, 2021
Merged

[gearbox] Add gearbox unit test#1920
jimmyzhai merged 2 commits intosonic-net:masterfrom
jimmyzhai:test_gearbox

Conversation

@jimmyzhai
Copy link
Contributor

What I did

  • Add test_gearbox
  • Add DVS_ENV for module specific dvs env variables

Why I did it

How I verified it

Details if related

@jimmyzhai jimmyzhai requested a review from prsunny as a code owner September 21, 2021 04:07
@jimmyzhai jimmyzhai requested a review from lguohan September 21, 2021 04:08
imgname: str = None,
keeptb: bool = False,
fakeplatform: str = None,
env: list = [],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the reason to change to a list?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

List type, in case multiple environment variables

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parameter environment of self.client.containers.run is a list type

self.phys[i]["lanes"] = {}
for j in lane_list:
(status, fvs) = lane_table.get(j)
assert status == True
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to wait here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not need. In dvs creation, it has verified all services ready. The table GEARBOX_TABLE in APP_DB has been created at one time by gearsyncd. In case some error happens, the assertion statements are enough.

@jimmyzhai
Copy link
Contributor Author

/Azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jimmyzhai
Copy link
Contributor Author

/Azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

* Add DVS_ENV for module specific dvs env variables
@jimmyzhai jimmyzhai merged commit d23924f into sonic-net:master Sep 30, 2021
raphaelt-nvidia pushed a commit to raphaelt-nvidia/sonic-swss that referenced this pull request Oct 5, 2021
* Add test_gearbox
* Add DVS_ENV for module specific dvs env variables
vaibhavhd added a commit to vaibhavhd/sonic-swss that referenced this pull request Oct 7, 2021
vaibhavhd added a commit to sonic-net/sonic-buildimage that referenced this pull request Oct 9, 2021
[Submodule advance sonic-swss]
Include below commits to master image:

Cache routes for single nexthop for faster retrieval sonic-net/sonic-swss#1922
Reduce route count for route perf test (sonic-net/sonic-swss#1928)
[pytest]: Re-use DVS container when possible (sonic-net/sonic-swss#1816)
[PORTSYNCD] when no ports on config db on init, continue and set Port… (sonic-net/sonic-swss#1861)
[gearbox] Add gearbox unit test (sonic-net/sonic-swss#1920)
Reverted skipped test_buffer_dynamic test cases (sonic-net/sonic-swss#1937)
Revert "[buffer orch] Bugfix: Don't query counter SAI_BUFFER_POOL_STA… (sonic-net/sonic-swss#1945)
Janetxxx pushed a commit to Janetxxx/sonic-swss that referenced this pull request Nov 10, 2025
* Add test_gearbox
* Add DVS_ENV for module specific dvs env variables
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants