Allow buffer profile apply after init#1099
Merged
wendani merged 6 commits intosonic-net:masterfrom Oct 29, 2019
Merged
Conversation
Signed-off-by: Wenda Ni <wenni@microsoft.com>
Contributor
|
Can you please check this PR #515 ? |
Contributor
|
@pavel-shirshov , he only change the log level, is that a concern? |
Contributor
|
@lguohan |
lguohan
approved these changes
Oct 28, 2019
lguohan
requested changes
Oct 28, 2019
Contributor
lguohan
left a comment
lguohan
left a comment
There was a problem hiding this comment.
check the port is down or not. if it is down, then do not need to raise alert. if it is up, then send error message.
physical port is brought up Signed-off-by: Wenda Ni <wenni@microsoft.com>
Signed-off-by: Wenda Ni <wenni@microsoft.com>
Signed-off-by: Wenda Ni <wenni@microsoft.com>
Signed-off-by: Wenda Ni <wenni@microsoft.com>
Contributor
Author
|
retest this please |
renukamanavalan
approved these changes
Oct 29, 2019
renukamanavalan
pushed a commit
that referenced
this pull request
Oct 29, 2019
* Allow buffer profile application after init (i.e., at run time) Signed-off-by: Wenda Ni <wenni@microsoft.com> * Address comment: Alert when a buffer profile is applied after the physical port is brought up Signed-off-by: Wenda Ni <wenni@microsoft.com> * Remove unnecessary space Signed-off-by: Wenda Ni <wenni@microsoft.com> * Correct logic Signed-off-by: Wenda Ni <wenni@microsoft.com> * Correct compile error Signed-off-by: Wenda Ni <wenni@microsoft.com>
yxieca
added
Request for 201811 Branch
Included in 201811 Branch
and removed
Request for 201811 Branch
labels
yxieca
pushed a commit
that referenced
this pull request
Nov 5, 2019
* Allow buffer profile application after init (i.e., at run time) Signed-off-by: Wenda Ni <wenni@microsoft.com> * Address comment: Alert when a buffer profile is applied after the physical port is brought up Signed-off-by: Wenda Ni <wenni@microsoft.com> * Remove unnecessary space Signed-off-by: Wenda Ni <wenni@microsoft.com> * Correct logic Signed-off-by: Wenda Ni <wenni@microsoft.com> * Correct compile error Signed-off-by: Wenda Ni <wenni@microsoft.com>
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
…t#1099) - What I did There is a issue for counters after warm-reboot: If I clear counters by command "sonic-clear counters", then execute 'warm-reboot' and whenSONiC is restart, the counters showed with command "show interface counters" is still old counters before "sonic-clear". It is not the right counters because the counters file in '/tmp' is lost in warm-reboot process. - How I did it I fixed it by saving '/tmp/portstat-0' folders in '/host/' before executing 'warm-reboot', and restore the counters folders back to '/tmp/' after warm-reboot process is finished (in pull request sonic-net/sonic-buildimage#5346 ). - How to verify it Clear counters by command 'sonic-clear' sonic-clear counters sonic-clear dropcounters sonic-clear pfccounters sonic-clear queuecounters sonic-clear rifcounters Execute 'warm-reboot' Use command ‘show interface counters’ to see if the counters is right.
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Mar 1, 2023
- Update SAI VoQ support (sonic-net#1107) … - Voq system (sonic-net#1081) … - [meta] Add support for ignored enum values (sonic-net#1099) - TPID SAI proposal (sonic-net#1089) … - ACL GRE key match (sonic-net#1076) … - Add IPv6 NS and NA Traps (sonic-net#1092) … - MACsec flow list attribute added in MACsec object (sonic-net#1095) … - Add Enterprise Number for IPFIX Report Type (sonic-net#1072) … - Provide TTL and QoS treatment during MPLS encap and decap (sonic-net#1079) - Create and Set for Tunnel Attributes (sonic-net#1086) …
Janetxxx
pushed a commit
to Janetxxx/sonic-swss
that referenced
this pull request
Nov 10, 2025
* Allow buffer profile application after init (i.e., at run time) Signed-off-by: Wenda Ni <wenni@microsoft.com> * Address comment: Alert when a buffer profile is applied after the physical port is brought up Signed-off-by: Wenda Ni <wenni@microsoft.com> * Remove unnecessary space Signed-off-by: Wenda Ni <wenni@microsoft.com> * Correct logic Signed-off-by: Wenda Ni <wenni@microsoft.com> * Correct compile error Signed-off-by: Wenda Ni <wenni@microsoft.com>
jianyuewu
pushed a commit
to jianyuewu/sonic-swss
that referenced
this pull request
Dec 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Why I did it
How I verified it
On brcm dut
Details if related