[aclorch]: Simplify the TCP flags matching code and support exact value match#1072
Merged
stcheng merged 1 commit intosonic-net:masterfrom Oct 10, 2019
Merged
[aclorch]: Simplify the TCP flags matching code and support exact value match#1072stcheng merged 1 commit intosonic-net:masterfrom
stcheng merged 1 commit intosonic-net:masterfrom
Conversation
…ue match Use similar DSCP value parsing logic for TCP falgs value parsing. Remove the deprecated functions. Signed-off-by: Shu0t1an Cheng <shuche@microsoft.com>
prsunny
approved these changes
Sep 28, 2019
Collaborator
prsunny
left a comment
prsunny
left a comment
There was a problem hiding this comment.
This looks really simple. Just curios, was there an issue with old logic?
Contributor
Author
|
@prsunny not really. But with the fix, we could support simplified TCP flags as well without a mask. |
Contributor
Author
|
retest this please |
3 similar comments
Contributor
Author
|
retest this please |
Contributor
Author
|
retest this please |
Contributor
Author
|
retest this please |
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Mar 1, 2023
- Update SAI VoQ support (sonic-net#1107) … - Voq system (sonic-net#1081) … - [meta] Add support for ignored enum values (sonic-net#1099) - TPID SAI proposal (sonic-net#1089) … - ACL GRE key match (sonic-net#1076) … - Add IPv6 NS and NA Traps (sonic-net#1092) … - MACsec flow list attribute added in MACsec object (sonic-net#1095) … - Add Enterprise Number for IPFIX Report Type (sonic-net#1072) … - Provide TTL and QoS treatment during MPLS encap and decap (sonic-net#1079) - Create and Set for Tunnel Attributes (sonic-net#1086) …
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Mar 1, 2023
Co-authored-by: liuh-80 <azureuser@liuh-dev-vm-02.5fg3zjdzj2xezlx1yazx5oxkzd.hx.internal.cloudapp.net>
Janetxxx
pushed a commit
to Janetxxx/sonic-swss
that referenced
this pull request
Nov 10, 2025
…ue match (sonic-net#1072) Use similar DSCP value parsing logic for TCP falgs value parsing. Remove the deprecated functions. Signed-off-by: Shu0t1an Cheng <shuche@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use similar DSCP value parsing logic for TCP falgs value parsing.
Remove the deprecated functions.
Signed-off-by: Shu0t1an Cheng shuche@microsoft.com