not using namespace in header files#1081
Merged
stcheng merged 2 commits intosonic-net:masterfrom Oct 3, 2019
Merged
Conversation
Signed-off-by: Wenda Ni <wenni@microsoft.com>
wendani
force-pushed
the
namespace_master
branch
3 times, most recently
from
920e4e8 to
641cf5d
Compare
stcheng
approved these changes
Oct 3, 2019
stcheng
suggested changes
Oct 3, 2019
Contributor
stcheng
left a comment
stcheng
left a comment
There was a problem hiding this comment.
https://sonic-jenkins.westus2.cloudapp.azure.com/job/vs/job/sonic-swss-build-pr/739/console
could you check the compiling errors?
qiluo-msft
approved these changes
Oct 3, 2019
wendani
force-pushed
the
namespace_master
branch
19 times, most recently
from
8cd1f56 to
bd3922a
Compare
Signed-off-by: Wenda Ni <wenni@microsoft.com>
wendani
force-pushed
the
namespace_master
branch
from
bd3922a to
7e0b722
Compare
Contributor
Author
|
Fixed compile error. #1081 (review) |
Contributor
Author
|
retest this please |
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
* show_interface transceiver changes for multi-asic, takes care of sub commands
eeprom Show interface transceiver EEPROM information
lpmode Show interface transceiver low-power mode...
presence Show interface transceiver presence
* Rearranging of common functions in config/main.py to py-common
* Updates to show command and testcases
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Mar 1, 2023
- Update SAI VoQ support (sonic-net#1107) … - Voq system (sonic-net#1081) … - [meta] Add support for ignored enum values (sonic-net#1099) - TPID SAI proposal (sonic-net#1089) … - ACL GRE key match (sonic-net#1076) … - Add IPv6 NS and NA Traps (sonic-net#1092) … - MACsec flow list attribute added in MACsec object (sonic-net#1095) … - Add Enterprise Number for IPFIX Report Type (sonic-net#1072) … - Provide TTL and QoS treatment during MPLS encap and decap (sonic-net#1079) - Create and Set for Tunnel Attributes (sonic-net#1086) …
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Mar 1, 2023
Signed-off-by: Ze Gan <ganze718@gmail.com>
Janetxxx
pushed a commit
to Janetxxx/sonic-swss
that referenced
this pull request
Nov 10, 2025
Signed-off-by: Wenda Ni <wenni@microsoft.com>
jianyuewu
pushed a commit
to jianyuewu/sonic-swss
that referenced
this pull request
Dec 24, 2025
Add a checker to prevent adding new CFG_ macros when update common/schema.h. Why I did it CFG_XXX_TABLE_NAME macros should be auto-generated from YANG models via cfg_schema.h. How I did it Introduced .github/workflows/prevent-cfg.yml which runs on PRs that modify common/schema.h. It extracts all CFG_ macros defined in the file and compares them against an allowed legacy list. Work item tracking Microsoft ADO: 35075048
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Why I did it
How I verified it
Details if related