Commit 81b42ed
committed
Fix Meta layer bulk operations
PR1613 was proposed to ignore errors during bulk operations if
SAI_BULK_OP_ERROR_MODE_IGNORE_ERROR is set. But it was reverted as it
caused regression in test_duplicate_route.py because validation errors
are ignored and some SAI can successfully add duplicated route. Later,
createObject will called on already existed entries in
meta_generic_validation_post_create, and throws a fatal runtime_error
exception.
This fix removes entries that fail validation checks before passing to
SAI during bulk operations with SAI_BULK_OP_ERROR_MODE_IGNORE_ERROR, and
populates object_statuses with validation results for those entries.1 parent bd820a0 commit 81b42ed
1 file changed
Lines changed: 172 additions & 66 deletions
0 commit comments