[202205]Use SAI_STATUS_ITEM_NOT_FOUND when key not found (#1224)#1237
Merged
akokhan merged 2 commits intosonic-net:202205from Jun 29, 2023
Merged
[202205]Use SAI_STATUS_ITEM_NOT_FOUND when key not found (#1224)#1237akokhan merged 2 commits intosonic-net:202205from
akokhan merged 2 commits intosonic-net:202205from
Conversation
Contributor
theasianpianist
commented
May 4, 2023
theasianpianist
commented
- Use SAI_STATUS_ITEM_NOT_FOUND when key not found
- Add unit tests for Meta SAI validation
- generate coverage info for Meta.cpp
* Use SAI_STATUS_ITEM_NOT_FOUND when key not found * Add unit tests for Meta SAI validation * generate coverage info for Meta.cpp Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
|
I believe CI is failing because of missing fix here Line 3621 in 5808260 |
Contributor
|
Thanks @andriy-kokhan , @theasianpianist , can you check? |
kcudnik
approved these changes
May 6, 2023
Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
|
/azp run |
|
Commenter does not have sufficient privileges for PR 1237 in repo sonic-net/sonic-sairedis |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
theasianpianist
changed the title
Contributor
Author
|
/Azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/Azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
Waiting for #1238 to be cherry-picked to 202205 |
Contributor
Author
|
/Azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.