Use SAI_STATUS_ITEM_NOT_FOUND when key not found#1224
Merged
theasianpianist merged 12 commits intosonic-net:masterfrom Apr 19, 2023
Merged
Use SAI_STATUS_ITEM_NOT_FOUND when key not found#1224theasianpianist merged 12 commits intosonic-net:masterfrom
theasianpianist merged 12 commits intosonic-net:masterfrom
Conversation
Signed-off-by: Lawrence Lee <[email protected]>
Signed-off-by: Lawrence Lee <[email protected]>
Collaborator
|
please fix build issues |
Signed-off-by: Lawrence Lee <[email protected]>
theasianpianist
force-pushed
the
sai-item-not-found
branch
from
996152f to
4b77171
Compare
Signed-off-by: Lawrence Lee <[email protected]>
Signed-off-by: Lawrence Lee <[email protected]>
Signed-off-by: Lawrence Lee <[email protected]>
Signed-off-by: Lawrence Lee <[email protected]>
Signed-off-by: Lawrence Lee <[email protected]>
saiarcot895
reviewed
Apr 14, 2023
saiarcot895
previously approved these changes
Apr 14, 2023
Contributor
Author
|
/Azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Lawrence Lee <[email protected]>
Signed-off-by: Lawrence Lee <[email protected]>
Signed-off-by: Lawrence Lee <[email protected]>
saiarcot895
reviewed
Apr 18, 2023
.azure-pipelines/build-template.yml
Outdated
| for dir in ${gcov_dirs}; do | ||
| source_dir=$(dirname $dir) | ||
| output_file="coverage-$source_dir.json" | ||
| gcovr --json-pretty -o $output_file --object-directory $source_dir $dir |
Contributor
There was a problem hiding this comment.
Do you need to add in --exclude-unreachable-branches here?
Contributor
Author
There was a problem hiding this comment.
good catch, added
Signed-off-by: Lawrence Lee <[email protected]>
saiarcot895
approved these changes
Apr 18, 2023
prsunny
approved these changes
Apr 18, 2023
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kcudnik
approved these changes
Apr 19, 2023
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yxieca
added
Request for 202111 Branch
Request for 202211 Branch
Cherry Pick Conflict_202205
and removed
Request for 202111 Branch
labels
Contributor
|
@theasianpianist is there a bug filed for this issue? It cannot be cherry-picked to 202205 cleanly. Please enter separate PR. |
theasianpianist
added a commit
to theasianpianist/sonic-sairedis
that referenced
this pull request
May 4, 2023
* Use SAI_STATUS_ITEM_NOT_FOUND when key not found * Add unit tests for Meta SAI validation * generate coverage info for Meta.cpp Signed-off-by: Lawrence Lee <[email protected]>
Contributor
Author
PR here: #1237 There is no bug for this issue, but it's to support the changes made in this PR: sonic-net/sonic-swss#2714 |
yxieca
pushed a commit
that referenced
this pull request
Aug 29, 2023
* Use SAI_STATUS_ITEM_NOT_FOUND when key not found * Add unit tests for Meta SAI validation * generate coverage info for Meta.cpp Signed-off-by: Lawrence Lee <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SAI_STATUS_ITEM_NOT_FOUNDif the key being operated on doesn't exist