Fix issue: should always check return value of a function if the function may return None#350
Merged
prgeor merged 2 commits intosonic-net:masterfrom Mar 28, 2023
Merged
Conversation
|
|
Contributor
Author
|
/easycla |
2 similar comments
Contributor
Author
|
/easycla |
Contributor
Author
|
/easycla |
Contributor
Author
|
/easycla |
1 similar comment
Contributor
Author
|
/easycla |
Collaborator
prgeor
reviewed
Mar 7, 2023
| 'low warn': laser_temp_low_warn} | ||
| return laser_temp_dict | ||
|
|
||
| def _get_laser_temp_threshold(self, field): |
Collaborator
There was a problem hiding this comment.
what about other fields which can result in read failure
Contributor
Author
There was a problem hiding this comment.
I have added a UT case to randomly return None for EEPROM read. For now, I fixed all issues found by the UT case. For other field which I did not touch, I assume the return value is properly checked/handled (not 100% sure).
keboliu
previously approved these changes
Mar 7, 2023
Junchao-Mellanox
force-pushed
the
fix-crash
branch
from
0dad404 to
b6897d7
Compare
…tion may return None Fix unit test failure
Junchao-Mellanox
force-pushed
the
fix-crash
branch
from
b6897d7 to
9a60097
Compare
Contributor
Author
|
Hi @prgeor , the easycla checker has passed, could you please help review ? |
Collaborator
|
@Junchao-Mellanox is it needed on other branches? if so, to which? |
prgeor
reviewed
Mar 21, 2023
Comment on lines
+1760
to
+1764
| for lane in range(1, self.NUM_CHANNELS+1): | ||
| trans_status['txbiashighalarm_flag%d' % lane] = tx_bias_flag_dict['tx_bias_high_alarm']['TxBiasHighAlarmFlag%d' % lane] | ||
| trans_status['txbiaslowalarm_flag%d' % lane] = tx_bias_flag_dict['tx_bias_low_alarm']['TxBiasLowAlarmFlag%d' % lane] | ||
| trans_status['txbiashighwarning_flag%d' % lane] = tx_bias_flag_dict['tx_bias_high_warn']['TxBiasHighWarnFlag%d' % lane] | ||
| trans_status['txbiaslowwarning_flag%d' % lane] = tx_bias_flag_dict['tx_bias_low_warn']['TxBiasLowWarnFlag%d' % lane] |
Collaborator
There was a problem hiding this comment.
@Junchao-Mellanox if tx_bias_flag_dict{} is None how should the caller handle?
Contributor
Author
There was a problem hiding this comment.
We checked
if tx_bias_flag_dict:
Collaborator
|
@mihirpat1 can you review |
mihirpat1
approved these changes
Mar 22, 2023
Contributor
Author
|
Hi @prgeor , could you please help review and sign-off? |
prgeor
approved these changes
Mar 28, 2023
Junchao-Mellanox
added a commit
to Junchao-Mellanox/sonic-platform-common
that referenced
this pull request
Mar 31, 2023
…tion may return None (sonic-net#350) Fix unit test failure Conflicts: tests/sonic_xcvr/test_sff8436.py tests/sonic_xcvr/test_sff8472.py tests/sonic_xcvr/test_sff8636.py
Contributor
Author
Junchao-Mellanox
added a commit
to Junchao-Mellanox/sonic-platform-common
that referenced
this pull request
Mar 31, 2023
…tion may return None (sonic-net#350) Fix unit test failure Conflicts: tests/sonic_xcvr/test_sff8436.py tests/sonic_xcvr/test_sff8636.py
StormLiangMS
pushed a commit
that referenced
this pull request
Apr 13, 2023
…tion may return None (#350) (#355) Backport #355 to 202211 Description When a function may return None, caller should always check the return value before using it. This PR is to fix such issues in sonic-xcvr. Motivation and Context When a function may return None, caller should always check the return value before using it. This PR is to fix such issues in sonic-xcvr. How Has This Been Tested? Created unit test cases to avoid such thing happening
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a function may return None, caller should always check the return value before using it. This PR is to fix such issues in sonic-xcvr.
Motivation and Context
When a function may return None, caller should always check the return value before using it. This PR is to fix such issues in sonic-xcvr.
How Has This Been Tested?
Created unit test cases to avoid such thing happening
Additional Information (Optional)