[Backport] [202205] Fix issue: should always check return value of a function if the function may return None#356
Merged
yxieca merged 2 commits intosonic-net:202205from Apr 17, 2023
Conversation
…tion may return None (sonic-net#350) Fix unit test failure Conflicts: tests/sonic_xcvr/test_sff8436.py tests/sonic_xcvr/test_sff8636.py
Junchao-Mellanox
changed the title
prgeor
approved these changes
Apr 10, 2023
Collaborator
|
@yxieca please help to merge |
keboliu
approved these changes
Apr 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #350 to 202205
Description
When a function may return None, caller should always check the return value before using it. This PR is to fix such issues in sonic-xcvr.
Motivation and Context
When a function may return None, caller should always check the return value before using it. This PR is to fix such issues in sonic-xcvr.
How Has This Been Tested?
Created unit test cases to avoid such thing happening
Additional Information (Optional)