[Backport] [202211] Fix issue: should always check return value of a function if the function may return None#355
Merged
StormLiangMS merged 1 commit intosonic-net:202211from Apr 13, 2023
Conversation
…tion may return None (sonic-net#350) Fix unit test failure Conflicts: tests/sonic_xcvr/test_sff8436.py tests/sonic_xcvr/test_sff8472.py tests/sonic_xcvr/test_sff8636.py
Junchao-Mellanox
changed the title
Contributor
Author
|
/azpw run Azure.sonic-platform-common |
Collaborator
|
/AzurePipelines run Azure.sonic-platform-common |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
@prgeor could you please help to review and merge? |
prgeor
approved these changes
Apr 10, 2023
Collaborator
|
@StormLiangMS to merge this for 202211 |
keboliu
approved these changes
Apr 12, 2023
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-platform-common
that referenced
this pull request
Oct 25, 2024
…onic-net#355) This change onboards refactor of various redis DB opens in y_cable_table-helper.py file and is required to onboard y_cable_async_client PR sonic-net#327 Basically it has changes for all the table to be now exclusively opened once per class instance . It also accommodates refactor for getting async channels open given the params to open it. Description Motivation and Context refactor ycabled How Has This Been Tested? UT and deploy changes on test DUT Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #355 to 202211
Description
When a function may return None, caller should always check the return value before using it. This PR is to fix such issues in sonic-xcvr.
Motivation and Context
When a function may return None, caller should always check the return value before using it. This PR is to fix such issues in sonic-xcvr.
How Has This Been Tested?
Created unit test cases to avoid such thing happening
Additional Information (Optional)