Loading config before getting red_min_threshold value.

[iris00522]

Description of PR

I get the two fail messages when we run the test item of ecn_wred .

1.TASK [test : Get WRED objects] *************************************************
fatal: [as7816-64x]: FAILED! => {"changed": true, "cmd": "docker exec database redis-cli -n 1 --eval /tmp/get_red_min.lua , 516096 | grep 516096", "delta": "0:00:00.190708", "end": "2019-07-04 03:43:29.729493", "failed": true, "failed_when_result": true, "invocation": {"module_args": {"_raw_params": "docker exec database redis-cli -n 1 --eval /tmp/get_red_min.lua , 516096 | grep 516096", "_uses_shell": true, "chdir": null, "creates": null, "executable": null, "removes": null, "warn": true}, "module_name": "command"}, "rc": 1, "start": "2019-07-04 03:43:29.538785", "stderr": "", "stdout": "", "stdout_lines": [], "warnings": []}

2.TASK [test : Restore original value] *******************************************
fatal: [as7816-64x]: FAILED! => {"changed": true, "cmd": "ecnconfig -p AZURE_LOSSY -rmin ", "delta": "0:00:00.090793", "end": "2019-07-04 03:43:30.075148", "failed": true, "failed_when_result": true, "invocation": {"module_args": {"_raw_params": "ecnconfig -p AZURE_LOSSY -rmin ", "_uses_shell": true, "chdir": null, "creates": null, "executable": null, "removes": null, "warn": true}, "module_name": "command"}, "rc": 2, "start": "2019-07-04 03:43:29.984355", "stderr": "usage: ecnconfig [-h] [-v] [-l] [-p PROFILE] [-gmin GREEN_MIN]\n [-gmax GREEN_MAX] [-ymin YELLOW_MIN] [-ymax YELLOW_MAX]\n [-rmin RED_MIN] [-rmax RED_MAX] [-gdrop GREEN_DROP_PROB]\n [-ydrop YELLOW_DROP_PROB] [-rdrop RED_DROP_PROB] [-vv]\n [-q QUEUE]\n [{on,off}]\necnconfig: error: argument -rmin/--red-min: expected one argument", "stdout": "", "stdout_lines": [], "warnings": []}

---

I think the issue is caused by getting red_min_threshold value fail.

TASK [test : set_fact] *********************************************************
ok: [as7816-64x] => {"ansible_facts": {"red_min_threshold": ""}, "changed": false, "invocation": {"module_args": {"red_min_threshold": ""}, "module_name": "set_fact"}}

Type of change

• [] Bug fix
• [] Testbed and Framework(new/improvement)
• [+] Test case(new/improvement)

Approach

How did you do it?

I load the configuration file before running the test with getting red_min_threshold value.
Add the test steps, the two issues can be fixed.

How did you verify/test it?

Tested on the broadcom platform.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

[vincent201881]

Maybe you could pre-check the "AZURE_LOSSY rmin " is already configured or not, if not exist then to config the AZURE_LOSSY.

[iris00522]

@vincent201881 Please review again.