Skip to content

Add 't0-56' testbed_type for fib_test.#1002

Closed
iris00522 wants to merge 3 commits intosonic-net:masterfrom
iris00522:bgp
Closed

Add 't0-56' testbed_type for fib_test.#1002
iris00522 wants to merge 3 commits intosonic-net:masterfrom
iris00522:bgp

Conversation

@iris00522
Copy link
Copy Markdown
Contributor

Description of PR

It's the same issue with losing t0-56 testbed_type.
I base on #954 bug fix to test bgp_speaker and I get the a fail messages when we run the test item of bgp_speaker.

"FAIL: fib_test.FibTest",
    "----------------------------------------------------------------------",
    "Traceback (most recent call last):",
    "  File \"ptftests/fib_test.py\", line 290, in runTest",
    "    self.check_ip_range()",
    "  File \"ptftests/fib_test.py\", line 138, in check_ip_range",
    "    self.check_ip_route(src_port, ip_range.get_last_ip(), exp_port_list, ipv4)",
    "  File \"ptftests/fib_test.py\", line 155, in check_ip_route",
    "    (matched_index, received) = self.check_ipv4_route(src_port, dst_ip_addr, dst_port_list)",
    "  File \"ptftests/fib_test.py\", line 200, in check_ipv4_route",
    "    return verify_packet_any_port(self, masked_exp_pkt, dst_port_list)",
    "  File \"/usr/lib/python2.7/dist-packages/ptf/testutils.py\", line 2373, in verify_packet_any_port",
    "    % (ports, device_number, result.format()))",
    "AssertionError: Did not receive expected packet on any of ports [2, 3, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 18, 19, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31] for device 0.",

I move the judgement of t0-64-32 to the self.src_ports = range(1, 25) + range(28, 32), and the test is success.

Summary:
Fixes #966

Type of change

  • [] Bug fix
  • [] Testbed and Framework(new/improvement)
  • [v] Test case(new/improvement)

Approach

How did you do it?

How did you verify/test it?

add t0-56 testbed_type.

Any platform specific information?

Tested on the broadcom platform.

Documentation

@iris00522 iris00522 closed this Aug 8, 2019
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
As part of this commit and previous commit ff6cb6c
sonic-utilities submodule for 201911 has been updated to take following
changes:

 Add support for QSFP-DD cables on 'show' command (sonic-net#989)
 [show] Fix for 'trunk' PortChannel reported as 'routed' port (sonic-net#1002)
Enable HW watchdog before fast-reboot (sonic-net#977)
 [filter-fdb] Check VLAN Presence When Filter FDB (sonic-net#957) (sonic-net#975)
[filter-fdb] Fix For Vlan Defined With No CIDR (sonic-net#976)
 [show/config]: combine feature and container feature cli (sonic-net#1015)
sdszhang pushed a commit to sdszhang/sonic-mgmt that referenced this pull request Mar 23, 2026
…-net#1002)

<!--
Please make sure you've read and understood our contributing guidelines;
https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md

Please provide following information to help code review process a bit easier:
-->
### Description of PR
<!--
- Please include a summary of the change and which issue is fixed.
- Please also include relevant motivation and context. Where should reviewer start? background context?
- List any dependencies that are required for this change.
-->

Summary:
Fix the issue where PTF container is not reachable if MAC address was changed after rebuilding container.

There will be a timeout for task "wait until ptf is reachable". When it happens, the gateway still uses the old MAC for the ptf container, which needs to be updated before initiating reachability test.

### Type of change

<!--
- Fill x for your type of change.
- e.g.
- [x] Bug fix
-->

- [ ] Bug fix
- [ ] Testbed and Framework(new/improvement)
- [ ] New Test case
 - [ ] Skipped for non-supported platforms
- [ ] Test case improvement

### Back port request
- [ ] 202205
- [ ] 202305
- [ ] 202311
- [ ] 202405
- [ ] 202411
- [ ] 202505
- [ ] 202511

### Approach
#### What is the motivation for this PR?
PTF timeout after rebuilding PTF container.

#### How did you do it?
trigger GARP before PTF reachability test.

#### How did you verify/test it?
On local testbed.

#### Any platform specific information?

#### Supported testbed topology if it's a new test case?

### Documentation
<!--
(If it's a new feature, new test case)
Did you update documentation/Wiki relevant to your implementation?
Link to the wiki page?
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[fib.j2] there is no testbed_type defined as 't0-64-32'

1 participant